You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2020/12/14 15:33:13 UTC
[GitHub] [incubator-nuttx] hartmannathan opened a new pull request #2535: arch/stm32: Fix nxstyle errors
hartmannathan opened a new pull request #2535:
URL: https://github.com/apache/incubator-nuttx/pull/2535
## Summary
arch/arm/src/stm32/stm32_usbhost.h:
* Fix nxstyle errors.
## Impact
Removes nxstyle errors.
## Testing
nxstyle
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] jerpelea merged pull request #2535: arch/stm32: Fix nxstyle errors
Posted by GitBox <gi...@apache.org>.
jerpelea merged pull request #2535:
URL: https://github.com/apache/incubator-nuttx/pull/2535
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] xiaoxiang781216 commented on a change in pull request #2535: arch/stm32: Fix nxstyle errors
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on a change in pull request #2535:
URL: https://github.com/apache/incubator-nuttx/pull/2535#discussion_r542512982
##########
File path: arch/arm/src/stm32/stm32_usbhost.h
##########
@@ -49,16 +49,17 @@
#include "hardware/stm32fxxxxx_otgfs.h"
#include "hardware/stm32_otghs.h"
-#if (defined(CONFIG_STM32_OTGFS) || defined(CONFIG_STM32_OTGHS)) && defined(CONFIG_STM32_USBHOST)
+#if (defined(CONFIG_STM32_OTGFS) || defined(CONFIG_STM32_OTGHS)) &&
Review comment:
need add \ after &&
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] hartmannathan commented on a change in pull request #2535: arch/stm32: Fix nxstyle errors
Posted by GitBox <gi...@apache.org>.
hartmannathan commented on a change in pull request #2535:
URL: https://github.com/apache/incubator-nuttx/pull/2535#discussion_r542616629
##########
File path: arch/arm/src/stm32/stm32_usbhost.h
##########
@@ -49,16 +49,17 @@
#include "hardware/stm32fxxxxx_otgfs.h"
#include "hardware/stm32_otghs.h"
-#if (defined(CONFIG_STM32_OTGFS) || defined(CONFIG_STM32_OTGHS)) && defined(CONFIG_STM32_USBHOST)
+#if (defined(CONFIG_STM32_OTGFS) || defined(CONFIG_STM32_OTGHS)) &&
Review comment:
Thank you.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] xiaoxiang781216 commented on a change in pull request #2535: arch/stm32: Fix nxstyle errors
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on a change in pull request #2535:
URL: https://github.com/apache/incubator-nuttx/pull/2535#discussion_r542513288
##########
File path: arch/arm/src/stm32/stm32_usbhost.h
##########
@@ -255,33 +252,37 @@ extern "C"
#define EXTERN extern
#endif
-/***********************************************************************************
+/****************************************************************************
* Name: stm32_usbhost_vbusdrive
*
* Description:
- * Enable/disable driving of VBUS 5V output. This function must be provided be
- * each platform that implements the STM32 OTG FS host interface
+ * Enable/disable driving of VBUS 5V output. This function must be
+ * provided be each platform that implements the STM32 OTG FS host
+ * interface.
*
- * "On-chip 5 V VBUS generation is not supported. For this reason, a charge pump
- * or, if 5 V are available on the application board, a basic power switch, must
- * be added externally to drive the 5 V VBUS line. The external charge pump can
- * be driven by any GPIO output. When the application decides to power on VBUS
- * using the chosen GPIO, it must also set the port power bit in the host port
- * control and status register (PPWR bit in OTG_FS_HPRT).
+ * "On-chip 5 V VBUS generation is not supported. For this reason, a
+ * charge pump or, if 5 V are available on the application board, a basic
+ * power switch, must be added externally to drive the 5 V VBUS line. The
+ * external charge pump can be driven by any GPIO output. When the
+ * application decides to power on VBUS using the chosen GPIO, it must
+ * also set the port power bit in the host port control and status
+ * register (PPWR bit in OTG_FS_HPRT).
*
- * "The application uses this field to control power to this port, and the core
- * clears this bit on an overcurrent condition."
+ * "The application uses this field to control power to this port, and the
+ * core clears this bit on an overcurrent condition."
*
* Input Parameters:
- * iface - For future growth to handle multiple USB host interface. Should be zero.
+ * iface - For future growth to handle multiple USB host interface.
+ * Should be zero.
* enable - true: enable VBUS power; false: disable VBUS power
*
* Returned Value:
* None
*
- ***********************************************************************************/
+ ****************************************************************************/
-#if defined(CONFIG_STM32_OTGFS_VBUS_CONTROL) || defined(CONFIG_STM32_OTGHS_VBUS_CONTROL)
+#if defined(CONFIG_STM32_OTGFS_VBUS_CONTROL) ||
Review comment:
need add \ after ||
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org