You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by "Matthias Pohl (Jira)" <ji...@apache.org> on 2023/03/06 16:41:00 UTC
[jira] [Comment Edited] (FLINK-31339) PlannerScalaFreeITCase.testImperativeUdaf
[ https://issues.apache.org/jira/browse/FLINK-31339?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17696903#comment-17696903 ]
Matthias Pohl edited comment on FLINK-31339 at 3/6/23 4:40 PM:
---------------------------------------------------------------
[~jark] [~Jiangang] can you have a look at it. This test was added as part of FLINK-27790. You both showed up in the commit as author and commiter. That's why I selected you.
In general, this test relies on some timeout (see [SqlITCaseBase:149|https://github.com/apache/flink/blob/469049a4359aea40f083bb2b7e4fbc1f86b65ce9/flink-end-to-end-tests/flink-end-to-end-tests-sql/src/test/java/org/apache/flink/table/sql/codegen/SqlITCaseBase.java#L149] which we shouldn't use in tests anymore (see [Flink Coding Guidelines|https://flink.apache.org/how-to-contribute/code-style-and-quality-common/#avoid-timeouts-in-junit-tests]). I'm not sure whether that's the reason for the test instability.
Can you give us some advice on whether that's a serious issue or whether we can lower the priority?
was (Author: mapohl):
[~jark] [~Jiangang] can you have a look at it. This test was added as part of FLINK-27790. You both showed up in the commit as author and commiter. That's why I selected you.
In general, this test relies on some timeout (see SqlITCaseBase:149|https://github.com/apache/flink/blob/469049a4359aea40f083bb2b7e4fbc1f86b65ce9/flink-end-to-end-tests/flink-end-to-end-tests-sql/src/test/java/org/apache/flink/table/sql/codegen/SqlITCaseBase.java#L149] which we shouldn't use in tests anymore (see [Flink Coding Guidelines|https://flink.apache.org/how-to-contribute/code-style-and-quality-common/#avoid-timeouts-in-junit-tests]). I'm not sure whether that's the reason for the test instability.
Can you give us some advice on whether that's a serious issue or whether we can lower the priority?
> PlannerScalaFreeITCase.testImperativeUdaf
> -----------------------------------------
>
> Key: FLINK-31339
> URL: https://issues.apache.org/jira/browse/FLINK-31339
> Project: Flink
> Issue Type: Bug
> Components: Table SQL / Planner
> Affects Versions: 1.17.0
> Reporter: Matthias Pohl
> Priority: Blocker
> Labels: test-stability
>
> {{PlannerScalaFreeITCase.testImperativeUdaf}} failed:
> https://dev.azure.com/apache-flink/apache-flink/_build/results?buildId=46812&view=logs&j=87489130-75dc-54e4-1f45-80c30aa367a3&t=73da6d75-f30d-5d5a-acbe-487a9dcff678&l=15012
> {code}
> Mar 05 05:55:50 [ERROR] Tests run: 2, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: 62.028 s <<< FAILURE! - in org.apache.flink.table.sql.codegen.PlannerScalaFreeITCase
> Mar 05 05:55:50 [ERROR] PlannerScalaFreeITCase.testImperativeUdaf Time elapsed: 40.924 s <<< FAILURE!
> Mar 05 05:55:50 org.opentest4j.AssertionFailedError: Did not get expected results before timeout, actual result: [{"before":null,"after":{"user_name":"Bob","order_cnt":1},"op":"c"}, {"before":null,"after":{"user_name":"Alice","order_cnt":1},"op":"c"}, {"before":{"user_name":"Bob","order_cnt":1},"after":null,"op":"d"}, {"before":null,"after":{"user_name":"Bob","order_cnt":2},"op":"c"}]. ==> expected: <true> but was: <false>
> Mar 05 05:55:50 at org.junit.jupiter.api.AssertionFailureBuilder.build(AssertionFailureBuilder.java:151)
> Mar 05 05:55:50 at org.junit.jupiter.api.AssertionFailureBuilder.buildAndThrow(AssertionFailureBuilder.java:132)
> Mar 05 05:55:50 at org.junit.jupiter.api.AssertTrue.failNotTrue(AssertTrue.java:63)
> Mar 05 05:55:50 at org.junit.jupiter.api.AssertTrue.assertTrue(AssertTrue.java:36)
> Mar 05 05:55:50 at org.junit.jupiter.api.Assertions.assertTrue(Assertions.java:211)
> Mar 05 05:55:50 at org.apache.flink.table.sql.codegen.SqlITCaseBase.checkJsonResultFile(SqlITCaseBase.java:168)
> Mar 05 05:55:50 at org.apache.flink.table.sql.codegen.SqlITCaseBase.runAndCheckSQL(SqlITCaseBase.java:111)
> Mar 05 05:55:50 at org.apache.flink.table.sql.codegen.PlannerScalaFreeITCase.testImperativeUdaf(PlannerScalaFreeITCase.java:43)
> [...]
> {code}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)