You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2020/02/10 21:12:35 UTC
[GitHub] [incubator-superset] villebro opened a new pull request #9111: fix:
restrict werkzeug to <1.0 in setup.py
villebro opened a new pull request #9111: fix: restrict werkzeug to <1.0 in setup.py
URL: https://github.com/apache/incubator-superset/pull/9111
### CATEGORY
Choose one
- [x] Bug Fix
- [ ] Enhancement (new features, refinement)
- [ ] Refactor
- [ ] Add tests
- [ ] Build / Development Environment
- [ ] Documentation
### SUMMARY
With the release of `werkzeug 1.0.0`, installing via `pip` pulls in a version of `werkzeug` which is not currently compatible with superset. This PR restricts the version of `werkzeug` to `<1.0` in `setup.py`, ensuring that installation via `pip` works properly.
### TEST PLAN
Test locally
### ADDITIONAL INFORMATION
<!--- Check any relevant boxes with "x" -->
<!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
- [x] Has associated issue: closes #9110
- [ ] Changes UI
- [ ] Requires DB Migration.
- [ ] Confirm DB Migration upgrade and downgrade tested.
- [ ] Introduces new feature or API
- [ ] Removes existing feature or API
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] villebro commented on issue #9111: fix:
restrict werkzeug to <1.0 in setup.py
Posted by GitBox <gi...@apache.org>.
villebro commented on issue #9111: fix: restrict werkzeug to <1.0 in setup.py
URL: https://github.com/apache/incubator-superset/pull/9111#issuecomment-584700157
Closing as there is a cleaner way to fix this.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] villebro closed pull request #9111: fix:
restrict werkzeug to <1.0 in setup.py
Posted by GitBox <gi...@apache.org>.
villebro closed pull request #9111: fix: restrict werkzeug to <1.0 in setup.py
URL: https://github.com/apache/incubator-superset/pull/9111
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io commented on issue #9111: fix:
restrict werkzeug to <1.0 in setup.py
Posted by GitBox <gi...@apache.org>.
codecov-io commented on issue #9111: fix: restrict werkzeug to <1.0 in setup.py
URL: https://github.com/apache/incubator-superset/pull/9111#issuecomment-584362315
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9111?src=pr&el=h1) Report
> Merging [#9111](https://codecov.io/gh/apache/incubator-superset/pull/9111?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/291306392443a5a0d0e2ee0cc4a95d37c56d4589?src=pr&el=desc) will **not change** coverage.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/incubator-superset/pull/9111?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #9111 +/- ##
======================================
Coverage 59.1% 59.1%
======================================
Files 372 372
Lines 11920 11920
Branches 2917 2917
======================================
Hits 7045 7045
Misses 4693 4693
Partials 182 182
```
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9111?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9111?src=pr&el=footer). Last update [2913063...c20a25e](https://codecov.io/gh/apache/incubator-superset/pull/9111?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org