You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2021/05/21 14:26:36 UTC
[GitHub] [spark] cloud-fan opened a new pull request #32622: [SPARK-34558][SQL][FOLLOWUP] Do not fail Spark startup with a broken FileSystem
cloud-fan opened a new pull request #32622:
URL: https://github.com/apache/spark/pull/32622
<!--
Thanks for sending a pull request! Here are some tips for you:
1. If this is your first time, please read our contributor guidelines: https://spark.apache.org/contributing.html
2. Ensure you have added or run the appropriate tests for your PR: https://spark.apache.org/developer-tools.html
3. If the PR is unfinished, add '[WIP]' in your PR title, e.g., '[WIP][SPARK-XXXX] Your PR title ...'.
4. Be sure to keep the PR description updated to reflect all changes.
5. Please write your PR title to summarize what this PR proposes.
6. If possible, provide a concise example to reproduce the issue for a faster review.
7. If you want to add a new configuration, please read the guideline first for naming configurations in
'core/src/main/scala/org/apache/spark/internal/config/ConfigEntry.scala'.
8. If you want to add or modify an error message, please read the guideline first:
https://spark.apache.org/error-message-guidelines.html
-->
### What changes were proposed in this pull request?
<!--
Please clarify what changes you are proposing. The purpose of this section is to outline the changes and how this PR fixes the issue.
If possible, please consider writing useful notes for better and faster reviews in your PR. See the examples below.
1. If you refactor some codes with changing classes, showing the class hierarchy will help reviewers.
2. If you fix some SQL features, you can provide some references of other DBMSes.
3. If there is design documentation, please add the link.
4. If there is a discussion in the mailing list, please add the link.
-->
This is a followup of https://github.com/apache/spark/pull/31671
https://github.com/apache/spark/pull/31671 qualifies the warehouse at the beginning, which may fail Spark startup if something goes wrong, like the underlying FileSystem can't be initialized.
This PR falls back to the old behavior and leave the warehouse path unqualified if qualifying fails.
### Why are the changes needed?
<!--
Please clarify why the changes are needed. For instance,
1. If you propose a new API, clarify the use case for a new API.
2. If you fix a bug, you can clarify why it is a bug.
-->
Fix a regression. It's important to be always able to start Spark app (e.g. spark-shell), so that we can debug.
### Does this PR introduce _any_ user-facing change?
<!--
Note that it means *any* user-facing change including all aspects such as the documentation fix.
If yes, please clarify the previous behavior and the change this PR proposes - provide the console output, description and/or an example to show the behavior difference if possible.
If possible, please also clarify if this is a user-facing change compared to the released Spark versions or within the unreleased branches such as master.
If no, write 'No'.
-->
No
### How was this patch tested?
<!--
If tests were added, say they were added here. Please make sure to add some test cases that check the changes thoroughly including negative and positive cases if possible.
If it was tested in a way different from regular unit tests, please clarify how you tested step by step, ideally copy and paste-able, so that other reviewers can test and check, and descendants can verify in the future.
If tests were not added, please describe why they were not added and/or why it was difficult to add.
-->
a new test case
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun closed pull request #32622: [SPARK-34558][SQL][FOLLOWUP] Do not fail Spark startup with a broken FileSystem
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun closed pull request #32622:
URL: https://github.com/apache/spark/pull/32622
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #32622: [SPARK-34558][SQL][FOLLOWUP] Do not fail Spark startup with a broken FileSystem
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #32622:
URL: https://github.com/apache/spark/pull/32622#issuecomment-845988561
**[Test build #138807 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/138807/testReport)** for PR 32622 at commit [`82924f7`](https://github.com/apache/spark/commit/82924f73a02a7b30043635df03f665151983fd89).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan commented on pull request #32622: [SPARK-34558][SQL][FOLLOWUP] Do not fail Spark startup with a broken FileSystem
Posted by GitBox <gi...@apache.org>.
cloud-fan commented on pull request #32622:
URL: https://github.com/apache/spark/pull/32622#issuecomment-845988147
cc @yaooqinn
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #32622: [SPARK-34558][SQL][FOLLOWUP] Do not fail Spark startup with a broken FileSystem
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #32622:
URL: https://github.com/apache/spark/pull/32622#issuecomment-846021386
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/43329/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] yaooqinn commented on pull request #32622: [SPARK-34558][SQL][FOLLOWUP] Do not fail Spark startup with a broken FileSystem
Posted by GitBox <gi...@apache.org>.
yaooqinn commented on pull request #32622:
URL: https://github.com/apache/spark/pull/32622#issuecomment-846032354
For the thrift server, could this change lead an unhealthy server for end-users?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #32622: [SPARK-34558][SQL][FOLLOWUP] Do not fail Spark startup with a broken FileSystem
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #32622:
URL: https://github.com/apache/spark/pull/32622#issuecomment-846187058
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/138807/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #32622: [SPARK-34558][SQL][FOLLOWUP] Do not fail Spark startup with a broken FileSystem
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #32622:
URL: https://github.com/apache/spark/pull/32622#issuecomment-846154915
**[Test build #138807 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/138807/testReport)** for PR 32622 at commit [`82924f7`](https://github.com/apache/spark/commit/82924f73a02a7b30043635df03f665151983fd89).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #32622: [SPARK-34558][SQL][FOLLOWUP] Do not fail Spark startup with a broken FileSystem
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #32622:
URL: https://github.com/apache/spark/pull/32622#issuecomment-846187058
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/138807/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] yaooqinn commented on a change in pull request #32622: [SPARK-34558][SQL][FOLLOWUP] Do not fail Spark startup with a broken FileSystem
Posted by GitBox <gi...@apache.org>.
yaooqinn commented on a change in pull request #32622:
URL: https://github.com/apache/spark/pull/32622#discussion_r637013382
##########
File path: sql/core/src/test/scala/org/apache/spark/sql/SparkSessionBuilderSuite.scala
##########
@@ -472,4 +472,13 @@ class SparkSessionBuilderSuite extends SparkFunSuite with BeforeAndAfterEach wit
expected)
}
}
+
+ test("SPARK-33944: Create a working SparkSession with a broken FileSystem") {
+ val session = SparkSession.builder()
+ .master("local")
+ .config(WAREHOUSE_PATH.key, "my_dir")
+ .config("fs.file.impl", "non.existing.class")
+ .getOrCreate()
+ session.sql("SELECT 1").collect()
Review comment:
```suggestion
val msg = "Cannot qualify the warehouse path, leaving it unqualified"
val logAppender = new LogAppender(msg)
withLogAppender(logAppender) {
val session =
SparkSession.builder()
.master("local")
.config(WAREHOUSE_PATH.key, "my_dir")
.config("fs.file.impl", "non.existing.class")
.getOrCreate()
session.sql("SELECT 1").collect()
}
assert(logAppender.loggingEvents.exists(_.getRenderedMessage.contains(msg)))
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] yaooqinn edited a comment on pull request #32622: [SPARK-34558][SQL][FOLLOWUP] Do not fail Spark startup with a broken FileSystem
Posted by GitBox <gi...@apache.org>.
yaooqinn edited a comment on pull request #32622:
URL: https://github.com/apache/spark/pull/32622#issuecomment-846032354
For the thrift server, could this change lead to creating an unhealthy server for end-users?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] yaooqinn commented on pull request #32622: [SPARK-34558][SQL][FOLLOWUP] Do not fail Spark startup with a broken FileSystem
Posted by GitBox <gi...@apache.org>.
yaooqinn commented on pull request #32622:
URL: https://github.com/apache/spark/pull/32622#issuecomment-846046979
LGTM
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #32622: [SPARK-34558][SQL][FOLLOWUP] Do not fail Spark startup with a broken FileSystem
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #32622:
URL: https://github.com/apache/spark/pull/32622#issuecomment-845988561
**[Test build #138807 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/138807/testReport)** for PR 32622 at commit [`82924f7`](https://github.com/apache/spark/commit/82924f73a02a7b30043635df03f665151983fd89).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #32622: [SPARK-34558][SQL][FOLLOWUP] Do not fail Spark startup with a broken FileSystem
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #32622:
URL: https://github.com/apache/spark/pull/32622#issuecomment-846021386
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/43329/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on a change in pull request #32622: [SPARK-34558][SQL][FOLLOWUP] Do not fail Spark startup with a broken FileSystem
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on a change in pull request #32622:
URL: https://github.com/apache/spark/pull/32622#discussion_r637035192
##########
File path: sql/core/src/test/scala/org/apache/spark/sql/SparkSessionBuilderSuite.scala
##########
@@ -472,4 +472,19 @@ class SparkSessionBuilderSuite extends SparkFunSuite with BeforeAndAfterEach wit
expected)
}
}
+
+ test("SPARK-33944: Create a working SparkSession with a broken FileSystem") {
Review comment:
Sorry for missing this. Let me make a quick follow-up.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on a change in pull request #32622: [SPARK-34558][SQL][FOLLOWUP] Do not fail Spark startup with a broken FileSystem
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on a change in pull request #32622:
URL: https://github.com/apache/spark/pull/32622#discussion_r637034430
##########
File path: sql/core/src/test/scala/org/apache/spark/sql/SparkSessionBuilderSuite.scala
##########
@@ -472,4 +472,19 @@ class SparkSessionBuilderSuite extends SparkFunSuite with BeforeAndAfterEach wit
expected)
}
}
+
+ test("SPARK-33944: Create a working SparkSession with a broken FileSystem") {
Review comment:
SPARK-34558?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan commented on pull request #32622: [SPARK-34558][SQL][FOLLOWUP] Do not fail Spark startup with a broken FileSystem
Posted by GitBox <gi...@apache.org>.
cloud-fan commented on pull request #32622:
URL: https://github.com/apache/spark/pull/32622#issuecomment-846042814
> For the thrift server, could this change lead to creating an unhealthy server for end-users?
At least it's the same as before, not worse.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #32622: [SPARK-34558][SQL][FOLLOWUP] Do not fail Spark startup with a broken FileSystem
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #32622:
URL: https://github.com/apache/spark/pull/32622#issuecomment-846018730
Kubernetes integration test unable to build dist.
exiting with code: 1
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/43329/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org