[GitHub] [incubator-pinot] mcvsubbu commented on a change in pull request #4454: Add table and segment name header for segment push

[GitBox <gi...@apache.org>]

mcvsubbu commented on a change in pull request #4454: Add table and segment name header for segment push
URL: https://github.com/apache/incubator-pinot/pull/4454#discussion_r306425729
 
 

 ##########
 File path: pinot-common/src/main/java/org/apache/pinot/common/utils/FileUploadDownloadClient.java
 ##########
 @@ -521,6 +523,28 @@ public SimpleHttpResponse uploadSegment(URI uri, String segmentName, InputStream
     return uploadSegment(uri, segmentName, inputStream, null, null, DEFAULT_SOCKET_TIMEOUT_MS);
   }
 
+  /**
 
 Review comment:
   Not sure why we are having new APIs. Why not just add the headers in the existing APIs?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org