You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@subversion.apache.org by Bert Huijben <be...@qqmail.nl> on 2013/01/11 12:23:14 UTC
RE: svn commit: r1431757 - /subversion/trunk/subversion/libsvn_repos/repos.c
> -----Original Message-----
> From: brane@apache.org [mailto:brane@apache.org]
> Sent: vrijdag 11 januari 2013 01:15
> To: commits@subversion.apache.org
> Subject: svn commit: r1431757 -
> /subversion/trunk/subversion/libsvn_repos/repos.c
>
> Author: brane
> Date: Fri Jan 11 00:15:16 2013
> New Revision: 1431757
>
> URL: http://svn.apache.org/viewvc?rev=1431757&view=rev
> Log:
> Helper code for reproducing issue #4274 (serf client hangs when server
> crashes).
>
> * subversion/libsvn_repos/repos.c (get_repos): When SVN_DEBUG is
> defined,
> if the file $REPO_PATH/conf/debug-abort exists, crash after opening
> the repository and filesystem.
Can you use another define for this?
This hack/check is active on all the buildbots, while its scope is serf issue specific, but now active in most developer environments.
Most likely this problem is just relevant for you and one or two other developers, and only when they work on the specific problem.
Bert
RE: svn commit: r1431757 - /subversion/trunk/subversion/libsvn_repos/repos.c
Posted by Bert Huijben <be...@qqmail.nl>.
> -----Original Message-----
> From: Branko Čibej [mailto:brane@wandisco.com]
> Sent: vrijdag 11 januari 2013 13:08
> To: dev@subversion.apache.org
> Subject: Re: svn commit: r1431757 -
> /subversion/trunk/subversion/libsvn_repos/repos.c
>
> On 11.01.2013 12:23, Bert Huijben wrote:
> >
> >> -----Original Message-----
> >> From: brane@apache.org [mailto:brane@apache.org]
> >> Sent: vrijdag 11 januari 2013 01:15
> >> To: commits@subversion.apache.org
> >> Subject: svn commit: r1431757 -
> >> /subversion/trunk/subversion/libsvn_repos/repos.c
> >>
> >> Author: brane
> >> Date: Fri Jan 11 00:15:16 2013
> >> New Revision: 1431757
> >>
> >> URL: http://svn.apache.org/viewvc?rev=1431757&view=rev
> >> Log:
> >> Helper code for reproducing issue #4274 (serf client hangs when server
> >> crashes).
> >>
> >> * subversion/libsvn_repos/repos.c (get_repos): When SVN_DEBUG is
> >> defined,
> >> if the file $REPO_PATH/conf/debug-abort exists, crash after opening
> >> the repository and filesystem.
> > Can you use another define for this?
> >
> > This hack/check is active on all the buildbots, while its scope is serf issue
> specific, but now active in most developer environments.
> >
> > Most likely this problem is just relevant for you and one or two other
> developers, and only when they work on the specific problem.
>
> How often are you going to create a file called debug-abort in the
> repository config dir?
How often are you going to stat that file that doesn’t exist?
I don't think it will ever exist for me.
Just adding this kind of tests everywhere doesn't scale and will just slowdown developers (And others that enable maintainer mode)
That is why we use separate defines for these specific scenarios (and if they are long lived, such as for FSFS development, they are documented in notes/knobs)
Bert
Re: svn commit: r1431757 - /subversion/trunk/subversion/libsvn_repos/repos.c
Posted by Branko Čibej <br...@wandisco.com>.
On 11.01.2013 12:23, Bert Huijben wrote:
>
>> -----Original Message-----
>> From: brane@apache.org [mailto:brane@apache.org]
>> Sent: vrijdag 11 januari 2013 01:15
>> To: commits@subversion.apache.org
>> Subject: svn commit: r1431757 -
>> /subversion/trunk/subversion/libsvn_repos/repos.c
>>
>> Author: brane
>> Date: Fri Jan 11 00:15:16 2013
>> New Revision: 1431757
>>
>> URL: http://svn.apache.org/viewvc?rev=1431757&view=rev
>> Log:
>> Helper code for reproducing issue #4274 (serf client hangs when server
>> crashes).
>>
>> * subversion/libsvn_repos/repos.c (get_repos): When SVN_DEBUG is
>> defined,
>> if the file $REPO_PATH/conf/debug-abort exists, crash after opening
>> the repository and filesystem.
> Can you use another define for this?
>
> This hack/check is active on all the buildbots, while its scope is serf issue specific, but now active in most developer environments.
>
> Most likely this problem is just relevant for you and one or two other developers, and only when they work on the specific problem.
How often are you going to create a file called debug-abort in the
repository config dir?
-- Brane
--
Branko Čibej
Director of Subversion | WANdisco | www.wandisco.com