You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@weex.apache.org by doumafang <gi...@git.apache.org> on 2017/11/13 08:47:09 UTC
[GitHub] incubator-weex pull request #856: [WEEX-109][iOS] add scrollstart and scroll...
GitHub user doumafang opened a pull request:
https://github.com/apache/incubator-weex/pull/856
[WEEX-109][iOS] add scrollstart and scrollend event's interface for scroller
[WEEX-109] [iOS] add scrollstart and scrollend event's interface for scroller
Just use fireEvent to make UIScrollViewDelegate exposed to the front users.
Now can use 'scrollstart' and 'scrollend' to get scroller's status.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/doumafang/incubator-weex ios-feature-layoutanimation-0.16dev
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-weex/pull/856.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #856
----
commit 2891c7e23332e0a1e3b93db7a16e8459e7e8d65c
Author: doumafang <do...@gmail.com>
Date: 2017-11-13T08:41:46Z
* [ios] scroller list recycler supported scrollstart and scrollend event
----
---
[GitHub] incubator-weex pull request #856: [WEEX-109][iOS] add scrollstart and scroll...
Posted by cxfeng1 <gi...@git.apache.org>.
Github user cxfeng1 commented on a diff in the pull request:
https://github.com/apache/incubator-weex/pull/856#discussion_r150474976
--- Diff: ios/sdk/WeexSDK/Sources/Component/WXScrollerComponent.m ---
@@ -569,6 +573,8 @@ - (void)scrollViewDidEndScrollingAnimation:(UIScrollView *)scrollView
}
[scrollView setContentInset:inset];
+ [self fireEvent:@"scrollend" params:nil domChanges:nil];
+
--- End diff --
unnecessary line
---
[GitHub] incubator-weex pull request #856: [WEEX-109][iOS] add scrollstart and scroll...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/incubator-weex/pull/856
---
[GitHub] incubator-weex issue #856: [WEEX-109][iOS] add scrollstart and scrollend eve...
Posted by weex-bot <gi...@git.apache.org>.
Github user weex-bot commented on the issue:
https://github.com/apache/incubator-weex/pull/856
<!--
0 failure:
0 warning:
2 messages
-->
<table>
<thead>
<tr>
<th width="50"></th>
<th width="100%" data-danger-table="true">Messages</th>
</tr>
</thead>
<tbody><tr>
<td>:book:</td>
<td>has no jsfm file changed.</td>
</tr>
<tr>
<td>:book:</td>
<td>jsfm test finished.</td>
</tr>
</tbody>
</table>
<p align="right">
Generated by :no_entry_sign: <a href="http://github.com/danger/danger-js/">dangerJS</a>
</p>
---
[GitHub] incubator-weex issue #856: [WEEX-109][iOS] add scrollstart and scrollend eve...
Posted by cxfeng1 <gi...@git.apache.org>.
Github user cxfeng1 commented on the issue:
https://github.com/apache/incubator-weex/pull/856
@doumafang Can you provide some examples of the pull request and please make sure the behavior on iOS is consistent with Android.
---