You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Bankim Bhavsar (Code Review)" <ge...@cloudera.org> on 2020/02/20 20:22:09 UTC
[kudu-CR] [test] Fix flaky BloomFilterPredicate test
Bankim Bhavsar has uploaded this change for review. ( http://gerrit.cloudera.org:8080/15257
Change subject: [test] Fix flaky BloomFilterPredicate test
......................................................................
[test] Fix flaky BloomFilterPredicate test
min, max values need to be computed across all the values
inserted in the column and not across subset of inclusive values.
Tests:
- Reproduced failure with dist-test.
- With the fix, ran the BloomFilterPredicate test 1000 times on dist_test,
no failures reported.
Change-Id: I9a8fe34b59178f513224166d7ece7374ea2d1272
---
M src/kudu/client/predicate-test.cc
1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/57/15257/1
--
To view, visit http://gerrit.cloudera.org:8080/15257
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I9a8fe34b59178f513224166d7ece7374ea2d1272
Gerrit-Change-Number: 15257
Gerrit-PatchSet: 1
Gerrit-Owner: Bankim Bhavsar <ba...@cloudera.com>
[kudu-CR] [test] Fix flaky BloomFilterPredicate test
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/15257 )
Change subject: [test] Fix flaky BloomFilterPredicate test
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/15257
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I9a8fe34b59178f513224166d7ece7374ea2d1272
Gerrit-Change-Number: 15257
Gerrit-PatchSet: 1
Gerrit-Owner: Bankim Bhavsar <ba...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Bankim Bhavsar <ba...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Thu, 20 Feb 2020 20:58:01 +0000
Gerrit-HasComments: No
[kudu-CR] [test] Fix flaky BloomFilterPredicate test
Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/15257 )
Change subject: [test] Fix flaky BloomFilterPredicate test
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/15257
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I9a8fe34b59178f513224166d7ece7374ea2d1272
Gerrit-Change-Number: 15257
Gerrit-PatchSet: 1
Gerrit-Owner: Bankim Bhavsar <ba...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Bankim Bhavsar <ba...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Thu, 20 Feb 2020 21:32:58 +0000
Gerrit-HasComments: No
[kudu-CR] [test] Fix flaky BloomFilterPredicate test
Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Grant Henke has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/15257 )
Change subject: [test] Fix flaky BloomFilterPredicate test
......................................................................
[test] Fix flaky BloomFilterPredicate test
min, max values need to be computed across all the values
inserted in the column and not across subset of inclusive values.
Tests:
- Reproduced failure with dist-test.
- With the fix, ran the BloomFilterPredicate test 1000 times on dist_test,
no failures reported.
Change-Id: I9a8fe34b59178f513224166d7ece7374ea2d1272
Reviewed-on: http://gerrit.cloudera.org:8080/15257
Reviewed-by: Adar Dembo <ad...@cloudera.com>
Tested-by: Kudu Jenkins
Reviewed-by: Grant Henke <gr...@apache.org>
---
M src/kudu/client/predicate-test.cc
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Adar Dembo: Looks good to me, approved
Kudu Jenkins: Verified
Grant Henke: Looks good to me, approved
--
To view, visit http://gerrit.cloudera.org:8080/15257
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I9a8fe34b59178f513224166d7ece7374ea2d1272
Gerrit-Change-Number: 15257
Gerrit-PatchSet: 2
Gerrit-Owner: Bankim Bhavsar <ba...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Bankim Bhavsar <ba...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)