You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by onursatici <gi...@git.apache.org> on 2017/11/15 23:17:25 UTC
[GitHub] spark pull request #19761: [SPARK-22479][SQL][BRANCH-2.2] Exclude credential...
GitHub user onursatici opened a pull request:
https://github.com/apache/spark/pull/19761
[SPARK-22479][SQL][BRANCH-2.2] Exclude credentials from SaveintoDataSourceCommand.simpleString
## What changes were proposed in this pull request?
Do not include jdbc properties which may contain credentials in logging a logical plan with `SaveIntoDataSourceCommand` in it.
## How was this patch tested?
new tests
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/onursatici/spark os/redact-jdbc-creds-2.2
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/spark/pull/19761.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #19761
----
commit fd36d2f54939a27406f4077a04a6f7dad328f840
Author: osatici <os...@palantir.com>
Date: 2017-11-09T14:06:05Z
do not log properties on SaveintoDataSourceCommand.simpleString
----
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #19761: [SPARK-22479][SQL][BRANCH-2.2] Exclude credentials from ...
Posted by jiangxb1987 <gi...@git.apache.org>.
Github user jiangxb1987 commented on the issue:
https://github.com/apache/spark/pull/19761
ping @onursatici
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #19761: [SPARK-22479][SQL][BRANCH-2.2] Exclude credentials from ...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19761
Can one of the admins verify this patch?
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #19761: [WIP][SPARK-22479][SQL][BRANCH-2.2] Exclude credentials ...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19761
**[Test build #83924 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/83924/testReport)** for PR 19761 at commit [`adbf94e`](https://github.com/apache/spark/commit/adbf94eef67780b2ef547eff250ea3e11e4deda2).
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #19761: [SPARK-22479][SQL][BRANCH-2.2] Exclude credentials from ...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19761
Merged build finished. Test FAILed.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request #19761: [SPARK-22479][SQL][BRANCH-2.2] Exclude credential...
Posted by gatorsmile <gi...@git.apache.org>.
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/19761#discussion_r151294056
--- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/SaveIntoDataSourceCommand.scala ---
@@ -49,4 +51,9 @@ case class SaveIntoDataSourceCommand(
Seq.empty[Row]
}
+
+ override def simpleString: String = {
+ val redacted = Utils.redact(SparkEnv.get.conf, options.toSeq).toMap
+ s"SaveIntoDataSourceCommand ${dataSource}, ${redacted}, ${mode}"
--- End diff --
`dataSource ` does not exist in 2.2
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #19761: [WIP][SPARK-22479][SQL][BRANCH-2.2] Exclude credentials ...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19761
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/83923/
Test FAILed.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #19761: [WIP][SPARK-22479][SQL][BRANCH-2.2] Exclude credentials ...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19761
**[Test build #83923 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/83923/testReport)** for PR 19761 at commit [`ba4d590`](https://github.com/apache/spark/commit/ba4d590b192cfe220bfed0e1bd690af746cf2ad1).
* This patch **fails to build**.
* This patch merges cleanly.
* This patch adds no public classes.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request #19761: [SPARK-22479][SQL][BRANCH-2.2] Exclude credential...
Posted by onursatici <gi...@git.apache.org>.
Github user onursatici closed the pull request at:
https://github.com/apache/spark/pull/19761
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #19761: [WIP][SPARK-22479][SQL][BRANCH-2.2] Exclude credentials ...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19761
Merged build finished. Test PASSed.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #19761: [SPARK-22479][SQL][BRANCH-2.2] Exclude credentials from ...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19761
**[Test build #83923 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/83923/testReport)** for PR 19761 at commit [`ba4d590`](https://github.com/apache/spark/commit/ba4d590b192cfe220bfed0e1bd690af746cf2ad1).
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #19761: [SPARK-22479][SQL][BRANCH-2.2] Exclude credentials from ...
Posted by gatorsmile <gi...@git.apache.org>.
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/19761
@onursatici Could you please close it?
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #19761: [SPARK-22479][SQL][BRANCH-2.2] Exclude credentials from ...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19761
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/83922/
Test FAILed.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #19761: [SPARK-22479][SQL][BRANCH-2.2] Exclude credentials from ...
Posted by cloud-fan <gi...@git.apache.org>.
Github user cloud-fan commented on the issue:
https://github.com/apache/spark/pull/19761
thanks, merging to 2.2!
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #19761: [WIP][SPARK-22479][SQL][BRANCH-2.2] Exclude credentials ...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19761
**[Test build #83924 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/83924/testReport)** for PR 19761 at commit [`adbf94e`](https://github.com/apache/spark/commit/adbf94eef67780b2ef547eff250ea3e11e4deda2).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #19761: [SPARK-22479][SQL][BRANCH-2.2] Exclude credentials from ...
Posted by onursatici <gi...@git.apache.org>.
Github user onursatici commented on the issue:
https://github.com/apache/spark/pull/19761
follow-up of https://github.com/apache/spark/pull/19708
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #19761: [WIP][SPARK-22479][SQL][BRANCH-2.2] Exclude credentials ...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19761
Merged build finished. Test FAILed.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #19761: [WIP][SPARK-22479][SQL][BRANCH-2.2] Exclude credentials ...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19761
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/83924/
Test PASSed.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #19761: [SPARK-22479][SQL][BRANCH-2.2] Exclude credentials from ...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19761
**[Test build #83922 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/83922/testReport)** for PR 19761 at commit [`fd36d2f`](https://github.com/apache/spark/commit/fd36d2f54939a27406f4077a04a6f7dad328f840).
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #19761: [SPARK-22479][SQL][BRANCH-2.2] Exclude credentials from ...
Posted by gatorsmile <gi...@git.apache.org>.
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/19761
ok to test
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #19761: [SPARK-22479][SQL][BRANCH-2.2] Exclude credentials from ...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19761
**[Test build #83922 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/83922/testReport)** for PR 19761 at commit [`fd36d2f`](https://github.com/apache/spark/commit/fd36d2f54939a27406f4077a04a6f7dad328f840).
* This patch **fails to build**.
* This patch merges cleanly.
* This patch adds no public classes.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org