You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@lucene.apache.org by "ASF subversion and git services (JIRA)" <ji...@apache.org> on 2015/06/03 21:23:38 UTC

[jira] [Commented] (SOLR-7599) Remove cruft from SolrCloud tests

    [ https://issues.apache.org/jira/browse/SOLR-7599?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14571522#comment-14571522 ] 

ASF subversion and git services commented on SOLR-7599:
-------------------------------------------------------

Commit 1683417 from shalin@apache.org in branch 'dev/trunk'
[ https://svn.apache.org/r1683417 ]

SOLR-7599: Remove invokeCollectionAPI method from base test class and use solrj classes throughout

> Remove cruft from SolrCloud tests
> ---------------------------------
>
>                 Key: SOLR-7599
>                 URL: https://issues.apache.org/jira/browse/SOLR-7599
>             Project: Solr
>          Issue Type: Task
>          Components: SolrCloud, Tests
>            Reporter: Shalin Shekhar Mangar
>            Assignee: Shalin Shekhar Mangar
>             Fix For: Trunk, 5.3
>
>         Attachments: SOLR-7599.patch
>
>
> I see many tests which blindly have distribSetUp and distribTearDown methods setting a variety of options and system properties that aren't required anymore. 
> This is because some base test classes have been refactored such that these options are redundant. In other cases, people have copied the structure of tests blindly instead of understanding what each parameter does.
> Let's try to remove the unnecessary config params from such tests.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org