You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@rocketmq.apache.org by "yyqdbngt (via GitHub)" <gi...@apache.org> on 2026/09/04 02:14:36 UTC
[PR] fix(i18n): localize topic quick fill, detail tab and import rows [rocketmq-dashboard]
yyqdbngt opened a new pull request, #3074:
URL: https://github.com/apache/rocketmq-dashboard/pull/3074
### Summary
Localize the remaining uncovered copy on the Topic page (`pages/instance/topic.tsx`) — 14 literals mined across 146 candidates that no earlier topic i18n branch had removed:
- **Send-message quick fill**: the six sample-body category buttons (`订单事件` … `监控指标`) are now semantic slugs resolved through `topic.quickFill.*` keys (generated sample payloads themselves stay as demo data).
- **Detail modal**: the `基本信息` section heading.
- **Create modal validation**: the name pattern and max-length rule messages (`topic.namePattern`, parameterized `topic.nameMaxLength`).
- **Import preview rows**: the CSV parse fallback and per-row outcome copy (`topic.csvParseFailed`, `topic.importRowFailed`, `topic.importRowCreated`).
### Why
These were the last un-keyed strings on the page (the remaining zh literals on the page are backend enum values such as `广播消费` that mirror server data). English users now see localized quick-fill choices, section headings, form rules and import outcomes.
### Testing
- `tsc --noEmit` passes (exit 0).
- `eslint` clean on changed files (0 errors).
- Vitest: full `TopicPage` suite passes (16/16).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(i18n): localize topic quick fill, detail tab and import rows [rocketmq-dashboard]
Posted by "lizhimins (via GitHub)" <gi...@apache.org>.
lizhimins closed pull request #3074: fix(i18n): localize topic quick fill, detail tab and import rows
URL: https://github.com/apache/rocketmq-dashboard/pull/3074
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org