You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@storm.apache.org by "Jungtaek Lim (JIRA)" <ji...@apache.org> on 2016/10/12 09:51:21 UTC
[jira] [Resolved] (STORM-2125) Use Calcite's implementation of Rex
Compiler
[ https://issues.apache.org/jira/browse/STORM-2125?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jungtaek Lim resolved STORM-2125.
---------------------------------
Resolution: Fixed
Fix Version/s: 1.1.0
2.0.0
Merged into master and 1.x-branch.
While porting back, I found I used JDK 8 API in test code. I just commented out since it doesn't affect actual behavior, and the test case is covered by master branch.
https://github.com/apache/storm/commit/7f492f69e92eaafba2b64bf4f0d13273191c9cd8
I'm not sure it can be resolved without Joda-time in JDK7, so if we want to sync the code, removing that test is easiest way.
Please let me know if you think this should be reverted to fix that issue. Thanks all.
> Use Calcite's implementation of Rex Compiler
> --------------------------------------------
>
> Key: STORM-2125
> URL: https://issues.apache.org/jira/browse/STORM-2125
> Project: Apache Storm
> Issue Type: Improvement
> Components: storm-sql
> Reporter: Jungtaek Lim
> Assignee: Jungtaek Lim
> Fix For: 2.0.0, 1.1.0
>
> Time Spent: 6.5h
> Remaining Estimate: 0h
>
> Looking into Calcite more, I found that Calcite has its own interpreter, and also has Rex Compiler.
> In other words, we don't need to handle Rex operation by ourselves. We can just borrow this and it will provide all of what Calcite supports Rex handling.
> After pulling this, we just need to make tests to check that Storm SQL provides all the functionalities on SQL reference on Calcite page: http://calcite.apache.org/docs/reference.html.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)