You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@cordova.apache.org by GitBox <gi...@apache.org> on 2020/10/27 05:21:29 UTC
[GitHub] [cordova-plugin-camera] erisu opened a new pull request #684: fix(android): Ssupports sdk-30 new package visibility
erisu opened a new pull request #684:
URL: https://github.com/apache/cordova-plugin-camera/pull/684
### Platforms affected
android
### Motivation and Context
Fixes issues that were introduced with the new Android 11 (SDK 30) package visibility restrictions.
### Description
Explicitly sets the package visibility for:
* android.media.action.IMAGE_CAPTURE
* android.intent.action.GET_CONTENT
I believe this:
closes #673
Which is used by the camera and gallery.
### Testing
* Tested on an Android 11 SDK 30 AVD
### Checklist
- [ ] I've run the tests to see all new and existing tests pass
- [ ] I added automated test coverage as appropriate for this change
- [ ] Commit is prefixed with `(platform)` if this change only applies to one platform (e.g. `(android)`)
- [x] If this Pull Request resolves an issue, I linked to the issue in the text above (and used the correct [keyword to close issues using keywords](https://help.github.com/articles/closing-issues-using-keywords/))
- [ ] I've updated the documentation if necessary
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org
[GitHub] [cordova-plugin-camera] erisu merged pull request #684: fix(android): supports sdk-30 package visibility
Posted by GitBox <gi...@apache.org>.
erisu merged pull request #684:
URL: https://github.com/apache/cordova-plugin-camera/pull/684
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org
[GitHub] [cordova-plugin-camera] erisu edited a comment on pull request #684: fix(android): supports new package visibility (sdk-29)
Posted by GitBox <gi...@apache.org>.
erisu edited a comment on pull request #684:
URL: https://github.com/apache/cordova-plugin-camera/pull/684#issuecomment-717143234
@jcesarmobile these technically should also fixe the same issues in SDK 29 without using the legacy flag, so it could be seen as providing proper support for 29 as well.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org
[GitHub] [cordova-plugin-camera] jcesarmobile commented on pull request #684: fix(android): supports sdk-30 package visibility
Posted by GitBox <gi...@apache.org>.
jcesarmobile commented on pull request #684:
URL: https://github.com/apache/cordova-plugin-camera/pull/684#issuecomment-791565456
I think `android.intent.action.PICK` should also be added since it's used when `allowEdit` is set to true
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org
[GitHub] [cordova-plugin-camera] noahcooper edited a comment on pull request #684: fix(android): supports sdk-30 package visibility
Posted by GitBox <gi...@apache.org>.
noahcooper edited a comment on pull request #684:
URL: https://github.com/apache/cordova-plugin-camera/pull/684#issuecomment-826000809
Any chance of merging this any time soon? Android 11 will be required for all apps starting in November.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org
[GitHub] [cordova-plugin-camera] mickytroxxy commented on pull request #684: fix(android): supports sdk-30 package visibility
Posted by GitBox <gi...@apache.org>.
mickytroxxy commented on pull request #684:
URL: https://github.com/apache/cordova-plugin-camera/pull/684#issuecomment-722374642
Hello guys, may you please help with this error, when taking photos with cordova app Attempt to invoke virtual method 'boolean java.io.File.mkdirs()' on a null object reference. Please
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org
[GitHub] [cordova-plugin-camera] erisu removed a comment on pull request #684: fix(android): supports new package visibility (sdk-29)
Posted by GitBox <gi...@apache.org>.
erisu removed a comment on pull request #684:
URL: https://github.com/apache/cordova-plugin-camera/pull/684#issuecomment-717143234
@jcesarmobile these technically should also fix the same issues in SDK 29 without using the legacy flag, so it could be seen as providing a proper solution for 29 as well.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org
[GitHub] [cordova-plugin-camera] Perh0rd commented on pull request #684: fix(android): supports sdk-30 package visibility
Posted by GitBox <gi...@apache.org>.
Perh0rd commented on pull request #684:
URL: https://github.com/apache/cordova-plugin-camera/pull/684#issuecomment-736685496
Hi . Is there any ETA for a release of this? It's not possible to use camera while target SDK 30, but Google now refuse apps (updates or new ones), that do not the SDK 30, so basically camera plugin do not work anymore on Android 11 to publish a public app.
Thank you!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org
[GitHub] [cordova-plugin-camera] jcesarmobile edited a comment on pull request #684: fix(android): supports sdk-30 package visibility
Posted by GitBox <gi...@apache.org>.
jcesarmobile edited a comment on pull request #684:
URL: https://github.com/apache/cordova-plugin-camera/pull/684#issuecomment-891741498
We also launch CROP intent here https://github.com/apache/cordova-plugin-camera/blob/master/src/android/CameraLauncher.java#L417, so should probably be added too
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org
[GitHub] [cordova-plugin-camera] Perh0rd commented on pull request #684: fix(android): supports sdk-30 package visibility
Posted by GitBox <gi...@apache.org>.
Perh0rd commented on pull request #684:
URL: https://github.com/apache/cordova-plugin-camera/pull/684#issuecomment-736741761
> > Hi . Is there any ETA for a release of this? It's not possible to use camera while target SDK 30, but Google now refuse apps (updates or new ones), that do not the SDK 30, so basically camera plugin do not work anymore on Android 11 to publish a public app.
> > Thank you!
>
> We cannot provide ETAs. Additionally that statement is inaccurate. Google currently requires all apps (new or updates) to be targeting API 29.
>
> They will begin forcing API 30 on new apps starting August 2021 and on existing apps receiving updates starting November 2021. See their timeline [here](https://developer.android.com/distribute/best-practices/develop/target-sdk)
My bad, sorry you are right it's only in August. Safe then. Thank you for your answer
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org
[GitHub] [cordova-plugin-camera] noahcooper commented on pull request #684: fix(android): supports sdk-30 package visibility
Posted by GitBox <gi...@apache.org>.
noahcooper commented on pull request #684:
URL: https://github.com/apache/cordova-plugin-camera/pull/684#issuecomment-826000809
Any chance of merging this any time soon? Android 30 will be required for all apps starting in November.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org
[GitHub] [cordova-plugin-camera] erisu commented on pull request #684: fix(android): supports sdk-30 new package visibility
Posted by GitBox <gi...@apache.org>.
erisu commented on pull request #684:
URL: https://github.com/apache/cordova-plugin-camera/pull/684#issuecomment-717143234
@jcesarmobile these technically fixes issues in SDK 29 as well without using the legacy flag, so it could be seen as providing proper support for 29 as well.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org
[GitHub] [cordova-plugin-camera] breautek commented on pull request #684: fix(android): supports sdk-30 package visibility
Posted by GitBox <gi...@apache.org>.
breautek commented on pull request #684:
URL: https://github.com/apache/cordova-plugin-camera/pull/684#issuecomment-717213160
Personally as long as the changes aren't introducing breaking changes, I don't see why we shouldn't accept PRs that addresses issues in upcoming API levels. It help us stay ahead of the curve.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org
[GitHub] [cordova-plugin-camera] jcesarmobile commented on pull request #684: fix(android): Ssupports sdk-30 new package visibility
Posted by GitBox <gi...@apache.org>.
jcesarmobile commented on pull request #684:
URL: https://github.com/apache/cordova-plugin-camera/pull/684#issuecomment-717086504
I don’t think we should add this yet because cordova-android doesn’t support SDK 30.
Users targeting SDK 30 can add that to their manifest themselves with edit-config and config-file tags as they work in config.xml too.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org
[GitHub] [cordova-plugin-camera] erisu edited a comment on pull request #684: fix(android): supports new package visibility (sdk-29)
Posted by GitBox <gi...@apache.org>.
erisu edited a comment on pull request #684:
URL: https://github.com/apache/cordova-plugin-camera/pull/684#issuecomment-717143234
@jcesarmobile these technically should also fix the same issues in SDK 29 without using the legacy flag, so it could be seen as providing a proper solution for 29 as well.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org
[GitHub] [cordova-plugin-camera] jcesarmobile commented on pull request #684: fix(android): supports sdk-30 package visibility
Posted by GitBox <gi...@apache.org>.
jcesarmobile commented on pull request #684:
URL: https://github.com/apache/cordova-plugin-camera/pull/684#issuecomment-891741498
We also launch CROP intent here `https://github.com/apache/cordova-plugin-camera/blob/master/src/android/CameraLauncher.java#L417`, so should probably be added too
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org
[GitHub] [cordova-plugin-camera] erisu commented on pull request #684: fix(android): supports sdk-30 new package visibility
Posted by GitBox <gi...@apache.org>.
erisu commented on pull request #684:
URL: https://github.com/apache/cordova-plugin-camera/pull/684#issuecomment-717140576
Squash merge will amend it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org
[GitHub] [cordova-plugin-camera] Houdhey commented on pull request #684: fix(android): supports sdk-30 package visibility
Posted by GitBox <gi...@apache.org>.
Houdhey commented on pull request #684:
URL: https://github.com/apache/cordova-plugin-camera/pull/684#issuecomment-768149547
Could you please explain how you implement this? (with code)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org
[GitHub] [cordova-plugin-camera] erisu edited a comment on pull request #684: fix(android): supports sdk-30 package visibility
Posted by GitBox <gi...@apache.org>.
erisu edited a comment on pull request #684:
URL: https://github.com/apache/cordova-plugin-camera/pull/684#issuecomment-717140576
~~Squash merge will amend it~~ Went ahead and rebased.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org
[GitHub] [cordova-plugin-camera] breautek commented on pull request #684: fix(android): supports sdk-30 package visibility
Posted by GitBox <gi...@apache.org>.
breautek commented on pull request #684:
URL: https://github.com/apache/cordova-plugin-camera/pull/684#issuecomment-736691774
> Hi . Is there any ETA for a release of this? It's not possible to use camera while target SDK 30, but Google now refuse apps (updates or new ones), that do not the SDK 30, so basically camera plugin do not work anymore on Android 11 to publish a public app.
>
> Thank you!
We cannot provide ETAs. Additionally that statement is inaccurate. Google currently requires all apps (new or updates) to be targeting API 29.
They will begin forcing API 30 on new apps starting August 2021 and on existing apps receiving updates starting November 2021. See their timeline [here](https://developer.android.com/distribute/best-practices/develop/target-sdk)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org