You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by "jcoeltjen (via GitHub)" <gi...@apache.org> on 2023/01/28 22:51:33 UTC
[GitHub] [apisix-docker] jcoeltjen opened a new pull request, #414: chore: cleanup example documentation
jcoeltjen opened a new pull request, #414:
URL: https://github.com/apache/apisix-docker/pull/414
- Removed profile flag from docker-compose up/dow command as the compose files do not contain any profile
specific configuration (anymore).
- Changed port for all admin API calls from 9080 to 9180 because the admin api is not exposed on 9080.
- Replaced ip addresses inside service upstream config with compose service names. CIDR for the bridge created by docker-compose might differ between machines, hostnames are fixed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-docker] jcoeltjen commented on a diff in pull request #414: chore: cleanup example documentation
Posted by "jcoeltjen (via GitHub)" <gi...@apache.org>.
jcoeltjen commented on code in PR #414:
URL: https://github.com/apache/apisix-docker/pull/414#discussion_r1089894158
##########
docs/en/latest/example.md:
##########
@@ -99,9 +99,7 @@ curl https://web1.lvh.me:9443/ -v --cacert ./mkcert/rootCA.pem
### Clean
```
-docker-compose -p docker-apisix down
+docker-compose down
sudo rm -rf etcd_data/member
-
-rm -rf apisix_log/*.log
Review Comment:
Fair point. I will update both PRs accordingly.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-docker] soulbird merged pull request #414: chore: cleanup example documentation
Posted by "soulbird (via GitHub)" <gi...@apache.org>.
soulbird merged PR #414:
URL: https://github.com/apache/apisix-docker/pull/414
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-docker] tokers commented on a diff in pull request #414: chore: cleanup example documentation
Posted by "tokers (via GitHub)" <gi...@apache.org>.
tokers commented on code in PR #414:
URL: https://github.com/apache/apisix-docker/pull/414#discussion_r1089848522
##########
docs/en/latest/example.md:
##########
@@ -99,9 +99,7 @@ curl https://web1.lvh.me:9443/ -v --cacert ./mkcert/rootCA.pem
### Clean
```
-docker-compose -p docker-apisix down
+docker-compose down
sudo rm -rf etcd_data/member
-
-rm -rf apisix_log/*.log
Review Comment:
This change is not related to the title. I saw another PR you submitted, it can be change in your another PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-docker] jcoeltjen commented on a diff in pull request #414: chore: cleanup example documentation
Posted by "jcoeltjen (via GitHub)" <gi...@apache.org>.
jcoeltjen commented on code in PR #414:
URL: https://github.com/apache/apisix-docker/pull/414#discussion_r1089895602
##########
docs/en/latest/example.md:
##########
@@ -99,9 +99,7 @@ curl https://web1.lvh.me:9443/ -v --cacert ./mkcert/rootCA.pem
### Clean
```
-docker-compose -p docker-apisix down
+docker-compose down
sudo rm -rf etcd_data/member
-
-rm -rf apisix_log/*.log
Review Comment:
I amended the commit, thus the force push.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org