You are viewing a plain text version of this content. The canonical link for it is here.
Posted to pr@cassandra.apache.org by GitBox <gi...@apache.org> on 2020/03/16 13:55:13 UTC
[GitHub] [cassandra] ekaterinadimitrova2 opened a new pull request #474: Add JAVA_HOME and java.rmi.server.randomID to the system_properties t…
ekaterinadimitrova2 opened a new pull request #474: Add JAVA_HOME and java.rmi.server.randomID to the system_properties t…
URL: https://github.com/apache/cassandra/pull/474
…able (CASSANDRA-15643)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org
[GitHub] [cassandra] michaelsembwever commented on a change in pull request #474: Add JAVA_HOME and java.rmi.server.randomID to the system_properties t…
Posted by GitBox <gi...@apache.org>.
michaelsembwever commented on a change in pull request #474: Add JAVA_HOME and java.rmi.server.randomID to the system_properties t…
URL: https://github.com/apache/cassandra/pull/474#discussion_r393139175
##########
File path: src/java/org/apache/cassandra/db/virtual/SystemPropertiesTable.java
##########
@@ -35,6 +35,7 @@
private static final Set<String> CASSANDRA_RELEVANT_PROPERTIES = Sets.newHashSet(
// base jvm properties
"java.home",
+ "JAVA_HOME",
Review comment:
instead of adding `JAVA_HOME` here, what do you think about adding it to a second set `CASSANDRA_RELEVANT_ENVS` ? (even if it's a singleton, maybe it's cleaner code, and allows adding more env more easily…?)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org
[GitHub] [cassandra] michaelsembwever commented on a change in pull request #474: Add JAVA_HOME and java.rmi.server.randomID to the system_properties t…
Posted by GitBox <gi...@apache.org>.
michaelsembwever commented on a change in pull request #474: Add JAVA_HOME and java.rmi.server.randomID to the system_properties t…
URL: https://github.com/apache/cassandra/pull/474#discussion_r393135481
##########
File path: CHANGES.txt
##########
@@ -1,4 +1,5 @@
4.0-alpha4
+ * Add JAVA_HOME and java.rmi.server.randomID to system_properties table (CASSANDRA-15643)
Review comment:
this doesn't need to be a separate line. instead just update line 4 to read
```
* Added Virtual Table exposing Cassandra relevant system properties (CASSANDRA-15616,CASSANDRA-15643)
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org
[GitHub] [cassandra] michaelsembwever commented on a change in pull request #474: Add JAVA_HOME and java.rmi.server.randomID to the system_properties t…
Posted by GitBox <gi...@apache.org>.
michaelsembwever commented on a change in pull request #474: Add JAVA_HOME and java.rmi.server.randomID to the system_properties t…
URL: https://github.com/apache/cassandra/pull/474#discussion_r393212273
##########
File path: src/java/org/apache/cassandra/db/virtual/SystemPropertiesTable.java
##########
@@ -80,6 +85,12 @@ public DataSet data()
{
SimpleDataSet result = new SimpleDataSet(metadata());
+ System.getenv().keySet()
+ .stream()
+ .filter(SystemPropertiesTable::isCassandraRelevant)
+ .forEach(name -> addRow(result, name, System.getenv(name)));
+ //addRow(result, "JAVA_HOME", System.getenv("JAVA_HOME"));
Review comment:
nit: the commented line can be removed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org
[GitHub] [cassandra] ekaterinadimitrova2 commented on a change in pull request #474: Add JAVA_HOME and java.rmi.server.randomID to the system_properties t…
Posted by GitBox <gi...@apache.org>.
ekaterinadimitrova2 commented on a change in pull request #474: Add JAVA_HOME and java.rmi.server.randomID to the system_properties t…
URL: https://github.com/apache/cassandra/pull/474#discussion_r393206063
##########
File path: src/java/org/apache/cassandra/db/virtual/SystemPropertiesTable.java
##########
@@ -35,6 +35,7 @@
private static final Set<String> CASSANDRA_RELEVANT_PROPERTIES = Sets.newHashSet(
// base jvm properties
"java.home",
+ "JAVA_HOME",
Review comment:
Agreed, done, thanks
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org