You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Tomasz Janiszewski <ja...@gmail.com> on 2017/01/29 14:52:10 UTC
Re: Review Request 51053: Update leveldb to 1.19.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51053/
-----------------------------------------------------------
(Updated Jan. 29, 2017, 2:52 p.m.)
Review request for mesos, Bing Li, Benjamin Mahler, Zhiwei Chen, haosdent huang, and Vinod Kone.
Changes
-------
Rebase
Bugs: MESOS-970
https://issues.apache.org/jira/browse/MESOS-970
Repository: mesos
Description (updated)
-------
Leveldb in modern version is required to support s390x and arm64.
It's also required to replace default byte-wise comparator
with varint comparator in \`src/log/leveldb.cpp\`.
Diffs (updated)
-----
3rdparty/Makefile.am bbf9cfe7125b193003115f440a00c91e2e68f404
3rdparty/cmake/Mesos3rdpartyConfigure.cmake eeb27860f6f95d297ccfe273ed76de5355b50ff8
3rdparty/cmake/Versions.cmake ad23f3895b49d623709c0939d63a0529654788ef
3rdparty/leveldb-1.19.patch PRE-CREATION
3rdparty/leveldb-1.19.tar.gz PRE-CREATION
3rdparty/leveldb-1.4.patch b899f0141d633b1ffb2321e573395256fc893b16
3rdparty/leveldb-1.4.tar.gz 2ddbc0c2e02054406ff0ea43ddc10d14979de8d8
3rdparty/versions.am 26f839cd8d454de91f10c2e616e78decc30eff1b
LICENSE 7946d1d46174ff30459a33b3d0b44ab62672af0a
src/Makefile.am 6c9be54fe0ce3faaa26e2f090773d1b77bb6e430
src/python/native_common/ext_modules.py.in 2d4a45efa224b32f80ace4542a00062c5ccb06d5
Diff: https://reviews.apache.org/r/51053/diff/
Testing
-------
make -j 8 distcheck
benchamrks: https://gist.github.com/janisz/c0cd248a796cd7f10254ddbc02e91872
Thanks,
Tomasz Janiszewski
Re: Review Request 51053: Update leveldb to 1.19.
Posted by haosdent huang <ha...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51053/#review166061
-----------------------------------------------------------
Ship it!
Need to change `support/mesos-tidy/entrypoint.sh` as well, I would change this when commit it.
```
diff --git a/support/mesos-tidy/entrypoint.sh b/support/mesos-tidy/entrypoint.sh
index 4f03a6011..5dbaa6086 100755
--- a/support/mesos-tidy/entrypoint.sh
+++ b/support/mesos-tidy/entrypoint.sh
@@ -45,7 +45,7 @@ cmake --build 3rdparty --target http_parser-2.6.2 -- -j $(nproc)
cmake --build 3rdparty --target libev-4.22 -- -j $(nproc) || true
cmake --build 3rdparty --target libevent-2.1.5-beta -- -j $(nproc) || true
-cmake --build 3rdparty --target leveldb-1.4 -- -j $(nproc)
+cmake --build 3rdparty --target leveldb-1.19 -- -j $(nproc)
```
- haosdent huang
On Feb. 20, 2017, 4:41 a.m., Tomasz Janiszewski wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/51053/
> -----------------------------------------------------------
>
> (Updated Feb. 20, 2017, 4:41 a.m.)
>
>
> Review request for mesos, Bing Li, Benjamin Mahler, Zhiwei Chen, haosdent huang, and Vinod Kone.
>
>
> Bugs: MESOS-970
> https://issues.apache.org/jira/browse/MESOS-970
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Leveldb in modern version is required to support s390x and arm64.
> It's also required to replace default byte-wise comparator
> with varint comparator in \`src/log/leveldb.cpp\`.
>
>
> Diffs
> -----
>
> 3rdparty/Makefile.am bbf9cfe7125b193003115f440a00c91e2e68f404
> 3rdparty/cmake/Mesos3rdpartyConfigure.cmake eeb27860f6f95d297ccfe273ed76de5355b50ff8
> 3rdparty/cmake/Versions.cmake ad23f3895b49d623709c0939d63a0529654788ef
> 3rdparty/leveldb-1.19.patch PRE-CREATION
> 3rdparty/leveldb-1.19.tar.gz PRE-CREATION
> 3rdparty/leveldb-1.4.patch b899f0141d633b1ffb2321e573395256fc893b16
> 3rdparty/leveldb-1.4.tar.gz 2ddbc0c2e02054406ff0ea43ddc10d14979de8d8
> 3rdparty/versions.am 26f839cd8d454de91f10c2e616e78decc30eff1b
> LICENSE 7946d1d46174ff30459a33b3d0b44ab62672af0a
> src/Makefile.am 6c9be54fe0ce3faaa26e2f090773d1b77bb6e430
> src/python/native_common/ext_modules.py.in 2d4a45efa224b32f80ace4542a00062c5ccb06d5
>
> Diff: https://reviews.apache.org/r/51053/diff/
>
>
> Testing
> -------
>
> make -j 8 distcheck
>
> Test document: https://docs.google.com/document/d/1fv2OMvH6hVm6waacOejSrTJwUuDQeXlqqPDZjBmbcKU/edit?usp=sharing
>
>
> Thanks,
>
> Tomasz Janiszewski
>
>
Re: Review Request 51053: Update leveldb to 1.19.
Posted by Tomasz Janiszewski <ja...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51053/
-----------------------------------------------------------
(Updated Feb. 20, 2017, 4:41 a.m.)
Review request for mesos, Bing Li, Benjamin Mahler, Zhiwei Chen, haosdent huang, and Vinod Kone.
Bugs: MESOS-970
https://issues.apache.org/jira/browse/MESOS-970
Repository: mesos
Description
-------
Leveldb in modern version is required to support s390x and arm64.
It's also required to replace default byte-wise comparator
with varint comparator in \`src/log/leveldb.cpp\`.
Diffs
-----
3rdparty/Makefile.am bbf9cfe7125b193003115f440a00c91e2e68f404
3rdparty/cmake/Mesos3rdpartyConfigure.cmake eeb27860f6f95d297ccfe273ed76de5355b50ff8
3rdparty/cmake/Versions.cmake ad23f3895b49d623709c0939d63a0529654788ef
3rdparty/leveldb-1.19.patch PRE-CREATION
3rdparty/leveldb-1.19.tar.gz PRE-CREATION
3rdparty/leveldb-1.4.patch b899f0141d633b1ffb2321e573395256fc893b16
3rdparty/leveldb-1.4.tar.gz 2ddbc0c2e02054406ff0ea43ddc10d14979de8d8
3rdparty/versions.am 26f839cd8d454de91f10c2e616e78decc30eff1b
LICENSE 7946d1d46174ff30459a33b3d0b44ab62672af0a
src/Makefile.am 6c9be54fe0ce3faaa26e2f090773d1b77bb6e430
src/python/native_common/ext_modules.py.in 2d4a45efa224b32f80ace4542a00062c5ccb06d5
Diff: https://reviews.apache.org/r/51053/diff/
Testing (updated)
-------
make -j 8 distcheck
Test document: https://docs.google.com/document/d/1fv2OMvH6hVm6waacOejSrTJwUuDQeXlqqPDZjBmbcKU/edit?usp=sharing
Thanks,
Tomasz Janiszewski
Re: Review Request 51053: Update leveldb to 1.19.
Posted by Tomasz Janiszewski <ja...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51053/
-----------------------------------------------------------
(Updated Feb. 15, 2017, 8:44 p.m.)
Review request for mesos, Bing Li, Benjamin Mahler, Zhiwei Chen, haosdent huang, and Vinod Kone.
Bugs: MESOS-970
https://issues.apache.org/jira/browse/MESOS-970
Repository: mesos
Description
-------
Leveldb in modern version is required to support s390x and arm64.
It's also required to replace default byte-wise comparator
with varint comparator in \`src/log/leveldb.cpp\`.
Diffs (updated)
-----
3rdparty/Makefile.am bbf9cfe7125b193003115f440a00c91e2e68f404
3rdparty/cmake/Mesos3rdpartyConfigure.cmake eeb27860f6f95d297ccfe273ed76de5355b50ff8
3rdparty/cmake/Versions.cmake ad23f3895b49d623709c0939d63a0529654788ef
3rdparty/leveldb-1.19.patch PRE-CREATION
3rdparty/leveldb-1.19.tar.gz PRE-CREATION
3rdparty/leveldb-1.4.patch b899f0141d633b1ffb2321e573395256fc893b16
3rdparty/leveldb-1.4.tar.gz 2ddbc0c2e02054406ff0ea43ddc10d14979de8d8
3rdparty/versions.am 26f839cd8d454de91f10c2e616e78decc30eff1b
LICENSE 7946d1d46174ff30459a33b3d0b44ab62672af0a
src/Makefile.am 6c9be54fe0ce3faaa26e2f090773d1b77bb6e430
src/python/native_common/ext_modules.py.in 2d4a45efa224b32f80ace4542a00062c5ccb06d5
Diff: https://reviews.apache.org/r/51053/diff/
Testing
-------
make -j 8 distcheck
benchamrks: https://gist.github.com/janisz/c0cd248a796cd7f10254ddbc02e91872
Thanks,
Tomasz Janiszewski