You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@geode.apache.org by GitBox <gi...@apache.org> on 2021/02/17 17:35:50 UTC

[GitHub] [geode-native] gaussianrecurrence commented on a change in pull request #715: GEODE-8793: Fix PdxTypeRegistry cleanup

gaussianrecurrence commented on a change in pull request #715:
URL: https://github.com/apache/geode-native/pull/715#discussion_r577808766



##########
File path: cppcache/src/ClientMetadataService.cpp
##########
@@ -59,9 +59,11 @@ void ClientMetadataService::start() {
 }
 
 void ClientMetadataService::stop() {
-  m_run = false;
-  m_regionQueueCondition.notify_one();
-  m_thread.join();
+  if (m_run) {

Review comment:
       This would rather be a compare&exchange, but yes, you've got a point




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org