[GitHub] [phoenix-connectors] stoty commented on a change in pull request #60: PHOENIX-6524 Hive Connector returns emtpy AND expression when all chi…

[GitBox <gi...@apache.org>]

stoty commented on a change in pull request #60:
URL: https://github.com/apache/phoenix-connectors/pull/60#discussion_r683573457



##########
File path: phoenix-hive-base/src/it/java/org/apache/phoenix/hive/HivePhoenixStoreIT.java
##########
@@ -362,4 +362,60 @@ public void testTimestampPredicate() throws Exception {
         createFile(sb.toString(), fullPath);
         runTest(testName, fullPath);
     }
+
+    @Test
+    //This SHOULD test for PHOENIX-6524 when all children of an AND expression are pushed down,
+    //and we were returning an AND expression without children to Hive.
+    //However, this bug didn't trigger in this test, only on an actual deployment

Review comment:
       Yes, it fails with MR, but not with TEZ.
   I have no clue why. 
   
   In any case, I've updated the comment, and stripped the superfloud columns now.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@phoenix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org