You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Benjamin Bannier <be...@mesosphere.io> on 2016/04/01 10:07:20 UTC
Re: Review Request 45533: Explicitly typed quota role sorter in Mesos
allocator.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45533/
-----------------------------------------------------------
(Updated April 1, 2016, 10:07 a.m.)
Review request for mesos, Alexander Rukletsov and Ben Mahler.
Changes
-------
Removed accidential trailing whitespace (no functional changes)
Bugs: MESOS-4760
https://issues.apache.org/jira/browse/MESOS-4760
Repository: mesos
Description
-------
Explicitly typed quota role sorter in Mesos allocator.
Diffs (updated)
-----
src/master/allocator/mesos/hierarchical.hpp e979fdf60da1409d1c2d08f0e9f03cef067506dd
src/master/allocator/mesos/hierarchical.cpp 5a5df5f8287a1f85b8b2a6aac7e6e13d0650a132
Diff: https://reviews.apache.org/r/45533/diff/
Testing
-------
make check (OS X, clang trunk, not optimized)
Thanks,
Benjamin Bannier
Re: Review Request 45533: Explicitly typed quota role sorter in Mesos
allocator.
Posted by Ben Mahler <be...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45533/#review127705
-----------------------------------------------------------
Fix it, then Ship it!
src/master/allocator/mesos/hierarchical.hpp (line 479)
<https://reviews.apache.org/r/45533/#comment191095>
whoops?
- Ben Mahler
On April 1, 2016, 8:07 a.m., Benjamin Bannier wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45533/
> -----------------------------------------------------------
>
> (Updated April 1, 2016, 8:07 a.m.)
>
>
> Review request for mesos, Alexander Rukletsov and Ben Mahler.
>
>
> Bugs: MESOS-4760
> https://issues.apache.org/jira/browse/MESOS-4760
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Explicitly typed quota role sorter in Mesos allocator.
>
>
> Diffs
> -----
>
> src/master/allocator/mesos/hierarchical.hpp e979fdf60da1409d1c2d08f0e9f03cef067506dd
> src/master/allocator/mesos/hierarchical.cpp 5a5df5f8287a1f85b8b2a6aac7e6e13d0650a132
>
> Diff: https://reviews.apache.org/r/45533/diff/
>
>
> Testing
> -------
>
> make check (OS X, clang trunk, not optimized)
>
>
> Thanks,
>
> Benjamin Bannier
>
>
Re: Review Request 45533: Explicitly typed quota role sorter in Mesos
allocator.
Posted by Guangya Liu <gy...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45533/#review126704
-----------------------------------------------------------
It seems you are linking to a wrong bug, should be MESOS-5073 ?
- Guangya Liu
On 四月 1, 2016, 8:07 a.m., Benjamin Bannier wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45533/
> -----------------------------------------------------------
>
> (Updated 四月 1, 2016, 8:07 a.m.)
>
>
> Review request for mesos, Alexander Rukletsov and Ben Mahler.
>
>
> Bugs: MESOS-4760
> https://issues.apache.org/jira/browse/MESOS-4760
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Explicitly typed quota role sorter in Mesos allocator.
>
>
> Diffs
> -----
>
> src/master/allocator/mesos/hierarchical.hpp e979fdf60da1409d1c2d08f0e9f03cef067506dd
> src/master/allocator/mesos/hierarchical.cpp 5a5df5f8287a1f85b8b2a6aac7e6e13d0650a132
>
> Diff: https://reviews.apache.org/r/45533/diff/
>
>
> Testing
> -------
>
> make check (OS X, clang trunk, not optimized)
>
>
> Thanks,
>
> Benjamin Bannier
>
>
Re: Review Request 45533: Explicitly typed quota role sorter in Mesos
allocator.
Posted by Guangya Liu <gy...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45533/#review126703
-----------------------------------------------------------
src/master/allocator/mesos/hierarchical.hpp (line 479)
<https://reviews.apache.org/r/45533/#comment189724>
two space is good enough
- Guangya Liu
On 四月 1, 2016, 8:07 a.m., Benjamin Bannier wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45533/
> -----------------------------------------------------------
>
> (Updated 四月 1, 2016, 8:07 a.m.)
>
>
> Review request for mesos, Alexander Rukletsov and Ben Mahler.
>
>
> Bugs: MESOS-4760
> https://issues.apache.org/jira/browse/MESOS-4760
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Explicitly typed quota role sorter in Mesos allocator.
>
>
> Diffs
> -----
>
> src/master/allocator/mesos/hierarchical.hpp e979fdf60da1409d1c2d08f0e9f03cef067506dd
> src/master/allocator/mesos/hierarchical.cpp 5a5df5f8287a1f85b8b2a6aac7e6e13d0650a132
>
> Diff: https://reviews.apache.org/r/45533/diff/
>
>
> Testing
> -------
>
> make check (OS X, clang trunk, not optimized)
>
>
> Thanks,
>
> Benjamin Bannier
>
>