You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@hbase.apache.org by "kgeisz (via GitHub)" <gi...@apache.org> on 2026/01/14 19:56:05 UTC
[PR] HBASE-29815: Fix issue where backup integration tests are not running in IntelliJ [hbase]
kgeisz opened a new pull request, #7625:
URL: https://github.com/apache/hbase/pull/7625
https://issues.apache.org/jira/browse/HBASE-29815
This pull request fixes an issue where `IntegrationTestContinuousBackupRestore` and `IntegrationTestBackupRestore` are able to run in the command line using `bin/hbase`, but they will not run in IntelliJ for in the command line using Maven. This issue is fixed by ensuring essential class variables for the integration tests are initialized, regardless of how the test is executed.
Note: `IntegrationTestContinuousBackupRestore` and `IntegrationTestBackupRestore` will still fail on this branch for different reasons due to [HBASE-29825](https://issues.apache.org/jira/browse/HBASE-29825) and [HBASE-29826](https://issues.apache.org/jira/browse/HBASE-29826).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] HBASE-29815: Fix issue where backup integration tests are not running in IntelliJ [hbase]
Posted by "taklwu (via GitHub)" <gi...@apache.org>.
taklwu commented on code in PR #7625:
URL: https://github.com/apache/hbase/pull/7625#discussion_r2692193929
##########
hbase-it/src/test/java/org/apache/hadoop/hbase/backup/IntegrationTestBackupRestoreBase.java:
##########
@@ -715,6 +715,47 @@ protected Set<String> getColumnFamilies() {
return null;
}
+ /**
+ * This method is useful for ensuring important test parameters are initialized when running
+ * integration tests in IntelliJ or in the command line with Maven. Tests executed in the command
+ * line via the bin/hbase command have their parameters set in
+ * {@link IntegrationTestBase#processOptions}
+ */
+ protected void initializeTestParameters() {
+ util = new IntegrationTestingUtility();
+ conf = util.getConfiguration();
+
+ if (regionsCountPerServer == -1) {
+ regionsCountPerServer = conf.getInt(REGION_COUNT_KEY, DEFAULT_REGION_COUNT);
+ }
+ LOG.info("regionsCountPerServer is set to {}", regionsCountPerServer);
+
+ if (regionServerCount == -1) {
+ regionServerCount = conf.getInt(REGIONSERVER_COUNT_KEY, DEFAULT_REGIONSERVER_COUNT);
+ }
+ LOG.info("regionServerCount is set to {}", regionServerCount);
+
+ if (rowsInIteration == -1) {
+ rowsInIteration = conf.getInt(ROWS_PER_ITERATION_KEY, DEFAULT_ROWS_IN_ITERATION);
+ }
+ LOG.info("rowsInIteration is set to {}", rowsInIteration);
+
+ if (numIterations == -1) {
+ numIterations = conf.getInt(NUM_ITERATIONS_KEY, DEFAULT_NUM_ITERATIONS);
+ }
+ LOG.info("numIterations is set to {}", numIterations);
Review Comment:
LOG.info should be better to debug or even remove them.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] HBASE-29815: Fix issue where backup integration tests are not running in IntelliJ [hbase]
Posted by "kgeisz (via GitHub)" <gi...@apache.org>.
kgeisz commented on code in PR #7625:
URL: https://github.com/apache/hbase/pull/7625#discussion_r2695183110
##########
hbase-it/src/test/java/org/apache/hadoop/hbase/backup/IntegrationTestBackupRestoreBase.java:
##########
@@ -90,20 +91,19 @@ public abstract class IntegrationTestBackupRestoreBase extends IntegrationTestBa
protected static final int DEFAULT_NUM_ITERATIONS = 10;
protected static final int DEFAULT_ROWS_IN_ITERATION = 10000;
protected static final String SLEEP_TIME_KEY = "sleeptime";
- // short default interval because tests don't run very long.
+ // Short default interval because tests don't run very long.
protected static final long SLEEP_TIME_DEFAULT = 50000L;
protected static String DEFAULT_BACKUP_ROOT_DIR = "backupIT";
- protected static int rowsInIteration;
- protected static int regionsCountPerServer;
- protected static int regionServerCount;
+ // These test parameters can be configured using a Configuration object or via the command line.
+ protected static int rowsInIteration = -1;
+ protected static int regionsCountPerServer = -1;
+ protected static int regionServerCount = -1;
+ protected static int numIterations = -1;
+ protected static int numTables = -1;
+ protected static long sleepTime = -1;
Review Comment:
> 1. why does static require here?
It's not required. That's how the test originally had it. I will change it.
> 2. is there any other unit test or command line code calling initializeTestParameters ? if we don't set all these variables to -1 and also allow initializeTestParameters to assign value for unit test by using configuration object, does it work ?
Currently, only `IntegrationTestContinuousBackupRestore` and `IntegrationTestBackupRestore` use this `initializeTestParameters()` method. I will explain my reasons for why these variable are set to `-1`, and maybe there is a better way to do this.
Let's pretend I don't have the `if (variable == -1)` blocks in `initializeTestParameters()` and I am not initializing these variables to be `-1`, and instead I'm just doing `variable = conf.getInt(...)`. If we run the test in IntelliJ or using Maven, then the variables are set up fine. However, when we run in the command line with `bin/hbase` and use custom parameter values, then `IntegrationTestBackupRestoreBase.processOptions()`is executed first, which sets up the variables. After, any setting of variables, such as using `conf` object in `initializeTestParameters()` will overwrite what was supplied in the command line and configured in `processOptions()`.
Basically, my idea for initializing the variable to `-1` and using `if (variable == -1)` was a way of saying "this variable has not been set yet, so it's okay to set it here in `initializeTestParameters()`. However, if the variable is no longer `-1`, then that means it shouldn't be set again in `initializeTestParameters()`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] HBASE-29815: Fix issue where backup integration tests are not running in IntelliJ [hbase]
Posted by "kgeisz (via GitHub)" <gi...@apache.org>.
kgeisz commented on code in PR #7625:
URL: https://github.com/apache/hbase/pull/7625#discussion_r2695183110
##########
hbase-it/src/test/java/org/apache/hadoop/hbase/backup/IntegrationTestBackupRestoreBase.java:
##########
@@ -90,20 +91,19 @@ public abstract class IntegrationTestBackupRestoreBase extends IntegrationTestBa
protected static final int DEFAULT_NUM_ITERATIONS = 10;
protected static final int DEFAULT_ROWS_IN_ITERATION = 10000;
protected static final String SLEEP_TIME_KEY = "sleeptime";
- // short default interval because tests don't run very long.
+ // Short default interval because tests don't run very long.
protected static final long SLEEP_TIME_DEFAULT = 50000L;
protected static String DEFAULT_BACKUP_ROOT_DIR = "backupIT";
- protected static int rowsInIteration;
- protected static int regionsCountPerServer;
- protected static int regionServerCount;
+ // These test parameters can be configured using a Configuration object or via the command line.
+ protected static int rowsInIteration = -1;
+ protected static int regionsCountPerServer = -1;
+ protected static int regionServerCount = -1;
+ protected static int numIterations = -1;
+ protected static int numTables = -1;
+ protected static long sleepTime = -1;
Review Comment:
> 1. why does static require here?
It's not required. That's how the test originally had it. I will change it.
> 2. is there any other unit test or command line code calling initializeTestParameters ? if we don't set all these variables to -1 and also allow initializeTestParameters to assign value for unit test by using configuration object, does it work ?
Currently, only `IntegrationTestContinuousBackupRestore` and `IntegrationTestBackupRestore` use this `initializeTestParameters()` method. I will explain my reasons for why these variable are set to `-1`, and maybe there is a better way to do this.
Let's pretend I don't have the `if (variable == -1)` blocks in `initializeTestParameters()` and I am not initializing these variables to be `-1`, and instead I'm just doing `variable = conf.getInt(...)`. If we run the test in IntelliJ or using Maven, then the variable are set up fine. However, when we run in the command line with `bin/hbase` and use custom parameter values, then `IntegrationTestBackupRestoreBase.processOptions()`is executed first, which sets up the variables. After, any setting of variables, such as using `conf` object in `initializeTestParameters()` will overwrite what was supplied in the command line and configured in `processOptions()`.
Basically, my idea for initializing the variable to `-1` and using `if (variable == -1)` was a way of saying "this variable has not been set yet, so it's okay to set it here in `initializeTestParameters()`. However, if the variable is no longer `-1`, then that means it shouldn't be set again in `initializeTestParameters()`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] HBASE-29815: Fix issue where backup integration tests are not running in IntelliJ [hbase]
Posted by "Apache-HBase (via GitHub)" <gi...@apache.org>.
Apache-HBase commented on PR #7625:
URL: https://github.com/apache/hbase/pull/7625#issuecomment-3756782641
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|:----:|----------:|--------:|:--------:|:-------:|
| +0 :ok: | reexec | 0m 35s | | Docker mode activated. |
|||| _ Prechecks _ |
| +1 :green_heart: | dupname | 0m 0s | | No case conflicting files found. |
| +0 :ok: | codespell | 0m 0s | | codespell was not available. |
| +0 :ok: | detsecrets | 0m 0s | | detect-secrets was not available. |
| +1 :green_heart: | @author | 0m 0s | | The patch does not contain any @author tags. |
| +1 :green_heart: | hbaseanti | 0m 0s | | Patch does not have any anti-patterns. |
|||| _ HBASE-29164 Compile Tests _ |
| +1 :green_heart: | mvninstall | 3m 37s | | HBASE-29164 passed |
| +1 :green_heart: | compile | 0m 36s | | HBASE-29164 passed |
| +1 :green_heart: | checkstyle | 0m 12s | | HBASE-29164 passed |
| +1 :green_heart: | spotbugs | 0m 28s | | HBASE-29164 passed |
| +1 :green_heart: | spotless | 0m 53s | | branch has no errors when running spotless:check. |
|||| _ Patch Compile Tests _ |
| +1 :green_heart: | mvninstall | 3m 14s | | the patch passed |
| +1 :green_heart: | compile | 0m 34s | | the patch passed |
| +1 :green_heart: | javac | 0m 34s | | the patch passed |
| +1 :green_heart: | blanks | 0m 0s | | The patch has no blanks issues. |
| +1 :green_heart: | checkstyle | 0m 11s | | the patch passed |
| +1 :green_heart: | spotbugs | 0m 33s | | the patch passed |
| +1 :green_heart: | hadoopcheck | 12m 35s | | Patch does not cause any errors with Hadoop 3.3.6 3.4.0. |
| +1 :green_heart: | spotless | 0m 48s | | patch has no errors when running spotless:check. |
|||| _ Other Tests _ |
| +1 :green_heart: | asflicense | 0m 11s | | The patch does not generate ASF License warnings. |
| | | 32m 22s | | |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7625/2/artifact/yetus-general-check/output/Dockerfile |
| GITHUB PR | https://github.com/apache/hbase/pull/7625 |
| JIRA Issue | HBASE-29815 |
| Optional Tests | dupname asflicense javac spotbugs checkstyle codespell detsecrets compile hadoopcheck hbaseanti spotless |
| uname | Linux 041c545f4ab1 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev-support/hbase-personality.sh |
| git revision | HBASE-29164 / 6db6b9e78788d8cd8d184289730f9572fa8cd069 |
| Default Java | Eclipse Adoptium-17.0.11+9 |
| Max. process+thread count | 83 (vs. ulimit of 30000) |
| modules | C: hbase-it U: hbase-it |
| Console output | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7625/2/console |
| versions | git=2.34.1 maven=3.9.8 spotbugs=4.7.3 |
| Powered by | Apache Yetus 0.15.0 https://yetus.apache.org |
This message was automatically generated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] HBASE-29815: Fix issue where backup integration tests are not running in IntelliJ [hbase]
Posted by "Copilot (via GitHub)" <gi...@apache.org>.
Copilot commented on code in PR #7625:
URL: https://github.com/apache/hbase/pull/7625#discussion_r2692164030
##########
hbase-it/src/test/java/org/apache/hadoop/hbase/backup/IntegrationTestBackupRestoreBase.java:
##########
@@ -90,20 +91,19 @@ public abstract class IntegrationTestBackupRestoreBase extends IntegrationTestBa
protected static final int DEFAULT_NUM_ITERATIONS = 10;
protected static final int DEFAULT_ROWS_IN_ITERATION = 10000;
protected static final String SLEEP_TIME_KEY = "sleeptime";
- // short default interval because tests don't run very long.
+ // Short default interval because tests don't run very long.
protected static final long SLEEP_TIME_DEFAULT = 50000L;
protected static String DEFAULT_BACKUP_ROOT_DIR = "backupIT";
- protected static int rowsInIteration;
- protected static int regionsCountPerServer;
- protected static int regionServerCount;
+ // These test parameters can be configured using a Configuration object or via the command line.
+ protected static int rowsInIteration = -1;
+ protected static int regionsCountPerServer = -1;
+ protected static int regionServerCount = -1;
+ protected static int numIterations = -1;
+ protected static int numTables = -1;
+ protected static long sleepTime = -1;
Review Comment:
These static variables are shared across all test instances and may cause issues in concurrent test execution. If multiple tests run in parallel (e.g., in a test suite), modifications to these static variables in one test's setUp() method could affect other running tests. Consider making these instance variables instead, or document that these tests cannot be run in parallel.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] HBASE-29815: Fix issue where backup integration tests are not running in IntelliJ [hbase]
Posted by "taklwu (via GitHub)" <gi...@apache.org>.
taklwu commented on code in PR #7625:
URL: https://github.com/apache/hbase/pull/7625#discussion_r2692189001
##########
hbase-it/src/test/java/org/apache/hadoop/hbase/backup/IntegrationTestBackupRestoreBase.java:
##########
@@ -90,20 +91,19 @@ public abstract class IntegrationTestBackupRestoreBase extends IntegrationTestBa
protected static final int DEFAULT_NUM_ITERATIONS = 10;
protected static final int DEFAULT_ROWS_IN_ITERATION = 10000;
protected static final String SLEEP_TIME_KEY = "sleeptime";
- // short default interval because tests don't run very long.
+ // Short default interval because tests don't run very long.
protected static final long SLEEP_TIME_DEFAULT = 50000L;
protected static String DEFAULT_BACKUP_ROOT_DIR = "backupIT";
- protected static int rowsInIteration;
- protected static int regionsCountPerServer;
- protected static int regionServerCount;
+ // These test parameters can be configured using a Configuration object or via the command line.
+ protected static int rowsInIteration = -1;
+ protected static int regionsCountPerServer = -1;
+ protected static int regionServerCount = -1;
+ protected static int numIterations = -1;
+ protected static int numTables = -1;
+ protected static long sleepTime = -1;
Review Comment:
I have two questions
1. why does `static` require here?
2. is there any other unit test or command line code calling `initializeTestParameters` ? if we don't set all these variables to `-1` and also allow `initializeTestParameters` to assign value for unit test by using configuration object, does it work ?
```suggestion
protected int rowsInIteration = -1;
protected int regionsCountPerServer = -1;
protected int regionServerCount = -1;
protected int numIterations = -1;
protected int numTables = -1;
protected long sleepTime = -1;
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] HBASE-29815: Fix issue where backup integration tests are not running in IntelliJ [hbase]
Posted by "kgeisz (via GitHub)" <gi...@apache.org>.
kgeisz commented on code in PR #7625:
URL: https://github.com/apache/hbase/pull/7625#discussion_r2695774563
##########
hbase-it/src/test/java/org/apache/hadoop/hbase/backup/IntegrationTestBackupRestoreBase.java:
##########
@@ -715,6 +715,47 @@ protected Set<String> getColumnFamilies() {
return null;
}
+ /**
+ * This method is useful for ensuring important test parameters are initialized when running
+ * integration tests in IntelliJ or in the command line with Maven. Tests executed in the command
+ * line via the bin/hbase command have their parameters set in
+ * {@link IntegrationTestBase#processOptions}
+ */
+ protected void initializeTestParameters() {
+ util = new IntegrationTestingUtility();
+ conf = util.getConfiguration();
+
+ if (regionsCountPerServer == -1) {
+ regionsCountPerServer = conf.getInt(REGION_COUNT_KEY, DEFAULT_REGION_COUNT);
+ }
+ LOG.info("regionsCountPerServer is set to {}", regionsCountPerServer);
+
+ if (regionServerCount == -1) {
+ regionServerCount = conf.getInt(REGIONSERVER_COUNT_KEY, DEFAULT_REGIONSERVER_COUNT);
+ }
+ LOG.info("regionServerCount is set to {}", regionServerCount);
+
+ if (rowsInIteration == -1) {
+ rowsInIteration = conf.getInt(ROWS_PER_ITERATION_KEY, DEFAULT_ROWS_IN_ITERATION);
+ }
+ LOG.info("rowsInIteration is set to {}", rowsInIteration);
+
+ if (numIterations == -1) {
+ numIterations = conf.getInt(NUM_ITERATIONS_KEY, DEFAULT_NUM_ITERATIONS);
+ }
+ LOG.info("numIterations is set to {}", numIterations);
Review Comment:
I will make them `LOG.debug`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] HBASE-29815: Fix issue where backup integration tests are not running in IntelliJ [hbase]
Posted by "kgeisz (via GitHub)" <gi...@apache.org>.
kgeisz commented on code in PR #7625:
URL: https://github.com/apache/hbase/pull/7625#discussion_r2695201720
##########
hbase-it/src/test/java/org/apache/hadoop/hbase/backup/IntegrationTestBackupRestoreBase.java:
##########
@@ -90,20 +91,19 @@ public abstract class IntegrationTestBackupRestoreBase extends IntegrationTestBa
protected static final int DEFAULT_NUM_ITERATIONS = 10;
protected static final int DEFAULT_ROWS_IN_ITERATION = 10000;
protected static final String SLEEP_TIME_KEY = "sleeptime";
- // short default interval because tests don't run very long.
+ // Short default interval because tests don't run very long.
protected static final long SLEEP_TIME_DEFAULT = 50000L;
protected static String DEFAULT_BACKUP_ROOT_DIR = "backupIT";
- protected static int rowsInIteration;
- protected static int regionsCountPerServer;
- protected static int regionServerCount;
+ // These test parameters can be configured using a Configuration object or via the command line.
+ protected static int rowsInIteration = -1;
+ protected static int regionsCountPerServer = -1;
+ protected static int regionServerCount = -1;
+ protected static int numIterations = -1;
+ protected static int numTables = -1;
+ protected static long sleepTime = -1;
Review Comment:
Also, we could probably use `0` instead of `-1` since none of these variables should be `0` or less than `0` anyway. I could do some kind of variable validation check.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] HBASE-29815: Fix issue where backup integration tests are not running in IntelliJ [hbase]
Posted by "taklwu (via GitHub)" <gi...@apache.org>.
taklwu commented on code in PR #7625:
URL: https://github.com/apache/hbase/pull/7625#discussion_r2695698168
##########
hbase-it/src/test/java/org/apache/hadoop/hbase/backup/IntegrationTestBackupRestoreBase.java:
##########
@@ -90,20 +91,19 @@ public abstract class IntegrationTestBackupRestoreBase extends IntegrationTestBa
protected static final int DEFAULT_NUM_ITERATIONS = 10;
protected static final int DEFAULT_ROWS_IN_ITERATION = 10000;
protected static final String SLEEP_TIME_KEY = "sleeptime";
- // short default interval because tests don't run very long.
+ // Short default interval because tests don't run very long.
protected static final long SLEEP_TIME_DEFAULT = 50000L;
protected static String DEFAULT_BACKUP_ROOT_DIR = "backupIT";
- protected static int rowsInIteration;
- protected static int regionsCountPerServer;
- protected static int regionServerCount;
+ // These test parameters can be configured using a Configuration object or via the command line.
+ protected static int rowsInIteration = -1;
+ protected static int regionsCountPerServer = -1;
+ protected static int regionServerCount = -1;
+ protected static int numIterations = -1;
+ protected static int numTables = -1;
+ protected static long sleepTime = -1;
Review Comment:
k, I assumed you're trying to pass those parameters with maven but not using `java -cp` , with that case, please consider to do below
1. you're right on checking `0`, and thus you don't need to initialize with `-1`, please remove them
2. you can simplify the `if condition` lines into 1 line, e.g.
`regionsCountPerServer = conf.getInt(REGION_COUNT_KEY, regionsCountPerServer > 0 ? regionsCountPerServer : DEFAULT_REGION_COUNT);`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] HBASE-29815: Fix issue where backup integration tests are not running in IntelliJ [hbase]
Posted by "Apache-HBase (via GitHub)" <gi...@apache.org>.
Apache-HBase commented on PR #7625:
URL: https://github.com/apache/hbase/pull/7625#issuecomment-3751623647
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|:----:|----------:|--------:|:--------:|:-------:|
| +0 :ok: | reexec | 0m 17s | | Docker mode activated. |
|||| _ Prechecks _ |
| +1 :green_heart: | dupname | 0m 0s | | No case conflicting files found. |
| +0 :ok: | codespell | 0m 0s | | codespell was not available. |
| +0 :ok: | detsecrets | 0m 0s | | detect-secrets was not available. |
| +1 :green_heart: | @author | 0m 0s | | The patch does not contain any @author tags. |
| +1 :green_heart: | hbaseanti | 0m 0s | | Patch does not have any anti-patterns. |
|||| _ HBASE-29164 Compile Tests _ |
| +1 :green_heart: | mvninstall | 3m 41s | | HBASE-29164 passed |
| +1 :green_heart: | compile | 0m 45s | | HBASE-29164 passed |
| +1 :green_heart: | checkstyle | 0m 14s | | HBASE-29164 passed |
| +1 :green_heart: | spotbugs | 0m 39s | | HBASE-29164 passed |
| +1 :green_heart: | spotless | 1m 20s | | branch has no errors when running spotless:check. |
|||| _ Patch Compile Tests _ |
| +1 :green_heart: | mvninstall | 3m 51s | | the patch passed |
| +1 :green_heart: | compile | 0m 43s | | the patch passed |
| +1 :green_heart: | javac | 0m 43s | | the patch passed |
| +1 :green_heart: | blanks | 0m 0s | | The patch has no blanks issues. |
| +1 :green_heart: | checkstyle | 0m 13s | | the patch passed |
| +1 :green_heart: | spotbugs | 0m 45s | | the patch passed |
| +1 :green_heart: | hadoopcheck | 14m 5s | | Patch does not cause any errors with Hadoop 3.3.6 3.4.0. |
| +1 :green_heart: | spotless | 0m 50s | | patch has no errors when running spotless:check. |
|||| _ Other Tests _ |
| +1 :green_heart: | asflicense | 0m 11s | | The patch does not generate ASF License warnings. |
| | | 37m 31s | | |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | ClientAPI=1.52 ServerAPI=1.52 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7625/1/artifact/yetus-general-check/output/Dockerfile |
| GITHUB PR | https://github.com/apache/hbase/pull/7625 |
| JIRA Issue | HBASE-29815 |
| Optional Tests | dupname asflicense javac spotbugs checkstyle codespell detsecrets compile hadoopcheck hbaseanti spotless |
| uname | Linux 2a9108396f28 6.14.0-1018-aws #18~24.04.1-Ubuntu SMP Mon Nov 24 19:46:27 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev-support/hbase-personality.sh |
| git revision | HBASE-29164 / 9c64cae887b1f23ea374caae9a6016c7e3a672b1 |
| Default Java | Eclipse Adoptium-17.0.11+9 |
| Max. process+thread count | 82 (vs. ulimit of 30000) |
| modules | C: hbase-it U: hbase-it |
| Console output | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7625/1/console |
| versions | git=2.34.1 maven=3.9.8 spotbugs=4.7.3 |
| Powered by | Apache Yetus 0.15.0 https://yetus.apache.org |
This message was automatically generated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] HBASE-29815: Fix issue where backup integration tests are not running in IntelliJ [hbase]
Posted by "Apache-HBase (via GitHub)" <gi...@apache.org>.
Apache-HBase commented on PR #7625:
URL: https://github.com/apache/hbase/pull/7625#issuecomment-3751575530
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|:----:|----------:|--------:|:--------:|:-------:|
| +0 :ok: | reexec | 0m 34s | | Docker mode activated. |
| -0 :warning: | yetus | 0m 3s | | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --author-ignore-list --blanks-eol-ignore-file --blanks-tabs-ignore-file --quick-hadoopcheck |
|||| _ Prechecks _ |
|||| _ HBASE-29164 Compile Tests _ |
| +1 :green_heart: | mvninstall | 3m 33s | | HBASE-29164 passed |
| +1 :green_heart: | compile | 0m 23s | | HBASE-29164 passed |
| +1 :green_heart: | javadoc | 0m 15s | | HBASE-29164 passed |
| +1 :green_heart: | shadedjars | 6m 19s | | branch has no errors when building our shaded downstream artifacts. |
|||| _ Patch Compile Tests _ |
| +1 :green_heart: | mvninstall | 3m 11s | | the patch passed |
| +1 :green_heart: | compile | 0m 23s | | the patch passed |
| +1 :green_heart: | javac | 0m 23s | | the patch passed |
| +1 :green_heart: | javadoc | 0m 12s | | the patch passed |
| +1 :green_heart: | shadedjars | 6m 13s | | patch has no errors when building our shaded downstream artifacts. |
|||| _ Other Tests _ |
| +1 :green_heart: | unit | 0m 43s | | hbase-it in the patch passed. |
| | | 23m 6s | | |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7625/1/artifact/yetus-jdk17-hadoop3-check/output/Dockerfile |
| GITHUB PR | https://github.com/apache/hbase/pull/7625 |
| JIRA Issue | HBASE-29815 |
| Optional Tests | javac javadoc unit compile shadedjars |
| uname | Linux 905843253efc 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev-support/hbase-personality.sh |
| git revision | HBASE-29164 / 9c64cae887b1f23ea374caae9a6016c7e3a672b1 |
| Default Java | Eclipse Adoptium-17.0.11+9 |
| Test Results | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7625/1/testReport/ |
| Max. process+thread count | 628 (vs. ulimit of 30000) |
| modules | C: hbase-it U: hbase-it |
| Console output | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7625/1/console |
| versions | git=2.34.1 maven=3.9.8 |
| Powered by | Apache Yetus 0.15.0 https://yetus.apache.org |
This message was automatically generated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] HBASE-29815: Fix issue where backup integration tests are not running in IntelliJ [hbase]
Posted by "kgeisz (via GitHub)" <gi...@apache.org>.
kgeisz commented on code in PR #7625:
URL: https://github.com/apache/hbase/pull/7625#discussion_r2695778171
##########
hbase-it/src/test/java/org/apache/hadoop/hbase/backup/IntegrationTestBackupRestoreBase.java:
##########
@@ -90,20 +91,19 @@ public abstract class IntegrationTestBackupRestoreBase extends IntegrationTestBa
protected static final int DEFAULT_NUM_ITERATIONS = 10;
protected static final int DEFAULT_ROWS_IN_ITERATION = 10000;
protected static final String SLEEP_TIME_KEY = "sleeptime";
- // short default interval because tests don't run very long.
+ // Short default interval because tests don't run very long.
protected static final long SLEEP_TIME_DEFAULT = 50000L;
protected static String DEFAULT_BACKUP_ROOT_DIR = "backupIT";
- protected static int rowsInIteration;
- protected static int regionsCountPerServer;
- protected static int regionServerCount;
+ // These test parameters can be configured using a Configuration object or via the command line.
+ protected static int rowsInIteration = -1;
+ protected static int regionsCountPerServer = -1;
+ protected static int regionServerCount = -1;
+ protected static int numIterations = -1;
+ protected static int numTables = -1;
+ protected static long sleepTime = -1;
Review Comment:
Sounds good! I will do that along with making the variables no longer `static`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] HBASE-29815: Fix issue where backup integration tests are not running in IntelliJ [hbase]
Posted by "kgeisz (via GitHub)" <gi...@apache.org>.
kgeisz commented on code in PR #7625:
URL: https://github.com/apache/hbase/pull/7625#discussion_r2695778171
##########
hbase-it/src/test/java/org/apache/hadoop/hbase/backup/IntegrationTestBackupRestoreBase.java:
##########
@@ -90,20 +91,19 @@ public abstract class IntegrationTestBackupRestoreBase extends IntegrationTestBa
protected static final int DEFAULT_NUM_ITERATIONS = 10;
protected static final int DEFAULT_ROWS_IN_ITERATION = 10000;
protected static final String SLEEP_TIME_KEY = "sleeptime";
- // short default interval because tests don't run very long.
+ // Short default interval because tests don't run very long.
protected static final long SLEEP_TIME_DEFAULT = 50000L;
protected static String DEFAULT_BACKUP_ROOT_DIR = "backupIT";
- protected static int rowsInIteration;
- protected static int regionsCountPerServer;
- protected static int regionServerCount;
+ // These test parameters can be configured using a Configuration object or via the command line.
+ protected static int rowsInIteration = -1;
+ protected static int regionsCountPerServer = -1;
+ protected static int regionServerCount = -1;
+ protected static int numIterations = -1;
+ protected static int numTables = -1;
+ protected static long sleepTime = -1;
Review Comment:
Sounds good! I will do that
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] HBASE-29815: Fix issue where backup integration tests are not running in IntelliJ [hbase]
Posted by "Apache-HBase (via GitHub)" <gi...@apache.org>.
Apache-HBase commented on PR #7625:
URL: https://github.com/apache/hbase/pull/7625#issuecomment-3756749899
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|:----:|----------:|--------:|:--------:|:-------:|
| +0 :ok: | reexec | 0m 33s | | Docker mode activated. |
| -0 :warning: | yetus | 0m 3s | | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --author-ignore-list --blanks-eol-ignore-file --blanks-tabs-ignore-file --quick-hadoopcheck |
|||| _ Prechecks _ |
|||| _ HBASE-29164 Compile Tests _ |
| +1 :green_heart: | mvninstall | 3m 32s | | HBASE-29164 passed |
| +1 :green_heart: | compile | 0m 23s | | HBASE-29164 passed |
| +1 :green_heart: | javadoc | 0m 14s | | HBASE-29164 passed |
| +1 :green_heart: | shadedjars | 6m 15s | | branch has no errors when building our shaded downstream artifacts. |
|||| _ Patch Compile Tests _ |
| +1 :green_heart: | mvninstall | 3m 14s | | the patch passed |
| +1 :green_heart: | compile | 0m 23s | | the patch passed |
| +1 :green_heart: | javac | 0m 23s | | the patch passed |
| +1 :green_heart: | javadoc | 0m 12s | | the patch passed |
| +1 :green_heart: | shadedjars | 6m 18s | | patch has no errors when building our shaded downstream artifacts. |
|||| _ Other Tests _ |
| +1 :green_heart: | unit | 0m 43s | | hbase-it in the patch passed. |
| | | 22m 42s | | |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7625/2/artifact/yetus-jdk17-hadoop3-check/output/Dockerfile |
| GITHUB PR | https://github.com/apache/hbase/pull/7625 |
| JIRA Issue | HBASE-29815 |
| Optional Tests | javac javadoc unit compile shadedjars |
| uname | Linux 070b39d3ba94 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev-support/hbase-personality.sh |
| git revision | HBASE-29164 / 6db6b9e78788d8cd8d184289730f9572fa8cd069 |
| Default Java | Eclipse Adoptium-17.0.11+9 |
| Test Results | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7625/2/testReport/ |
| Max. process+thread count | 628 (vs. ulimit of 30000) |
| modules | C: hbase-it U: hbase-it |
| Console output | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7625/2/console |
| versions | git=2.34.1 maven=3.9.8 |
| Powered by | Apache Yetus 0.15.0 https://yetus.apache.org |
This message was automatically generated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] HBASE-29815: Fix issue where backup integration tests are not running in IntelliJ [hbase]
Posted by "taklwu (via GitHub)" <gi...@apache.org>.
taklwu merged PR #7625:
URL: https://github.com/apache/hbase/pull/7625
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org