[jira] Updated: (WICKET-379) Patch to make SubmitLink act more like a FormComponent wrt Disabled

["Chuck Deal (JIRA)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/WICKET-379?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Chuck Deal updated WICKET-379:
------------------------------

    Attachment: SubmitLink.java.patch

Here is a patch to do as I proposed

> Patch to make SubmitLink act more like a FormComponent wrt Disabled
> -------------------------------------------------------------------
>
>                 Key: WICKET-379
>                 URL: https://issues.apache.org/jira/browse/WICKET-379
>             Project: Wicket
>          Issue Type: Improvement
>          Components: wicket
>    Affects Versions: 1.3
>            Reporter: Chuck Deal
>            Priority: Minor
>         Attachments: SubmitLink.java.patch
>
>
> SubmitLink does not properly check for both isEnabled() and isEnableAllowed().  In the interest of  "standardizing", I recommend modeling this code after FormComponent itself (use of onDisabled)
> Also, the getTriggerJavascript() was private which made extending the object with custom functionality difficult.  I recommend marking it as protected and final to at least protect the method (I can't imagine why it would need to be restricted, but this should at least maintain the original author's intent).  However, final is not a requirement to remain as long as it is protected.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.