You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "thompson-tomo (via GitHub)" <gi...@apache.org> on 2025/06/20 02:27:37 UTC
[PR] use license expression #2891 [arrow-adbc]
thompson-tomo opened a new pull request, #3006:
URL: https://github.com/apache/arrow-adbc/pull/3006
Am aware of the comment however most if not all the third party notices are for the other languages.
Closes #2891
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] chore(csharp): use license expression [arrow-adbc]
Posted by "CurtHagenlocher (via GitHub)" <gi...@apache.org>.
CurtHagenlocher commented on PR #3006:
URL: https://github.com/apache/arrow-adbc/pull/3006#issuecomment-2993750662
> @CurtHagenlocher Could you check that `csharp/` doesn't bundle any third-party code?
It doesn't currently bundle any third-party code with one caveat: it does bundle some classes generated by the Thrift compiler. I suspect that this wouldn't be an issue, but I'm not qualified to give legal advice ;).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] chore(csharp): use license expression [arrow-adbc]
Posted by "kou (via GitHub)" <gi...@apache.org>.
kou commented on code in PR #3006:
URL: https://github.com/apache/arrow-adbc/pull/3006#discussion_r2159605538
##########
csharp/Directory.Build.props:
##########
@@ -53,7 +53,7 @@
<Authors>The Apache Software Foundation</Authors>
<PackageIcon>feather.png</PackageIcon>
<!-- We can't use PackageLicenseExpression; the license file also contains 3rd-party notices. -->
Review Comment:
If we use PackageLicenseExpression, we should remove this comment.
##########
csharp/Directory.Build.props:
##########
@@ -53,7 +53,7 @@
<Authors>The Apache Software Foundation</Authors>
<PackageIcon>feather.png</PackageIcon>
<!-- We can't use PackageLicenseExpression; the license file also contains 3rd-party notices. -->
- <PackageLicenseFile>LICENSE.txt</PackageLicenseFile>
+ <PackageLicenseExpression>APACHE-2.0</PackageLicenseExpression>
Review Comment:
We should use SPDX license identifier:
https://learn.microsoft.com/en-us/nuget/reference/msbuild-targets#pack-target-inputs
> PackageLicenseExpression An [SPDX license identifier](https://spdx.org/licenses/) or expression, for example, Apache-2.0. For more information, see [Packing a license expression or a license file](https://learn.microsoft.com/en-us/nuget/reference/msbuild-targets#packing-a-license-expression-or-a-license-file).
```suggestion
<PackageLicenseExpression>Apache-2.0</PackageLicenseExpression>
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] chore(csharp): use license expression [arrow-adbc]
Posted by "kou (via GitHub)" <gi...@apache.org>.
kou merged PR #3006:
URL: https://github.com/apache/arrow-adbc/pull/3006
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] chore(csharp): use license expression [arrow-adbc]
Posted by "kou (via GitHub)" <gi...@apache.org>.
kou commented on PR #3006:
URL: https://github.com/apache/arrow-adbc/pull/3006#issuecomment-2993377982
@CurtHagenlocher Could you check that `csharp/` doesn't bundle any third-party code?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org