You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2020/07/03 01:36:33 UTC

[GitHub] [flink] liuyongvs commented on pull request #12804: [FLINK-17425][blink plannger] Dynamic Source supportsLimit pushdown

liuyongvs commented on pull request #12804:
URL: https://github.com/apache/flink/pull/12804#issuecomment-653286188


   @wuchong ，yeap, i tag the wrong JIRA ID. Do I need commit a new PR?
   The LimitPushDown LegacyTableSource i don't find unit test, so i also don't add unit test.
   Because limit pushdown is diffirent fron filter/project/partition pushdown at TableScan. limitPushDown should be FlinkLogicalTableSourceScan while others are LogicalTableScan.  FlinkLogicalTableSourceScanConverter converts the 
   LogicalTableScan to FlinkLogicalTableSourceScan 
   Ant I don't know why LimitPushDown this design .


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org