You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by nchammas <gi...@git.apache.org> on 2014/09/18 03:12:14 UTC
[GitHub] spark pull request: [Build] Test selective testing
GitHub user nchammas opened a pull request:
https://github.com/apache/spark/pull/2441
[Build] Test selective testing
This is a dummy PR to test the work done in #2420 and #2437.
Do not merge it.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/nchammas/spark test-selective-testing
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/spark/pull/2441.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2441
----
commit d4c5f438f4bb46d223f36f28c7394210c9d2fa2b
Author: Nicholas Chammas <ni...@gmail.com>
Date: 2014-09-06T03:21:16Z
Merge pull request #6 from apache/master
merge upstream changes
commit 03180a4e9dc8f949b8d3372c54738547ca3813c1
Author: Nicholas Chammas <ni...@gmail.com>
Date: 2014-09-10T23:39:14Z
Merge branch 'master' of github.com:nchammas/spark
commit 8051486bbfd13dbab17b30c89ef5b4ce49d3460b
Author: Nicholas Chammas <ni...@gmail.com>
Date: 2014-09-16T02:22:18Z
Merge pull request #1 from apache/master
merge upstream changes
commit 0b47ca4b8c3497913c3eb5db3c30e63248491938
Author: Nicholas Chammas <ni...@gmail.com>
Date: 2014-09-16T02:27:19Z
Merge branch 'master' of github.com:nchammas/spark
commit e33b9787d24c52dd33b71a83c42b0a8f7033ff5e
Author: Nicholas Chammas <ni...@gmail.com>
Date: 2014-09-17T20:48:48Z
Merge pull request #2 from apache/master
merge upstream changes
commit 17505deca758ca44408170764cca3b18f5dfb427
Author: Nicholas Chammas <ni...@gmail.com>
Date: 2014-09-18T01:10:54Z
dummy sql commit
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [Build] Test selective testing
Posted by nchammas <gi...@git.apache.org>.
Github user nchammas commented on the pull request:
https://github.com/apache/spark/pull/2441#issuecomment-55986600
@marmbrus @pwendell @rxin
Here are the Jenkins outputs for when:
* [Only SQL files](https://amplab.cs.berkeley.edu/jenkins/view/Pull%20Request%20Builders/job/SparkPullRequestBuilder/20510/consoleFull) have been modified
* [SQL and non-SQL files](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/20513/consoleFull) have been modified
* [Only non-SQL files](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/20517/consoleFull) have been modified
Please confirm they look good.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [Build] Test selective testing
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/2441#issuecomment-55986709
[QA tests have finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/20510/consoleFull) for PR 2441 at commit [`17505de`](https://github.com/apache/spark/commit/17505deca758ca44408170764cca3b18f5dfb427).
* This patch **passes** unit tests.
* This patch merges cleanly.
* This patch adds no public classes.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [Build] Test selective testing
Posted by nchammas <gi...@git.apache.org>.
Github user nchammas closed the pull request at:
https://github.com/apache/spark/pull/2441
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [Build] Test selective testing
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/2441#issuecomment-55984847
[QA tests have started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/20513/consoleFull) for PR 2441 at commit [`74266ab`](https://github.com/apache/spark/commit/74266abbd7f92a35238ebcec4d6afaba9348c453).
* This patch merges cleanly.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [Build] Test selective testing
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/2441#issuecomment-55983920
[QA tests have started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/20510/consoleFull) for PR 2441 at commit [`17505de`](https://github.com/apache/spark/commit/17505deca758ca44408170764cca3b18f5dfb427).
* This patch merges cleanly.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [Build] Test selective testing
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/2441#issuecomment-55986258
[QA tests have started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/20517/consoleFull) for PR 2441 at commit [`97c43a9`](https://github.com/apache/spark/commit/97c43a9daaec50afe6714e762640e9fdcf70736f).
* This patch merges cleanly.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [Build] Test selective testing
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/2441#issuecomment-55989974
[QA tests have finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/20517/consoleFull) for PR 2441 at commit [`97c43a9`](https://github.com/apache/spark/commit/97c43a9daaec50afe6714e762640e9fdcf70736f).
* This patch **passes** unit tests.
* This patch merges cleanly.
* This patch adds no public classes.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [Build] Test selective testing
Posted by marmbrus <gi...@git.apache.org>.
Github user marmbrus commented on the pull request:
https://github.com/apache/spark/pull/2441#issuecomment-55990548
>> One minor issue is that hive-thriftserver is missing from the SQL tests
> No problem. Just give me an updated list of arguments to pass to sbt when you just want to test SQL components, and I'll submit a new PR to fix that.
Just add `hive-thriftserver/test` to the sbt command for SQL.
>>Is there a reason for the difference in the 2 & 3?
> I'm not sure; I believe this was the behavior from before my patch.
Sorry, I think I'm confused and this is actually correct as is.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [Build] Test selective testing
Posted by nchammas <gi...@git.apache.org>.
Github user nchammas commented on the pull request:
https://github.com/apache/spark/pull/2441#issuecomment-55992062
> Just add `hive-thriftserver/test` to the sbt command for SQL.
Done in #2442.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [Build] Test selective testing
Posted by nchammas <gi...@git.apache.org>.
Github user nchammas commented on the pull request:
https://github.com/apache/spark/pull/2441#issuecomment-55986032
Jenkins, retest this please.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [Build] Test selective testing
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/2441#issuecomment-55989610
[QA tests have finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/20513/consoleFull) for PR 2441 at commit [`74266ab`](https://github.com/apache/spark/commit/74266abbd7f92a35238ebcec4d6afaba9348c453).
* This patch **passes** unit tests.
* This patch merges cleanly.
* This patch adds no public classes.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [Build] Test selective testing
Posted by nchammas <gi...@git.apache.org>.
Github user nchammas commented on the pull request:
https://github.com/apache/spark/pull/2441#issuecomment-55990371
> One minor issue is that `hive-thriftserver` is missing from the SQL tests
No problem. Just give me an updated list of arguments to pass to `sbt` when you just want to test SQL components, and I'll submit a new PR to fix that.
> Is there a reason for the difference in the 2 & 3?
I'm not sure; I believe this was the behavior from before my patch.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [Build] Test selective testing
Posted by marmbrus <gi...@git.apache.org>.
Github user marmbrus commented on the pull request:
https://github.com/apache/spark/pull/2441#issuecomment-55990116
Overall I think this is better, thanks! One minor issue is that `hive-thriftserver` is missing from the SQL tests (Sorry, I think I left this out when you asked).
>Only SQL files have been modified
SQL and non-SQL files have been modified
Only non-SQL files have been modified
- 1) looks good to me
- 2) runs all tests, hive is included
- 3) runs all tests, hive is not included
Is there a reason for the difference in the 2 & 3? I think its okay to only run hive tests when catalyst, sql, or infrastructure (scripts, build files, etc) changes. Though I'll let others chime in here too.
/cc @liancheng @JoshRosen
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org