You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jdo-dev@db.apache.org by Craig L Russell <Cr...@Sun.COM> on 2008/01/25 18:12:55 UTC
[VOTE] Change signature of new method evictAll
We have a method new for JDO 2.1 in PersistenceManager and
DataStoreCache evictAll(Class cls, boolean subclasses). This pattern
would make it awkward to add a method evictAll(Class... classes,
boolean subclasses) if we decide it's valuable.
Would it make sense to change the signature to evictAll(boolean
subclasses, Class cls) now to avoid the issue later? It's a trivial
change now but a deprecation issue later.
+1 make the change now
-1 don't change (why?)
The vote will close Jan 28.
Craig
Craig Russell
Architect, Sun Java Enterprise System http://java.sun.com/products/jdo
408 276-5638 mailto:Craig.Russell@sun.com
P.S. A good JDO? O, Gasp!
Re: [VOTE] Change signature of new method evictAll
Posted by Awais Bajwa <aw...@gmail.com>.
+1 make the change now. No harm.
Awais Bajwa
On 1/25/08, Craig L Russell <Cr...@sun.com> wrote:
>
> We have a method new for JDO 2.1 in PersistenceManager and
> DataStoreCache evictAll(Class cls, boolean subclasses). This pattern
> would make it awkward to add a method evictAll(Class... classes,
> boolean subclasses) if we decide it's valuable.
>
> Would it make sense to change the signature to evictAll(boolean
> subclasses, Class cls) now to avoid the issue later? It's a trivial
> change now but a deprecation issue later.
>
> +1 make the change now
> -1 don't change (why?)
>
> The vote will close Jan 28.
>
> Craig
> Craig Russell
> Architect, Sun Java Enterprise System http://java.sun.com/products/jdo
> 408 276-5638 mailto:Craig.Russell@sun.com
> P.S. A good JDO? O, Gasp!
>
>
>
Re: [VOTE] Change signature of new method evictAll
Posted by Andy Jefferson <an...@jpox.org>.
> We're really close to the end of 2.1 and I'd like to make the change
> now to deprecate the (Object, boolean) forms of the methods and
> introduce the (boolean, Object) forms in DataStoreCache.
+1
FYI: JPOX SVN has these new methods.
--
Andy (Java Persistent Objects - http://www.jpox.org)
Re: [VOTE] Change signature of new method evictAll
Posted by Craig L Russell <Cr...@Sun.COM>.
We're really close to the end of 2.1 and I'd like to make the change
now to deprecate the (Object, boolean) forms of the methods and
introduce the (boolean, Object) forms in DataStoreCache.
Craig
On Jan 25, 2008, at 9:38 AM, Michael Bouschen wrote:
> Hi Craig,
>
> +1 make the change now.
>
> There might be one issue: method DataStoreCache.evictAll is there
> since 2.0, so we might have a backward compatibility issue here. I
> still vote for making the change now, but maybe we have to keep the
> old version and deprecate it. What do you think?
>
> Another question: how about methods DataStoreCache.pin and
> DataStoreCache.unpin? Do we want to swap the arguments (Class,
> boolean) here, too?
>
> Regards Michael
>
>> We have a method new for JDO 2.1 in PersistenceManager and
>> DataStoreCache evictAll(Class cls, boolean subclasses). This
>> pattern would make it awkward to add a method evictAll(Class...
>> classes, boolean subclasses) if we decide it's valuable.
>>
>> Would it make sense to change the signature to evictAll(boolean
>> subclasses, Class cls) now to avoid the issue later? It's a trivial
>> change now but a deprecation issue later.
>>
>> +1 make the change now
>> -1 don't change (why?)
>>
>> The vote will close Jan 28.
>>
>> Craig
>> Craig Russell
>> Architect, Sun Java Enterprise System http://java.sun.com/products/
>> jdo
>> 408 276-5638 mailto:Craig.Russell@sun.com
>> P.S. A good JDO? O, Gasp!
>>
>
>
> --
> Tech@Spree Engineering GmbH Tel.: +49/(0)30/235 520-33
> Buelowstr. 66 Fax.: +49/(0)30/217 520-12
> 10783 Berlin mailto:mbo.tech@spree.de
> Geschaeftsfuehrung: Martin Weber
> Sitz Berlin, Amtsgericht Charlottenburg, HRB 564 52
>
Craig Russell
Architect, Sun Java Enterprise System http://java.sun.com/products/jdo
408 276-5638 mailto:Craig.Russell@sun.com
P.S. A good JDO? O, Gasp!
Re: [VOTE] Change signature of new method evictAll
Posted by Michael Bouschen <mb...@spree.de>.
Hi Craig,
+1 make the change now.
There might be one issue: method DataStoreCache.evictAll is there since
2.0, so we might have a backward compatibility issue here. I still vote
for making the change now, but maybe we have to keep the old version and
deprecate it. What do you think?
Another question: how about methods DataStoreCache.pin and
DataStoreCache.unpin? Do we want to swap the arguments (Class, boolean)
here, too?
Regards Michael
> We have a method new for JDO 2.1 in PersistenceManager and
> DataStoreCache evictAll(Class cls, boolean subclasses). This pattern
> would make it awkward to add a method evictAll(Class... classes,
> boolean subclasses) if we decide it's valuable.
>
> Would it make sense to change the signature to evictAll(boolean
> subclasses, Class cls) now to avoid the issue later? It's a trivial
> change now but a deprecation issue later.
>
> +1 make the change now
> -1 don't change (why?)
>
> The vote will close Jan 28.
>
> Craig
> Craig Russell
> Architect, Sun Java Enterprise System http://java.sun.com/products/jdo
> 408 276-5638 mailto:Craig.Russell@sun.com
> P.S. A good JDO? O, Gasp!
>
--
Tech@Spree Engineering GmbH Tel.: +49/(0)30/235 520-33
Buelowstr. 66 Fax.: +49/(0)30/217 520-12
10783 Berlin mailto:mbo.tech@spree.de
Geschaeftsfuehrung: Martin Weber
Sitz Berlin, Amtsgericht Charlottenburg, HRB 564 52
RE: [VOTE] Change signature of new method evictAll
Posted by Erik Bengtson <er...@jpox.org>.
+1 make the change now
-----Message d'origine-----
De : Craig.Russell@sun.com [mailto:Craig.Russell@sun.com]
Envoyé : vendredi 25 janvier 2008 18:13
À : Apache JDO project; JDO Expert Group
Objet : [VOTE] Change signature of new method evictAll
We have a method new for JDO 2.1 in PersistenceManager and
DataStoreCache evictAll(Class cls, boolean subclasses). This pattern
would make it awkward to add a method evictAll(Class... classes,
boolean subclasses) if we decide it's valuable.
Would it make sense to change the signature to evictAll(boolean
subclasses, Class cls) now to avoid the issue later? It's a trivial
change now but a deprecation issue later.
+1 make the change now
-1 don't change (why?)
The vote will close Jan 28.
Craig
Craig Russell
Architect, Sun Java Enterprise System http://java.sun.com/products/jdo
408 276-5638 mailto:Craig.Russell@sun.com
P.S. A good JDO? O, Gasp!