You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@avro.apache.org by "Doug Cutting (JIRA)" <ji...@apache.org> on 2013/02/07 18:35:13 UTC

[jira] [Commented] (AVRO-1238) Avro-C better end of file detection

    [ https://issues.apache.org/jira/browse/AVRO-1238?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13573695#comment-13573695 ] 

Doug Cutting commented on AVRO-1238:
------------------------------------

Can someone familiar with Avro C please review this?

Also, is it possible to add a test case for this?
                
> Avro-C better end of file detection
> -----------------------------------
>
>                 Key: AVRO-1238
>                 URL: https://issues.apache.org/jira/browse/AVRO-1238
>             Project: Avro
>          Issue Type: Improvement
>          Components: c
>            Reporter: Michael Cooper
>         Attachments: 0001-Sane-EOF-checking.patch
>
>
> Currently in the C library, avro_file_reader_read_value will error out when it hits the end of a file.
> I propose we make it detect when it has hit the end of file, and return -1.
> This means that we can differentiate between errors in opening the next block versus actually having finished the file.
> I have attached the proposed changes.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira