You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@karaf.apache.org by "Guillaume Nodet (JIRA)" <ji...@apache.org> on 2016/07/26 14:31:20 UTC
[jira] [Comment Edited] (KARAF-4599) KARAF-4564 impact: karaf
startup command now only works when invoked from current directoy, no
longer via absolute path
[ https://issues.apache.org/jira/browse/KARAF-4599?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15393871#comment-15393871 ]
Guillaume Nodet edited comment on KARAF-4599 at 7/26/16 2:30 PM:
-----------------------------------------------------------------
I'm going to test the below script:
{code}
realpath() {
OURPWD=${PWD}
cd "$(dirname "${1}")"
LINK=$(readlink "$(basename "${1}")")
while [ "${LINK}" ]; do
cd "$(dirname "${LINK}")"
LINK=$(readlink "$(basename "${1}")")
done
REALPATH="${PWD}/$(basename "${1}")"
cd "${OURPWD}"
echo "${REALPATH}"
}
REALNAME=$(realpath "$0")
DIRNAME=$(dirname "${REALNAME}")
PROGNAME=$(basename "${REALNAME}")
{code}
was (Author: gnt):
I'm going to test the below script:
{{code}}
realpath() {
OURPWD=${PWD}
cd "$(dirname "${1}")"
LINK=$(readlink "$(basename "${1}")")
while [ "${LINK}" ]; do
cd "$(dirname "${LINK}")"
LINK=$(readlink "$(basename "${1}")")
done
REALPATH="${PWD}/$(basename "${1}")"
cd "${OURPWD}"
echo "${REALPATH}"
}
REALNAME=$(realpath "$0")
DIRNAME=$(dirname "${REALNAME}")
PROGNAME=$(basename "${REALNAME}")
{{code}}
> KARAF-4564 impact: karaf startup command now only works when invoked from current directoy, no longer via absolute path
> -----------------------------------------------------------------------------------------------------------------------
>
> Key: KARAF-4599
> URL: https://issues.apache.org/jira/browse/KARAF-4599
> Project: Karaf
> Issue Type: Bug
> Affects Versions: 3.0.7, 3.0.8
> Reporter: Michael Vorburger
> Assignee: Jean-Baptiste Onofré
> Priority: Critical
> Fix For: 4.1.0, 4.0.6, 3.0.8
>
>
> KARAF-4564 introduced a fix for "Can't start karaf using symbolic link", but this introduced a new regression: Following that change, the ./karaf startup command now only works when invoked from current directoy, no longer via absolute path. For example:
> {noformat}git clone git://git.apache.org/karaf.git
> cd karaf
> git checkout karaf-3.0.x
> cd tooling/karaf-maven-plugin
> mvn clean install
> cd ../..
> mvn clean install -DskipTests
> cd assemblies/apache-karaf/target/assembly/bin/
> chmod +x karaf
> ./karaf
> cd ../../../../..
> ./assemblies/apache-karaf/target/assembly/bin/karaf
> Error: Could not find or load main class org.apache.karaf.main.Main
> {noformat}
> Of course we could further fiddle with the startup script to solve this somehow, but it occurred to me that perhaps somewhere on Apache there is a ready made script for this already? Like maybe looking at e.g. how the Maven / Ant & other such tools (Gradle?) would be valuable.
> Perhaps some sort of non-regression integration test for both start-up scenarios, from current as well as via abs. path, would be of value?
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)