You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@thrift.apache.org by "Michael Stockton (JIRA)" <ji...@apache.org> on 2011/03/31 19:13:05 UTC

[jira] [Commented] (THRIFT-1108) SSL support for the Ruby library

    [ https://issues.apache.org/jira/browse/THRIFT-1108?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13014074#comment-13014074 ] 

Michael Stockton commented on THRIFT-1108:
------------------------------------------

Alex,

Can you submit your changes as a diff? Patches are preferred over individual files.

I took a quick glance and it looks like your ssl_socket.rb is very similar to thrift/transport/socket.rb. I see room to de-duplicate a lot of code there. Same goes for ssl_server_socket.rb.

Michael

> SSL support for the Ruby library 
> ---------------------------------
>
>                 Key: THRIFT-1108
>                 URL: https://issues.apache.org/jira/browse/THRIFT-1108
>             Project: Thrift
>          Issue Type: Improvement
>          Components: Ruby - Library
>    Affects Versions: 0.6
>            Reporter: Alex
>            Priority: Minor
>              Labels: ssl
>         Attachments: ssl_server_socket.rb, ssl_socket.rb
>
>
> Attached are modified versions of the socket and server_socket files which include SSL support. I do not consider these implementations complete, however they work well for my purposes.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira