You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2021/08/09 06:08:41 UTC

[GitHub] [arrow-datafusion] Dandandan commented on a change in pull request #840: [ballista] support date_part and date_turnc ser/de, pass tpch 7

Dandandan commented on a change in pull request #840:
URL: https://github.com/apache/arrow-datafusion/pull/840#discussion_r684929275



##########
File path: ballista/rust/core/proto/ballista.proto
##########
@@ -144,18 +144,19 @@ enum ScalarFunction {
   TOTIMESTAMP = 24;
   ARRAY = 25;
   NULLIF = 26;
-  DATETRUNC = 27;
-  MD5 = 28;
-  SHA224 = 29;
-  SHA256 = 30;
-  SHA384 = 31;
-  SHA512 = 32;
-  LN = 33;
+  DATEPART = 27;

Review comment:
       This makes it a breaking change? Not that it matters much now I guess, but would be good to know when it starts mattering.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org