[GitHub] matthiasblaesing commented on issue #958: [NETBEANS-1074] Module review j2ee.sun.dd

[GitBox <gi...@apache.org>]

matthiasblaesing commented on issue #958: [NETBEANS-1074] Module review j2ee.sun.dd
URL: https://github.com/apache/incubator-netbeans/pull/958#issuecomment-428698274
 
 
   Thanks - I'll start with the ALv2 files. You have an ICLA on file so I assume, that, as an Oracle employee, you are in a position to donate the new files. Having written this, you don't need to add the files to the `licenseinfo.xml` please just add the ASF header to the four files and remove the entries in the file.
   
   I noticed, that several of the DTDs don't include a incomplete/missing/wrong license headers. These look like artifacts from when the files were first imported. I looks as if Oracle/Sun got better with this is recent times and the glassfish project distributes:
   
   https://repo1.maven.org/maven2/org/glassfish/main/appclient/gf-client-module/5.0/gf-client-module-5.0.jar
   
   There the DTDs and XSDs contain sane license information. It would be good to replace the files with fresh copies. The `static-verification_1_4.dtd` file is not in there, but I would replace that with the version from the glassfish repository you already referenced.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists