[GitHub] [couchdb] nickva opened a new pull request, #4083: Fix Elixir 13 compatibility

[GitBox <gi...@apache.org>]

nickva opened a new pull request, #4083:
URL: https://github.com/apache/couchdb/pull/4083

   Elixir 13 is the only one which seems to work with Erlang 25.
   
   But we can't use Elixir 13 because of a few compatibility issues so have to fix
   this. That involves upgrading credo. However, as soon as credo was upgraded it
   noticed a bunch of issues which also had to be fixed. Some of those were:
   
    * Enum.map + join should be Enum.map_join
    * Invalid module name in teardown `%___MODULE__` -> `%__MODULE__`
    * `Mix.Config` is deprecated, use `Config`
    * `db_test.ex` looks like a test module to credo, so renamed it, otherwise it has to have an .exs extension
    * ibrowse had to be compiled so it could be properly analysed
   
   The latest credo 1.6.5 did not work and needed to bump it down to 1.6.2.
   
   Tested on macos (intel) with asdf installed elixir and erlang:
   ```
     25.0.1    / 1.13.4-otp-25
     24.3.4.1  / 1.13.4-otp-24
     23.3.4.14 / 1.10.4-otp-23
   ```
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@couchdb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [couchdb] nickva merged pull request #4083: Fix Elixir 13 compatibility

[GitBox <gi...@apache.org>]

nickva merged PR #4083:
URL: https://github.com/apache/couchdb/pull/4083


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@couchdb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [couchdb] jiahuili430 commented on pull request #4083: Fix Elixir 13 compatibility

[GitBox <gi...@apache.org>]

jiahuili430 commented on PR #4083:
URL: https://github.com/apache/couchdb/pull/4083#issuecomment-1171340638

   Tried it locally with `Erlang 23.3.2` and `Elixir 1.13.4-otp-23`, and it works!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@couchdb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org