You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@lucenenet.apache.org by Paul Irwin <pi...@feature23.com> on 2014/11/26 15:42:04 UTC

Process for accepting PRs from GitHub

I love PRs on GitHub because they are expressive, can contain discussions,
easy to see the status, etc. But what is the process for accepting a PR
from GitHub since the apache/lucene.net GitHub repo is a read-only clone of
the Apache git repo (or has that changed)?

I can help with reviewing and accepting PRs as I'm a committer, but I don't
want to do things the wrong way. Itamar, are you checking out the PR branch
locally, merging into master, then pushing up to the apache git repo?

Thanks,

Paul Irwin
Lead Software Engineer
feature[23]

Email: pirwin@feature23.com
Cell: 863-698-9294

Re: Process for accepting PRs from GitHub

Posted by Paul Irwin <pi...@feature23.com>.
Or git pull --rebase
On Nov 26, 2014 2:04 PM, "Itamar Syn-Hershko" <it...@code972.com> wrote:

> We should encourage people to use git fetch origin && git rebase
> origin/master as means to catching up of others' work as opposed to just
> git pull, but other than that its a great guide
>
> Yes Paul, this is basically what I do. Sometimes I cherry-pick tho and
> close via a comment.
>
> --
>
> Itamar Syn-Hershko
> http://code972.com | @synhershko <https://twitter.com/synhershko>
> Freelance Developer & Consultant
> Author of RavenDB in Action <http://manning.com/synhershko/>
>
> On Wed, Nov 26, 2014 at 7:25 PM, Paul Irwin <pi...@feature23.com> wrote:
>
> > Awesome, thanks Prescott!
> >
> >
> > Paul Irwin
> > Lead Software Engineer
> > feature[23]
> >
> > Email: pirwin@feature23.com
> > Cell: 863-698-9294
> >
> > On Wed, Nov 26, 2014 at 12:20 PM, Prescott Nasser <geobmx540@hotmail.com
> >
> > wrote:
> >
> > > I used this as my guide:
> > > https://mahout.apache.org/developers/github.html (we should put this
> in
> > > our docs too :) )
> > >
> > > > Date: Wed, 26 Nov 2014 09:42:04 -0500
> > > > Subject: Process for accepting PRs from GitHub
> > > > From: pirwin@feature23.com
> > > > To: dev@lucenenet.apache.org
> > > >
> > > > I love PRs on GitHub because they are expressive, can contain
> > > discussions,
> > > > easy to see the status, etc. But what is the process for accepting a
> PR
> > > > from GitHub since the apache/lucene.net GitHub repo is a read-only
> > > clone of
> > > > the Apache git repo (or has that changed)?
> > > >
> > > > I can help with reviewing and accepting PRs as I'm a committer, but I
> > > don't
> > > > want to do things the wrong way. Itamar, are you checking out the PR
> > > branch
> > > > locally, merging into master, then pushing up to the apache git repo?
> > > >
> > > > Thanks,
> > > >
> > > > Paul Irwin
> > > > Lead Software Engineer
> > > > feature[23]
> > > >
> > > > Email: pirwin@feature23.com
> > > > Cell: 863-698-9294
> > >
> > >
> >
>

Re: Process for accepting PRs from GitHub

Posted by Itamar Syn-Hershko <it...@code972.com>.
We should encourage people to use git fetch origin && git rebase
origin/master as means to catching up of others' work as opposed to just
git pull, but other than that its a great guide

Yes Paul, this is basically what I do. Sometimes I cherry-pick tho and
close via a comment.

--

Itamar Syn-Hershko
http://code972.com | @synhershko <https://twitter.com/synhershko>
Freelance Developer & Consultant
Author of RavenDB in Action <http://manning.com/synhershko/>

On Wed, Nov 26, 2014 at 7:25 PM, Paul Irwin <pi...@feature23.com> wrote:

> Awesome, thanks Prescott!
>
>
> Paul Irwin
> Lead Software Engineer
> feature[23]
>
> Email: pirwin@feature23.com
> Cell: 863-698-9294
>
> On Wed, Nov 26, 2014 at 12:20 PM, Prescott Nasser <ge...@hotmail.com>
> wrote:
>
> > I used this as my guide:
> > https://mahout.apache.org/developers/github.html (we should put this in
> > our docs too :) )
> >
> > > Date: Wed, 26 Nov 2014 09:42:04 -0500
> > > Subject: Process for accepting PRs from GitHub
> > > From: pirwin@feature23.com
> > > To: dev@lucenenet.apache.org
> > >
> > > I love PRs on GitHub because they are expressive, can contain
> > discussions,
> > > easy to see the status, etc. But what is the process for accepting a PR
> > > from GitHub since the apache/lucene.net GitHub repo is a read-only
> > clone of
> > > the Apache git repo (or has that changed)?
> > >
> > > I can help with reviewing and accepting PRs as I'm a committer, but I
> > don't
> > > want to do things the wrong way. Itamar, are you checking out the PR
> > branch
> > > locally, merging into master, then pushing up to the apache git repo?
> > >
> > > Thanks,
> > >
> > > Paul Irwin
> > > Lead Software Engineer
> > > feature[23]
> > >
> > > Email: pirwin@feature23.com
> > > Cell: 863-698-9294
> >
> >
>

Re: Process for accepting PRs from GitHub

Posted by Paul Irwin <pi...@feature23.com>.
Awesome, thanks Prescott!


Paul Irwin
Lead Software Engineer
feature[23]

Email: pirwin@feature23.com
Cell: 863-698-9294

On Wed, Nov 26, 2014 at 12:20 PM, Prescott Nasser <ge...@hotmail.com>
wrote:

> I used this as my guide:
> https://mahout.apache.org/developers/github.html (we should put this in
> our docs too :) )
>
> > Date: Wed, 26 Nov 2014 09:42:04 -0500
> > Subject: Process for accepting PRs from GitHub
> > From: pirwin@feature23.com
> > To: dev@lucenenet.apache.org
> >
> > I love PRs on GitHub because they are expressive, can contain
> discussions,
> > easy to see the status, etc. But what is the process for accepting a PR
> > from GitHub since the apache/lucene.net GitHub repo is a read-only
> clone of
> > the Apache git repo (or has that changed)?
> >
> > I can help with reviewing and accepting PRs as I'm a committer, but I
> don't
> > want to do things the wrong way. Itamar, are you checking out the PR
> branch
> > locally, merging into master, then pushing up to the apache git repo?
> >
> > Thanks,
> >
> > Paul Irwin
> > Lead Software Engineer
> > feature[23]
> >
> > Email: pirwin@feature23.com
> > Cell: 863-698-9294
>
>

RE: Process for accepting PRs from GitHub

Posted by Prescott Nasser <ge...@hotmail.com>.
I used this as my guide:
https://mahout.apache.org/developers/github.html (we should put this in our docs too :) )

> Date: Wed, 26 Nov 2014 09:42:04 -0500
> Subject: Process for accepting PRs from GitHub
> From: pirwin@feature23.com
> To: dev@lucenenet.apache.org
> 
> I love PRs on GitHub because they are expressive, can contain discussions,
> easy to see the status, etc. But what is the process for accepting a PR
> from GitHub since the apache/lucene.net GitHub repo is a read-only clone of
> the Apache git repo (or has that changed)?
> 
> I can help with reviewing and accepting PRs as I'm a committer, but I don't
> want to do things the wrong way. Itamar, are you checking out the PR branch
> locally, merging into master, then pushing up to the apache git repo?
> 
> Thanks,
> 
> Paul Irwin
> Lead Software Engineer
> feature[23]
> 
> Email: pirwin@feature23.com
> Cell: 863-698-9294