You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/02/14 18:32:41 UTC
[GitHub] [arrow] tachyonwill opened a new pull request #12423: PARQUET-2123: Fix invalid memory access in ScanFileContents
tachyonwill opened a new pull request #12423:
URL: https://github.com/apache/arrow/pull/12423
ScanFileContents assumes that there is at least one column and returns
the number of rows in total_rows[0], which is technically invalid when
there are zero columns. Fix by returning early if there are zero
columns.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] ursabot edited a comment on pull request #12423: PARQUET-2123: [C++] Fix invalid memory access in ScanFileContents
Posted by GitBox <gi...@apache.org>.
ursabot edited a comment on pull request #12423:
URL: https://github.com/apache/arrow/pull/12423#issuecomment-1040558035
Benchmark runs are scheduled for baseline = e00cf8397a73efd9eed5926d2daaa06222028c0e and contender = 1eb75b3312f179bf315c35fca44527f1c504ff3a. 1eb75b3312f179bf315c35fca44527f1c504ff3a is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Finished :arrow_down:0.0% :arrow_up:0.0%] [ec2-t3-xlarge-us-east-2](https://conbench.ursa.dev/compare/runs/7cd6765eaf69484e9caadc0882ebf4db...3c660fce62c44b3bb2da32d09af4a9ed/)
[Finished :arrow_down:0.13% :arrow_up:0.34%] [test-mac-arm](https://conbench.ursa.dev/compare/runs/3b3f256626b348c2bce4a39b4d7ced01...0f7f5fcc40284f858f2c9f46d464fb12/)
[Finished :arrow_down:0.36% :arrow_up:0.0%] [ursa-i9-9960x](https://conbench.ursa.dev/compare/runs/d475974c37f34c2fa20991cff8bf31cf...a086770a262c494894098e47dfeddc54/)
[Finished :arrow_down:0.22% :arrow_up:0.0%] [ursa-thinkcentre-m75q](https://conbench.ursa.dev/compare/runs/a5d4c5fa093245b78f09131259c5dd33...4cf8421769604e57a87e253fcc54e84d/)
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] ursabot edited a comment on pull request #12423: PARQUET-2123: [C++] Fix invalid memory access in ScanFileContents
Posted by GitBox <gi...@apache.org>.
ursabot edited a comment on pull request #12423:
URL: https://github.com/apache/arrow/pull/12423#issuecomment-1040558035
Benchmark runs are scheduled for baseline = e00cf8397a73efd9eed5926d2daaa06222028c0e and contender = 1eb75b3312f179bf315c35fca44527f1c504ff3a. 1eb75b3312f179bf315c35fca44527f1c504ff3a is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Finished :arrow_down:0.0% :arrow_up:0.0%] [ec2-t3-xlarge-us-east-2](https://conbench.ursa.dev/compare/runs/7cd6765eaf69484e9caadc0882ebf4db...3c660fce62c44b3bb2da32d09af4a9ed/)
[Scheduled] [test-mac-arm](https://conbench.ursa.dev/compare/runs/3b3f256626b348c2bce4a39b4d7ced01...0f7f5fcc40284f858f2c9f46d464fb12/)
[Scheduled] [ursa-i9-9960x](https://conbench.ursa.dev/compare/runs/d475974c37f34c2fa20991cff8bf31cf...a086770a262c494894098e47dfeddc54/)
[Finished :arrow_down:0.22% :arrow_up:0.0%] [ursa-thinkcentre-m75q](https://conbench.ursa.dev/compare/runs/a5d4c5fa093245b78f09131259c5dd33...4cf8421769604e57a87e253fcc54e84d/)
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] pitrou closed pull request #12423: PARQUET-2123: [C++] Fix invalid memory access in ScanFileContents
Posted by GitBox <gi...@apache.org>.
pitrou closed pull request #12423:
URL: https://github.com/apache/arrow/pull/12423
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] ursabot edited a comment on pull request #12423: PARQUET-2123: [C++] Fix invalid memory access in ScanFileContents
Posted by GitBox <gi...@apache.org>.
ursabot edited a comment on pull request #12423:
URL: https://github.com/apache/arrow/pull/12423#issuecomment-1040558035
Benchmark runs are scheduled for baseline = e00cf8397a73efd9eed5926d2daaa06222028c0e and contender = 1eb75b3312f179bf315c35fca44527f1c504ff3a. 1eb75b3312f179bf315c35fca44527f1c504ff3a is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Finished :arrow_down:0.0% :arrow_up:0.0%] [ec2-t3-xlarge-us-east-2](https://conbench.ursa.dev/compare/runs/7cd6765eaf69484e9caadc0882ebf4db...3c660fce62c44b3bb2da32d09af4a9ed/)
[Scheduled] [test-mac-arm](https://conbench.ursa.dev/compare/runs/3b3f256626b348c2bce4a39b4d7ced01...0f7f5fcc40284f858f2c9f46d464fb12/)
[Scheduled] [ursa-i9-9960x](https://conbench.ursa.dev/compare/runs/d475974c37f34c2fa20991cff8bf31cf...a086770a262c494894098e47dfeddc54/)
[Scheduled] [ursa-thinkcentre-m75q](https://conbench.ursa.dev/compare/runs/a5d4c5fa093245b78f09131259c5dd33...4cf8421769604e57a87e253fcc54e84d/)
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #12423: PARQUET-2123: Fix invalid memory access in ScanFileContents
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #12423:
URL: https://github.com/apache/arrow/pull/12423#issuecomment-1039419047
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] ursabot edited a comment on pull request #12423: PARQUET-2123: [C++] Fix invalid memory access in ScanFileContents
Posted by GitBox <gi...@apache.org>.
ursabot edited a comment on pull request #12423:
URL: https://github.com/apache/arrow/pull/12423#issuecomment-1040558035
Benchmark runs are scheduled for baseline = e00cf8397a73efd9eed5926d2daaa06222028c0e and contender = 1eb75b3312f179bf315c35fca44527f1c504ff3a. 1eb75b3312f179bf315c35fca44527f1c504ff3a is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Finished :arrow_down:0.0% :arrow_up:0.0%] [ec2-t3-xlarge-us-east-2](https://conbench.ursa.dev/compare/runs/7cd6765eaf69484e9caadc0882ebf4db...3c660fce62c44b3bb2da32d09af4a9ed/)
[Scheduled] [test-mac-arm](https://conbench.ursa.dev/compare/runs/3b3f256626b348c2bce4a39b4d7ced01...0f7f5fcc40284f858f2c9f46d464fb12/)
[Scheduled] [ursa-i9-9960x](https://conbench.ursa.dev/compare/runs/d475974c37f34c2fa20991cff8bf31cf...a086770a262c494894098e47dfeddc54/)
[Scheduled] [ursa-thinkcentre-m75q](https://conbench.ursa.dev/compare/runs/a5d4c5fa093245b78f09131259c5dd33...4cf8421769604e57a87e253fcc54e84d/)
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #12423: PARQUET-2123: Fix invalid memory access in ScanFileContents
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #12423:
URL: https://github.com/apache/arrow/pull/12423#issuecomment-1039419047
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] ursabot commented on pull request #12423: PARQUET-2123: [C++] Fix invalid memory access in ScanFileContents
Posted by GitBox <gi...@apache.org>.
ursabot commented on pull request #12423:
URL: https://github.com/apache/arrow/pull/12423#issuecomment-1040558035
Benchmark runs are scheduled for baseline = e00cf8397a73efd9eed5926d2daaa06222028c0e and contender = 1eb75b3312f179bf315c35fca44527f1c504ff3a. 1eb75b3312f179bf315c35fca44527f1c504ff3a is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Scheduled] [ec2-t3-xlarge-us-east-2](https://conbench.ursa.dev/compare/runs/7cd6765eaf69484e9caadc0882ebf4db...3c660fce62c44b3bb2da32d09af4a9ed/)
[Scheduled] [test-mac-arm](https://conbench.ursa.dev/compare/runs/3b3f256626b348c2bce4a39b4d7ced01...0f7f5fcc40284f858f2c9f46d464fb12/)
[Scheduled] [ursa-i9-9960x](https://conbench.ursa.dev/compare/runs/d475974c37f34c2fa20991cff8bf31cf...a086770a262c494894098e47dfeddc54/)
[Scheduled] [ursa-thinkcentre-m75q](https://conbench.ursa.dev/compare/runs/a5d4c5fa093245b78f09131259c5dd33...4cf8421769604e57a87e253fcc54e84d/)
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] ursabot commented on pull request #12423: PARQUET-2123: [C++] Fix invalid memory access in ScanFileContents
Posted by GitBox <gi...@apache.org>.
ursabot commented on pull request #12423:
URL: https://github.com/apache/arrow/pull/12423#issuecomment-1040558035
Benchmark runs are scheduled for baseline = e00cf8397a73efd9eed5926d2daaa06222028c0e and contender = 1eb75b3312f179bf315c35fca44527f1c504ff3a. 1eb75b3312f179bf315c35fca44527f1c504ff3a is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Scheduled] [ec2-t3-xlarge-us-east-2](https://conbench.ursa.dev/compare/runs/7cd6765eaf69484e9caadc0882ebf4db...3c660fce62c44b3bb2da32d09af4a9ed/)
[Scheduled] [test-mac-arm](https://conbench.ursa.dev/compare/runs/3b3f256626b348c2bce4a39b4d7ced01...0f7f5fcc40284f858f2c9f46d464fb12/)
[Scheduled] [ursa-i9-9960x](https://conbench.ursa.dev/compare/runs/d475974c37f34c2fa20991cff8bf31cf...a086770a262c494894098e47dfeddc54/)
[Scheduled] [ursa-thinkcentre-m75q](https://conbench.ursa.dev/compare/runs/a5d4c5fa093245b78f09131259c5dd33...4cf8421769604e57a87e253fcc54e84d/)
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] pitrou closed pull request #12423: PARQUET-2123: [C++] Fix invalid memory access in ScanFileContents
Posted by GitBox <gi...@apache.org>.
pitrou closed pull request #12423:
URL: https://github.com/apache/arrow/pull/12423
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] ursabot edited a comment on pull request #12423: PARQUET-2123: [C++] Fix invalid memory access in ScanFileContents
Posted by GitBox <gi...@apache.org>.
ursabot edited a comment on pull request #12423:
URL: https://github.com/apache/arrow/pull/12423#issuecomment-1040558035
Benchmark runs are scheduled for baseline = e00cf8397a73efd9eed5926d2daaa06222028c0e and contender = 1eb75b3312f179bf315c35fca44527f1c504ff3a. 1eb75b3312f179bf315c35fca44527f1c504ff3a is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Finished :arrow_down:0.0% :arrow_up:0.0%] [ec2-t3-xlarge-us-east-2](https://conbench.ursa.dev/compare/runs/7cd6765eaf69484e9caadc0882ebf4db...3c660fce62c44b3bb2da32d09af4a9ed/)
[Finished :arrow_down:0.13% :arrow_up:0.34%] [test-mac-arm](https://conbench.ursa.dev/compare/runs/3b3f256626b348c2bce4a39b4d7ced01...0f7f5fcc40284f858f2c9f46d464fb12/)
[Scheduled] [ursa-i9-9960x](https://conbench.ursa.dev/compare/runs/d475974c37f34c2fa20991cff8bf31cf...a086770a262c494894098e47dfeddc54/)
[Finished :arrow_down:0.22% :arrow_up:0.0%] [ursa-thinkcentre-m75q](https://conbench.ursa.dev/compare/runs/a5d4c5fa093245b78f09131259c5dd33...4cf8421769604e57a87e253fcc54e84d/)
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org