You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@lucene.apache.org by "Robert Muir (JIRA)" <ji...@apache.org> on 2015/08/11 15:14:46 UTC
[jira] [Commented] (LUCENE-6732) Improve validate-source-patterns
in build.xml (e.g., detect invalid license headers!!)
[ https://issues.apache.org/jira/browse/LUCENE-6732?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14681780#comment-14681780 ]
Robert Muir commented on LUCENE-6732:
-------------------------------------
+1, this is great
> Improve validate-source-patterns in build.xml (e.g., detect invalid license headers!!)
> --------------------------------------------------------------------------------------
>
> Key: LUCENE-6732
> URL: https://issues.apache.org/jira/browse/LUCENE-6732
> Project: Lucene - Core
> Issue Type: Improvement
> Reporter: Uwe Schindler
> Assignee: Uwe Schindler
> Attachments: LUCENE-6732.patch
>
>
> Today I enabled warnings analysis on Policeman Jenkins. This scans the build log for warnings by javac and reports them in statistics, together with source file dumps.
> When doing that I found out that someone added again a lot of "invalid" license headers using {{/\*\*}} instead a simple comment. This causes javadocs warnings under some circumstances, because {{/\*\*}} is start of javadocs and not a license comment.
> I then tried to fix the validate-source-patterns to detect this, but due to a bug in ANT, the {{<containsregexp/>}} filter is applied per line (although it has multiline matching capabilities!!!).
> So I rewrote our checker to run with groovy. This also has some good parts:
> - it tells you wwhat was broken, otherwise you just know there is an error, but not whats wrong (tab, nocommit,...)
> - its much faster (multiple {{<containsregexp/>}} read file over and over, this one reads file one time into a string and then applies all regular expressions).
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
Re: [jira] [Commented] (LUCENE-6732) Improve validate-source-patterns
in build.xml (e.g., detect invalid license headers!!)
Posted by Erick Erickson <er...@gmail.com>.
Thanks Uwe!
On Tue, Aug 11, 2015 at 6:14 AM, Robert Muir (JIRA) <ji...@apache.org> wrote:
>
> [ https://issues.apache.org/jira/browse/LUCENE-6732?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14681780#comment-14681780 ]
>
> Robert Muir commented on LUCENE-6732:
> -------------------------------------
>
> +1, this is great
>
>> Improve validate-source-patterns in build.xml (e.g., detect invalid license headers!!)
>> --------------------------------------------------------------------------------------
>>
>> Key: LUCENE-6732
>> URL: https://issues.apache.org/jira/browse/LUCENE-6732
>> Project: Lucene - Core
>> Issue Type: Improvement
>> Reporter: Uwe Schindler
>> Assignee: Uwe Schindler
>> Attachments: LUCENE-6732.patch
>>
>>
>> Today I enabled warnings analysis on Policeman Jenkins. This scans the build log for warnings by javac and reports them in statistics, together with source file dumps.
>> When doing that I found out that someone added again a lot of "invalid" license headers using {{/\*\*}} instead a simple comment. This causes javadocs warnings under some circumstances, because {{/\*\*}} is start of javadocs and not a license comment.
>> I then tried to fix the validate-source-patterns to detect this, but due to a bug in ANT, the {{<containsregexp/>}} filter is applied per line (although it has multiline matching capabilities!!!).
>> So I rewrote our checker to run with groovy. This also has some good parts:
>> - it tells you wwhat was broken, otherwise you just know there is an error, but not whats wrong (tab, nocommit,...)
>> - its much faster (multiple {{<containsregexp/>}} read file over and over, this one reads file one time into a string and then applies all regular expressions).
>
>
>
> --
> This message was sent by Atlassian JIRA
> (v6.3.4#6332)
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
> For additional commands, e-mail: dev-help@lucene.apache.org
>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org