You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@iceberg.apache.org by GitBox <gi...@apache.org> on 2022/10/14 08:48:23 UTC

[GitHub] [iceberg] Fokko commented on a diff in pull request #5966: Python: Implement select

Fokko commented on code in PR #5966:
URL: https://github.com/apache/iceberg/pull/5966#discussion_r995513590


##########
python/pyiceberg/exceptions.py:
##########
@@ -82,3 +82,7 @@ class NoSuchPropertyException(Exception):
 
 class NotInstalledError(Exception):
     """When an optional dependency is not installed"""
+
+
+class ColumnNotFoundError(Exception):
+    """When selecting a column that doesn't exist"""

Review Comment:
   I figured this would be a nice one to add since it is very user facing. We're throwing a lot of `ValueError`'s already 😱 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org