[GitHub] [hadoop] vivekratnavel commented on a change in pull request #954: HDDS-1670. Add limit support to /api/containers and /api/containers/{id} endpoints

[GitBox <gi...@apache.org>]

vivekratnavel commented on a change in pull request #954: HDDS-1670. Add limit support to /api/containers and /api/containers/{id} endpoints
URL: https://github.com/apache/hadoop/pull/954#discussion_r293530930
 
 

 ##########
 File path: hadoop-ozone/ozone-recon/src/main/java/org/apache/hadoop/ozone/recon/api/ContainerKeyService.java
 ##########
 @@ -72,10 +74,11 @@
    * @return {@link Response}
    */
   @GET
-  public Response getContainers() {
+  public Response getContainers(
+      @DefaultValue("-1") @QueryParam("limit") int limit) {
     Map<Long, ContainerMetadata> containersMap;
     try {
-      containersMap = containerDBServiceProvider.getContainers();
+      containersMap = containerDBServiceProvider.getContainers(limit);
     } catch (IOException ioEx) {
 
 Review comment:
   @bharatviswa504 This PR only supports limit param and I don't see the need for skip param support in the near feature. I will explain how the UI will consume this API to show containers and keys to the users. UI will fetch this API with an initial limit of 50 (arbitrary number or could be x% of totalCount). When the user scrolls to the end of the list, UI will trigger another call to the same API with limit + 50 to get 100 items. In a similar fashion, UI will keep loading results with infinite scroll like something similar to this demo - https://infinite-scroll.com/demo/full-page/ . Since, the results are not going to be paginated, there is no need for skip param support here in my opinion. 
   
   The only thing missing is the totalCount in the response of these APIs and that will be implemented as part of another JIRA if needed in the future. Infinite scroll could be implemented without total count but having total count in the UI will give better user experience. 
   
   Please let me know if you have any more questions.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org