You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2018/08/23 16:50:13 UTC

[GitHub] kristw commented on a change in pull request #5712: [deck polygon] add support for geohash

kristw commented on a change in pull request #5712: [deck polygon] add support for geohash
URL: https://github.com/apache/incubator-superset/pull/5712#discussion_r212381253
 
 

 ##########
 File path: superset/assets/src/modules/colors.js
 ##########
 @@ -581,15 +591,9 @@ export const colorScalerFactory = function (colors, data, accessor, extents) {
   }
   const chunkSize = (ext[1] - ext[0]) / (colors.length - 1);
   const points = colors.map((col, i) => ext[0] + (i * chunkSize));
-  return d3.scale.linear().domain(points).range(colors).clamp(true);
-};
-
-export function hexToRGB(hex, alpha = 255) {
-  if (!hex) {
-    return [0, 0, 0, alpha];
+  const scaler = d3.scale.linear().domain(points).range(colors).clamp(true);
+  if (outpoutRGBA) {
 
 Review comment:
   `output`?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org