You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@bookkeeper.apache.org by GitBox <gi...@apache.org> on 2018/06/07 02:29:19 UTC

[GitHub] sijie opened a new pull request #1497: Improve merge script on checking the statuses of github checks

sijie opened a new pull request #1497: Improve merge script on checking the statuses of github checks
URL: https://github.com/apache/bookkeeper/pull/1497
 
 
   Descriptions of the changes in this PR:
   
   *Motivation*
   
   Sometimes Jenkins CI job might already succeed, however they failed on publishing the build status
   to Github due to timeout (one example is attached below). In this case, we don't need to rerun the jenkins check again.
   
   ```
   Setting status of 55c1d54f3293e5166c59f238afd3fb3d98c7eb67 to SUCCESS with url https://builds.apache.org/job/bookkeeper_precommit_client_tests/21/ and message: 'SUCCESS
    '
   Using context: Jenkins: Client Tests
   Could not update commit status of the Pull Request on GitHub.
   org.kohsuke.github.HttpException: Server returned HTTP response code: -1, message: 'null' for URL: https://api.github.com/repos/apache/bookkeeper/statuses/55c1d54f3293e5166c59f238afd3fb3d98c7eb67
   	at org.kohsuke.github.Requester.parse(Requester.java:633)
   	at org.kohsuke.github.Requester.parse(Requester.java:631)
   	at org.kohsuke.github.Requester.parse(Requester.java:631)
   	at org.kohsuke.github.Requester.parse(Requester.java:594)
   	at org.kohsuke.github.Requester._to(Requester.java:272)
   	at org.kohsuke.github.Requester.to(Requester.java:234)
   	at org.kohsuke.github.GHRepository.createCommitStatus(GHRepository.java:1075)
   	at org.jenkinsci.plugins.ghprb.extensions.status.GhprbSimpleStatus.createCommitStatus(GhprbSimpleStatus.java:281)
   	at org.jenkinsci.plugins.ghprb.extensions.status.GhprbSimpleStatus.onBuildComplete(GhprbSimpleStatus.java:239)
   	at org.jenkinsci.plugins.ghprb.GhprbBuilds.onCompleted(GhprbBuilds.java:205)
   	at org.jenkinsci.plugins.ghprb.GhprbBuildListener.onCompleted(GhprbBuildListener.java:28)
   	at hudson.model.listeners.RunListener.fireCompleted(RunListener.java:211)
   	at hudson.model.Run.execute(Run.java:1769)
   	at hudson.model.FreeStyleBuild.run(FreeStyleBuild.java:43)
   	at hudson.model.ResourceController.execute(ResourceController.java:97)
   	at hudson.model.Executor.run(Executor.java:429)
   Caused by: java.net.SocketTimeoutException: Read timed out
   	at sun.reflect.GeneratedConstructorAccessor10056.newInstance(Unknown Source)
   	at sun.reflect.DelegatingConstructorAccessorImpl.newInstance(DelegatingConstructorAccessorImpl.java:45)
   	at java.lang.reflect.Constructor.newInstance(Constructor.java:423)
   	at sun.net.www.protocol.http.HttpURLConnection$10.run(HttpURLConnection.java:1944)
   	at sun.net.www.protocol.http.HttpURLConnection$10.run(HttpURLConnection.java:1939)
   	at java.security.AccessController.doPrivileged(Native Method)
   	at sun.net.www.protocol.http.HttpURLConnection.getChainedException(HttpURLConnection.java:1938)
   	at sun.net.www.protocol.http.HttpURLConnection.getInputStream0(HttpURLConnection.java:1508)
   	at sun.net.www.protocol.http.HttpURLConnection.getInputStream(HttpURLConnection.java:1492)
   	at java.net.HttpURLConnection.getResponseCode(HttpURLConnection.java:480)
   	at sun.net.www.protocol.https.HttpsURLConnectionImpl.getResponseCode(HttpsURLConnectionImpl.java:347)
   	at org.kohsuke.github.Requester.parse(Requester.java:602)
   	... 15 more
   Caused by: java.net.SocketTimeoutException: Read timed out
   	at java.net.SocketInputStream.socketRead0(Native Method)
   	at java.net.SocketInputStream.socketRead(SocketInputStream.java:116)
   	at java.net.SocketInputStream.read(SocketInputStream.java:171)
   	at java.net.SocketInputStream.read(SocketInputStream.java:141)
   	at sun.security.ssl.InputRecord.readFully(InputRecord.java:465)
   	at sun.security.ssl.InputRecord.read(InputRecord.java:503)
   	at sun.security.ssl.SSLSocketImpl.readRecord(SSLSocketImpl.java:983)
   	at sun.security.ssl.SSLSocketImpl.readDataRecord(SSLSocketImpl.java:940)
   	at sun.security.ssl.AppInputStream.read(AppInputStream.java:105)
   	at java.io.BufferedInputStream.fill(BufferedInputStream.java:246)
   	at java.io.BufferedInputStream.read1(BufferedInputStream.java:286)
   	at java.io.BufferedInputStream.read(BufferedInputStream.java:345)
   	at sun.net.www.http.HttpClient.parseHTTPHeader(HttpClient.java:735)
   	at sun.net.www.http.HttpClient.parseHTTP(HttpClient.java:678)
   	at sun.net.www.protocol.http.HttpURLConnection.getInputStream0(HttpURLConnection.java:1587)
   	at sun.net.www.protocol.http.HttpURLConnection.getInputStream(HttpURLConnection.java:1492)
   	at java.net.HttpURLConnection.getResponseCode(HttpURLConnection.java:480)
   	at sun.net.www.protocol.https.HttpsURLConnectionImpl.getResponseCode(HttpsURLConnectionImpl.java:347)
   	at org.kohsuke.github.Requester.parse(Requester.java:602)
   	... 13 more
   Finished: SUCCESS
   ```
   
   *Changes*
   
   Improve the merge script to check jenkins status before treating the checks as failed.
   
   > ---
   > - [skip tests]
   > - [skip integration tests]
   > - [skip build java8]
   > - [skip build java9]
   > ---
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services