You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@mina.apache.org by tr...@apache.org on 2007/09/17 03:11:08 UTC

svn commit: r576230 - /mina/trunk/core/src/main/java/org/apache/mina/transport/socket/nio/DatagramAcceptor.java

Author: trustin
Date: Sun Sep 16 18:11:08 2007
New Revision: 576230

URL: http://svn.apache.org/viewvc?rev=576230&view=rev
Log:
Removed unnecessary synchronization

Modified:
    mina/trunk/core/src/main/java/org/apache/mina/transport/socket/nio/DatagramAcceptor.java

Modified: mina/trunk/core/src/main/java/org/apache/mina/transport/socket/nio/DatagramAcceptor.java
URL: http://svn.apache.org/viewvc/mina/trunk/core/src/main/java/org/apache/mina/transport/socket/nio/DatagramAcceptor.java?rev=576230&r1=576229&r2=576230&view=diff
==============================================================================
--- mina/trunk/core/src/main/java/org/apache/mina/transport/socket/nio/DatagramAcceptor.java (original)
+++ mina/trunk/core/src/main/java/org/apache/mina/transport/socket/nio/DatagramAcceptor.java Sun Sep 16 18:11:08 2007
@@ -416,11 +416,7 @@
         int maxWrittenBytes = session.getConfig().getSendBufferSize() << 1;
         try {
             for (; ;) {
-                WriteRequest req;
-                synchronized (writeRequestQueue) {
-                    req = writeRequestQueue.peek();
-                }
-
+                WriteRequest req = writeRequestQueue.peek();
                 if (req == null) {
                     break;
                 }
@@ -428,10 +424,7 @@
                 ByteBuffer buf = (ByteBuffer) req.getMessage();
                 if (buf.remaining() == 0) {
                     // pop and fire event
-                    synchronized (writeRequestQueue) {
-                        writeRequestQueue.poll();
-                    }
-
+                    writeRequestQueue.poll();
                     session.increaseWrittenMessages();
                     buf.reset();
                     session.getFilterChain().fireMessageSent(session, req);
@@ -452,10 +445,7 @@
                     key.interestOps(key.interestOps() & ~SelectionKey.OP_WRITE);
 
                     // pop and fire event
-                    synchronized (writeRequestQueue) {
-                        writeRequestQueue.poll();
-                    }
-
+                    writeRequestQueue.poll();
                     writtenBytes += localWrittenBytes;
                     session.increaseWrittenMessages();
                     buf.reset();