Re: [Trinidad] added browser version support in skinning TRINIDAD-799

[Cristi Toth <cr...@gmail.com>]

Hi Blake!

On Thu, Apr 17, 2008 at 11:44 PM, Blake Sullivan <bl...@oracle.com>
wrote:

>  Cristi Toth said the following On 4/17/2008 2:25 PM PT:
>
>
> On Thu, Apr 17, 2008 at 11:15 PM, Blake Sullivan <
> blake.sullivan@oracle.com> wrote:
>
> > Cristi Toth said the following On 4/17/2008 2:00 PM PT
> >
> >  Does anybody KNOW how the browsers express their  version exactly?
> > Because TrinidadAgent currently only has majorVersion and agentVersion
> > (the latter being an unparsed string).
> > I will have to parse that agentVersion to also get out the minor
> > version.
> > Does anybody know why this wasn't done initially? (any reason like too
> > different between the browsers?)
> >
> >  I can't remember why I wrote the code the way I did 12 years ago, but
> > assuming that I was lazy and didn't think that it probably mattered that
> > much at the time is probably a good bet.
> >
>
> :)
>
> I assume you can't "donate" prematurely those regex, right?
>
> I'm sure we can.
>
> Matthias, can you give them to Christi.  They are in AdfAgent.getAgent().
>
> -- Blake
>

Can we hurry up this pls.
Matthias is planning a release and it would be nice to have this feature the
right way in there.


>
>
>
>
> >
> > -- Blake Sullivan
> >
> >
> >
> >
> > >
> > >
> > > 8 is promoted to 8.0 and since max- means
> > > less-than-or-equal-to:max-version:8 means
> > >
> > > version <= 8.0 == true
> > >
> > > -- Blake Sullivan
> >
> >
>
>
> --
> Cristi Toth
>
> -------------
> Codebeat
> www.codebeat.ro
>
>
>


-- 
Cristi Toth

-------------
Codebeat
www.codebeat.ro