You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@arrow.apache.org by GitBox <gi...@apache.org> on 2023/01/16 14:17:20 UTC
[GitHub] [arrow] paleolimbot opened a new issue, #33701: Link-time optimization reports violations of one-definition rule in the R package
paleolimbot opened a new issue, #33701:
URL: https://github.com/apache/arrow/issues/33701
### Describe the bug, including details regarding any error messages, version, and platform.
The warning:
```
* checking whether package ‘arrow’ can be installed ... [18m/17m] WARNING
Found the following significant warnings:
/arrow/cpp/src/arrow/type.h:323: warning: virtual table of type ‘struct NestedType’ violates one definition rule [-Wodr]
/arrow/cpp/src/arrow/type.h:288: warning: virtual table of type ‘struct FixedWidthType’ violates one definition rule [-Wodr]
See ‘/arrow/r/check/arrow.Rcheck/00install.out’ for details.
```
‘/arrow/r/check/arrow.Rcheck/00install.out’ (for details):
```
/arrow/cpp/src/arrow/type.h:323: warning: virtual table of type ‘struct NestedType’ violates one definition rule [-Wodr]
323 | class ARROW_EXPORT NestedType : public DataType, public ParametricType {
|
/arrow/r/check/arrow.Rcheck/00_pkg_src/arrow/libarrow/arrow-10.0.1.9000/include/arrow/type.h:323:20: note: the conflicting type defined in another translation unit
323 | class ARROW_EXPORT NestedType : public DataType, public ParametricType {
| ^
/arrow/r/check/arrow.Rcheck/00_pkg_src/arrow/libarrow/arrow-10.0.1.9000/include/arrow/type.h:177:22: note: virtual method ‘storage_id’
177 | virtual Type::type storage_id() const { return id_; }
| ^
<built-in>: note: ought to match virtual method ‘__cxa_pure_virtual’ but does not
/arrow/cpp/src/arrow/type.h:288: warning: virtual table of type ‘struct FixedWidthType’ violates one definition rule [-Wodr]
288 | class ARROW_EXPORT FixedWidthType : public DataType {
|
/arrow/r/check/arrow.Rcheck/00_pkg_src/arrow/libarrow/arrow-10.0.1.9000/include/arrow/type.h:288:20: note: the conflicting type defined in another translation unit
288 | class ARROW_EXPORT FixedWidthType : public DataType {
| ^
/arrow/r/check/arrow.Rcheck/00_pkg_src/arrow/libarrow/arrow-10.0.1.9000/include/arrow/type.h:177:22: note: virtual method ‘storage_id’
177 | virtual Type::type storage_id() const { return id_; }
| ^
<built-in>: note: ought to match virtual method ‘__cxa_pure_virtual’ but does not
```
I think this is an R package problem...somehow we are mixing up the includes or the linking in such a way that we're picking up includes outside of the package directory (which we really don't want in case there's a user install of Arrow that's a different version!).
### Component(s)
R
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@arrow.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] paleolimbot commented on issue #33701: [R] Link-time optimization reports violations of one-definition rule in the R package
Posted by GitBox <gi...@apache.org>.
paleolimbot commented on issue #33701:
URL: https://github.com/apache/arrow/issues/33701#issuecomment-1397052533
CRAN runs an LTO build as part of its check suite...if there are warnings during the linking, we get an email saying that we need to fix them in two weeks to "safely retain our package on CRAN".
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] kou commented on issue #33701: [R] Link-time optimization reports violations of one-definition rule in the R package
Posted by "kou (via GitHub)" <gi...@apache.org>.
kou commented on issue #33701:
URL: https://github.com/apache/arrow/issues/33701#issuecomment-1399429595
> CRAN runs an LTO build as part of its check suite...if there are warnings during the linking, we get an email saying that we need to fix them in two weeks to "safely retain our package on CRAN".
Ah, I see.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] paleolimbot commented on issue #33701: Link-time optimization reports violations of one-definition rule in the R package
Posted by GitBox <gi...@apache.org>.
paleolimbot commented on issue #33701:
URL: https://github.com/apache/arrow/issues/33701#issuecomment-1384370193
Or one of the libraries is coming from a system install. I can't find anything wrong with the install output:
```
g++ -std=gnu++17 -I"/opt/R-devel/lib/R/include" -DNDEBUG -I/arrow/r/check/arrow.Rcheck/00_pkg_src/arrow/libarrow/arrow-10.0.1.9000/include -DARROW_STATIC -DARROW_R_WITH_PARQUET -DARROW_R_WITH_DATASET -DARROW_R_WITH_JSON -I'/opt/R-devel/lib/R/library/cpp11/include' -I/usr/local/include -fpic -Wall -pedantic -flto -c RTasks.cpp -o RTasks.o
g++ -std=gnu++17 -I"/opt/R-devel/lib/R/include" -DNDEBUG -I/arrow/r/check/arrow.Rcheck/00_pkg_src/arrow/libarrow/arrow-10.0.1.9000/include -DARROW_STATIC -DARROW_R_WITH_PARQUET -DARROW_R_WITH_DATASET -DARROW_R_WITH_JSON -I'/opt/R-devel/lib/R/library/cpp11/include' -I/usr/local/include -fpic -Wall -pedantic -flto -c altrep.cpp -o altrep.o
g++ -std=gnu++17 -I"/opt/R-devel/lib/R/include" -DNDEBUG -I/arrow/r/check/arrow.Rcheck/00_pkg_src/arrow/libarrow/arrow-10.0.1.9000/include -DARROW_STATIC -DARROW_R_WITH_PARQUET -DARROW_R_WITH_DATASET -DARROW_R_WITH_JSON -I'/opt/R-devel/lib/R/library/cpp11/include' -I/usr/local/include -fpic -Wall -pedantic -flto -c array.cpp -o array.o
g++ -std=gnu++17 -I"/opt/R-devel/lib/R/include" -DNDEBUG -I/arrow/r/check/arrow.Rcheck/00_pkg_src/arrow/libarrow/arrow-10.0.1.9000/include -DARROW_STATIC -DARROW_R_WITH_PARQUET -DARROW_R_WITH_DATASET -DARROW_R_WITH_JSON -I'/opt/R-devel/lib/R/library/cpp11/include' -I/usr/local/include -fpic -Wall -pedantic -flto -c array_to_vector.cpp -o array_to_vector.o
g++ -std=gnu++17 -I"/opt/R-devel/lib/R/include" -DNDEBUG -I/arrow/r/check/arrow.Rcheck/00_pkg_src/arrow/libarrow/arrow-10.0.1.9000/include -DARROW_STATIC -DARROW_R_WITH_PARQUET -DARROW_R_WITH_DATASET -DARROW_R_WITH_JSON -I'/opt/R-devel/lib/R/library/cpp11/include' -I/usr/local/include -fpic -Wall -pedantic -flto -c threadpool.cpp -o threadpool.o
g++ -std=gnu++17 -I"/opt/R-devel/lib/R/include" -DNDEBUG -I/arrow/r/check/arrow.Rcheck/00_pkg_src/arrow/libarrow/arrow-10.0.1.9000/include -DARROW_STATIC -DARROW_R_WITH_PARQUET -DARROW_R_WITH_DATASET -DARROW_R_WITH_JSON -I'/opt/R-devel/lib/R/library/cpp11/include' -I/usr/local/include -fpic -Wall -pedantic -flto -c type_infer.cpp -o type_infer.o
g++ -std=gnu++17 -shared -Wall -pedantic -flto -fpic -L/opt/R-devel/lib/R/lib -L/usr/local/lib -o arrow.so RTasks.o altrep.o array.o array_to_vector.o arraydata.o arrowExports.o bridge.o buffer.o chunkedarray.o compression.o compute-exec.o compute.o config.o csv.o dataset.o datatype.o expression.o extension-impl.o feather.o field.o filesystem.o io.o json.o memorypool.o message.o parquet.o r_to_arrow.o recordbatch.o recordbatchreader.o recordbatchwriter.o safe-call-into-r-impl.o scalar.o schema.o symbols.o table.o threadpool.o type_infer.o -L/arrow/r/check/arrow.Rcheck/00_pkg_src/arrow/libarrow/arrow-10.0.1.9000/lib -larrow_dataset -lparquet -larrow -larrow_bundled_dependencies -L/opt/R-devel/lib/R/lib -lR
/arrow/cpp/src/arrow/type.h:323: warning: virtual table of type ‘struct NestedType’ violates one definition rule [-Wodr]
323 | class ARROW_EXPORT NestedType : public DataType, public ParametricType {
|
/arrow/r/check/arrow.Rcheck/00_pkg_src/arrow/libarrow/arrow-10.0.1.9000/include/arrow/type.h:323:20: note: the conflicting type defined in another translation unit
323 | class ARROW_EXPORT NestedType : public DataType, public ParametricType {
| ^
/arrow/r/check/arrow.Rcheck/00_pkg_src/arrow/libarrow/arrow-10.0.1.9000/include/arrow/type.h:177:22: note: virtual method ‘storage_id’
177 | virtual Type::type storage_id() const { return id_; }
| ^
<built-in>: note: ought to match virtual method ‘__cxa_pure_virtual’ but does not
/arrow/cpp/src/arrow/type.h:288: warning: virtual table of type ‘struct FixedWidthType’ violates one definition rule [-Wodr]
288 | class ARROW_EXPORT FixedWidthType : public DataType {
|
/arrow/r/check/arrow.Rcheck/00_pkg_src/arrow/libarrow/arrow-10.0.1.9000/include/arrow/type.h:288:20: note: the conflicting type defined in another translation unit
288 | class ARROW_EXPORT FixedWidthType : public DataType {
| ^
/arrow/r/check/arrow.Rcheck/00_pkg_src/arrow/libarrow/arrow-10.0.1.9000/include/arrow/type.h:177:22: note: virtual method ‘storage_id’
177 | virtual Type::type storage_id() const { return id_; }
| ^
<built-in>: note: ought to match virtual method ‘__cxa_pure_virtual’ but does not
lto-wrapper: warning: using serial compilation of 128 LTRANS jobs
lto-wrapper: note: see the ‘-flto’ option documentation for more information
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] kou commented on issue #33701: [R] Link-time optimization reports violations of one-definition rule in the R package
Posted by GitBox <gi...@apache.org>.
kou commented on issue #33701:
URL: https://github.com/apache/arrow/issues/33701#issuecomment-1385564069
Could you try the following patch?
```diff
diff --git a/cpp/src/arrow/util/value_parsing.h b/cpp/src/arrow/util/value_parsing.h
index 5193f0af75..d444bf68ec 100644
--- a/cpp/src/arrow/util/value_parsing.h
+++ b/cpp/src/arrow/util/value_parsing.h
@@ -920,8 +920,8 @@ bool ParseValue(const T& type, const char* s, size_t length,
template <typename T>
enable_if_parameter_free<T, bool> ParseValue(
const char* s, size_t length, typename StringConverter<T>::value_type* out) {
- static T type;
- return StringConverter<T>{}.Convert(type, s, length, out);
+ auto type = std::static_pointer_cast<T>(TypeTraits<T>::type_singleton());
+ return StringConverter<T>{}.Convert(*type, s, length, out);
}
} // namespace internal
```
It seems that https://github.com/apache/arrow/blob/98da8191242f22d3de225a08c387f5b150bb7a5c/cpp/src/parquet/arrow/schema.cc#L265 (`libparquet.a`) needs `FixedWidthType` definition for `static T type`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] kou commented on issue #33701: [R] Link-time optimization reports violations of one-definition rule in the R package
Posted by GitBox <gi...@apache.org>.
kou commented on issue #33701:
URL: https://github.com/apache/arrow/issues/33701#issuecomment-1396632780
Ah, it seems that we have more places that construct `arrow::DataType` directly instead of using type construct function such as `arrow::int32()`. The following patch uses type construct function but there are still some places that construct `arrow::DataType` directly:
```diff
diff --git a/cpp/src/arrow/array/builder_nested.h b/cpp/src/arrow/array/builder_nested.h
index 3e9328bfdf..6204aafdcb 100644
--- a/cpp/src/arrow/array/builder_nested.h
+++ b/cpp/src/arrow/array/builder_nested.h
@@ -185,7 +185,8 @@ class BaseListBuilder : public ArrayBuilder {
}
std::shared_ptr<DataType> type() const override {
- return std::make_shared<TYPE>(value_field_->WithType(value_builder_->type()));
+ return TypeTraits<TYPE>::type_instance(
+ value_field_->WithType(value_builder_->type()));
}
protected:
diff --git a/cpp/src/arrow/compute/exec/hash_join_dict.cc b/cpp/src/arrow/compute/exec/hash_join_dict.cc
index 4ce89446d3..aef6244e90 100644
--- a/cpp/src/arrow/compute/exec/hash_join_dict.cc
+++ b/cpp/src/arrow/compute/exec/hash_join_dict.cc
@@ -359,7 +359,7 @@ Result<std::shared_ptr<ArrayData>> HashJoinDictBuild::RemapOutput(
ARROW_ASSIGN_OR_RAISE(std::shared_ptr<ArrayData> indices,
HashJoinDictUtil::ConvertFromInt32(
index_type_, Datum(indices32Bit), indices32Bit.length, ctx));
- auto type = std::make_shared<DictionaryType>(index_type_, value_type_);
+ auto type = dictionary(index_type_, value_type_);
return ArrayData::Make(type, indices->length, indices->buffers, {},
unified_dictionary_);
}
diff --git a/cpp/src/arrow/compute/kernels/scalar_temporal_unary.cc b/cpp/src/arrow/compute/kernels/scalar_temporal_unary.cc
index c0dc747e49..ce54473c38 100644
--- a/cpp/src/arrow/compute/kernels/scalar_temporal_unary.cc
+++ b/cpp/src/arrow/compute/kernels/scalar_temporal_unary.cc
@@ -1299,7 +1299,7 @@ struct Strptime {
return Status::OK();
} else {
return Status::Invalid("Failed to parse string: '", s, "' as a scalar of type ",
- TimestampType(self.unit).ToString());
+ timestamp(self.unit)->ToString());
}
};
RETURN_NOT_OK(VisitArraySpanInline<InType>(in, visit_value, visit_null));
diff --git a/cpp/src/arrow/type_traits.h b/cpp/src/arrow/type_traits.h
index 5873969066..e98816a418 100644
--- a/cpp/src/arrow/type_traits.h
+++ b/cpp/src/arrow/type_traits.h
@@ -415,6 +415,14 @@ struct TypeTraits<ListType> {
using OffsetBuilderType = Int32Builder;
using OffsetScalarType = Int32Scalar;
constexpr static bool is_parameter_free = false;
+ static inline std::shared_ptr<DataType> type_instance(
+ const std::shared_ptr<Field>& value_type) {
+ return list(value_type);
+ }
+ static inline std::shared_ptr<DataType> type_instance(
+ const std::shared_ptr<DataType>& value_type) {
+ return list(value_type);
+ }
};
template <>
@@ -427,6 +435,14 @@ struct TypeTraits<LargeListType> {
using OffsetBuilderType = Int64Builder;
using OffsetScalarType = Int64Scalar;
constexpr static bool is_parameter_free = false;
+ static inline std::shared_ptr<DataType> type_instance(
+ const std::shared_ptr<Field>& value_type) {
+ return large_list(value_type);
+ }
+ static inline std::shared_ptr<DataType> type_instance(
+ const std::shared_ptr<DataType>& value_type) {
+ return large_list(value_type);
+ }
};
template <>
diff --git a/cpp/src/arrow/util/byte_size.cc b/cpp/src/arrow/util/byte_size.cc
index fe232c9acc..e43d4316c3 100644
--- a/cpp/src/arrow/util/byte_size.cc
+++ b/cpp/src/arrow/util/byte_size.cc
@@ -131,13 +131,13 @@ struct GetByteRangesArray {
return Status::OK();
}
- Status VisitFixedWidthArray(const Buffer& buffer, const FixedWidthType& type) const {
+ Status VisitFixedWidthArray(const Buffer& buffer, const FixedWidthType* type) const {
uint64_t data_start = reinterpret_cast<uint64_t>(buffer.data());
- uint64_t offset_bits = offset * type.bit_width();
+ uint64_t offset_bits = offset * type->bit_width();
uint64_t offset_bytes = bit_util::RoundDown(static_cast<int64_t>(offset_bits), 8) / 8;
uint64_t end_byte =
- bit_util::RoundUp(static_cast<int64_t>(offset_bits + (length * type.bit_width())),
- 8) /
+ bit_util::RoundUp(
+ static_cast<int64_t>(offset_bits + (length * type->bit_width())), 8) /
8;
uint64_t length_bytes = (end_byte - offset_bytes);
RETURN_NOT_OK(range_starts->Append(data_start));
@@ -149,7 +149,7 @@ struct GetByteRangesArray {
static_assert(sizeof(uint8_t*) <= sizeof(uint64_t),
"Undefined behavior if pointer larger than uint64_t");
RETURN_NOT_OK(VisitBitmap(input.buffers[0]));
- RETURN_NOT_OK(VisitFixedWidthArray(*input.buffers[1], type));
+ RETURN_NOT_OK(VisitFixedWidthArray(*input.buffers[1], &type));
if (input.dictionary) {
// This is slightly imprecise because we always assume the entire dictionary is
// referenced. If this array has an offset it may only be referencing a portion of
@@ -241,11 +241,11 @@ struct GetByteRangesArray {
Status Visit(const DenseUnionType& type) const {
// Skip validity map for DenseUnionType
// Types buffer is always int8
- RETURN_NOT_OK(VisitFixedWidthArray(
- *input.buffers[1], *std::dynamic_pointer_cast<FixedWidthType>(int8())));
+ RETURN_NOT_OK(VisitFixedWidthArray(*input.buffers[1],
+ static_cast<FixedWidthType*>(int8().get())));
// Offsets buffer is always int32
- RETURN_NOT_OK(VisitFixedWidthArray(
- *input.buffers[2], *std::dynamic_pointer_cast<FixedWidthType>(int32())));
+ RETURN_NOT_OK(VisitFixedWidthArray(*input.buffers[2],
+ static_cast<FixedWidthType*>(int32().get())));
// We have to loop through the types buffer to figure out the correct
// offset / length being referenced in the child arrays
@@ -278,8 +278,8 @@ struct GetByteRangesArray {
Status Visit(const SparseUnionType& type) const {
// Skip validity map for SparseUnionType
// Types buffer is always int8
- RETURN_NOT_OK(VisitFixedWidthArray(
- *input.buffers[1], *std::dynamic_pointer_cast<FixedWidthType>(int8())));
+ RETURN_NOT_OK(VisitFixedWidthArray(*input.buffers[1],
+ static_cast<FixedWidthType*>(int8().get())));
for (int i = 0; i < type.num_fields(); i++) {
GetByteRangesArray child{*input.child_data[i],
diff --git a/cpp/src/arrow/util/value_parsing.h b/cpp/src/arrow/util/value_parsing.h
index 5193f0af75..d444bf68ec 100644
--- a/cpp/src/arrow/util/value_parsing.h
+++ b/cpp/src/arrow/util/value_parsing.h
@@ -920,8 +920,8 @@ bool ParseValue(const T& type, const char* s, size_t length,
template <typename T>
enable_if_parameter_free<T, bool> ParseValue(
const char* s, size_t length, typename StringConverter<T>::value_type* out) {
- static T type;
- return StringConverter<T>{}.Convert(type, s, length, out);
+ auto type = std::static_pointer_cast<T>(TypeTraits<T>::type_singleton());
+ return StringConverter<T>{}.Convert(*type, s, length, out);
}
} // namespace internal
diff --git a/r/src/r_to_arrow.cpp b/r/src/r_to_arrow.cpp
index 89b4ba2e05..75b23db631 100644
--- a/r/src/r_to_arrow.cpp
+++ b/r/src/r_to_arrow.cpp
@@ -1262,7 +1262,7 @@ std::shared_ptr<Array> MakeSimpleArray(SEXP x) {
buffers[0] = std::move(null_bitmap);
}
- auto data = ArrayData::Make(std::make_shared<Type>(), LENGTH(x), std::move(buffers),
+ auto data = ArrayData::Make(TypeTraits<Type>::type_singleton(), LENGTH(x), std::move(buffers),
null_count, 0 /*offset*/);
// return the right Array class
@@ -1387,7 +1387,7 @@ bool vector_from_r_memory_impl(SEXP x, const std::shared_ptr<DataType>& type,
buffers[0] = std::move(null_bitmap);
}
- auto data = ArrayData::Make(std::make_shared<Type>(), n, std::move(buffers),
+ auto data = ArrayData::Make(TypeTraits<Type>::type_singleton(), n, std::move(buffers),
null_count, 0 /*offset*/);
auto array = std::make_shared<typename TypeTraits<Type>::ArrayType>(data);
columns[j] = std::make_shared<arrow::ChunkedArray>(array);
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] assignUser commented on issue #33701: Link-time optimization reports violations of one-definition rule in the R package
Posted by GitBox <gi...@apache.org>.
assignUser commented on issue #33701:
URL: https://github.com/apache/arrow/issues/33701#issuecomment-1384143690
Hm, maybe? But I feel it's unlikely because the cached file would have to be successful build before being cached... Maybe it's some weird transitive thing?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] assignUser commented on issue #33701: Link-time optimization reports violations of one-definition rule in the R package
Posted by GitBox <gi...@apache.org>.
assignUser commented on issue #33701:
URL: https://github.com/apache/arrow/issues/33701#issuecomment-1384189783
Remove https://github.com/apache/arrow/blob/master/dev/tasks/r/azure.linux.yml#L66
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] paleolimbot commented on issue #33701: [R] Link-time optimization reports violations of one-definition rule in the R package
Posted by GitBox <gi...@apache.org>.
paleolimbot commented on issue #33701:
URL: https://github.com/apache/arrow/issues/33701#issuecomment-1398444291
Adding those patches to #33722 I get test segfaults: https://github.com/apache/arrow/actions/runs/3961611391/jobs/6787262761#step:6:13839
Unless somebody who actually knows what LTO is and how it works thinks otherwise, I think it's best to wait until CRAN actually reports a problem here...they ignore *some* LTO failures and we won't know until the package is built in their environment whether or not those errors will actually show up. If there are no problems in the release, we'll need to figure out how to modify the nightly job to stop erroring.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] paleolimbot commented on issue #33701: Link-time optimization reports violations of one-definition rule in the R package
Posted by GitBox <gi...@apache.org>.
paleolimbot commented on issue #33701:
URL: https://github.com/apache/arrow/issues/33701#issuecomment-1384184114
In the context of:
https://github.com/apache/arrow/blob/fa2f45d3411eeb6d2572c3d246076623620e50d2/dev/tasks/tasks.yml#L1357-L1367
...how would I do that?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] cyb70289 closed issue #33701: [R] Link-time optimization reports violations of one-definition rule in the R package
Posted by "cyb70289 (via GitHub)" <gi...@apache.org>.
cyb70289 closed issue #33701: [R] Link-time optimization reports violations of one-definition rule in the R package
URL: https://github.com/apache/arrow/issues/33701
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] paleolimbot commented on issue #33701: Link-time optimization reports violations of one-definition rule in the R package
Posted by GitBox <gi...@apache.org>.
paleolimbot commented on issue #33701:
URL: https://github.com/apache/arrow/issues/33701#issuecomment-1384139407
@assignUser could that be an sccache thing? Like...the cache hit generates a .o file where identical definitions from different filenames are treated identically?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] paleolimbot commented on issue #33701: Link-time optimization reports violations of one-definition rule in the R package
Posted by GitBox <gi...@apache.org>.
paleolimbot commented on issue #33701:
URL: https://github.com/apache/arrow/issues/33701#issuecomment-1384363393
Hmm...not transient and not cache-related. Somehow there are includes from two different Arrow source trees making their way into the .o files.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] kou commented on issue #33701: [R] Link-time optimization reports violations of one-definition rule in the R package
Posted by GitBox <gi...@apache.org>.
kou commented on issue #33701:
URL: https://github.com/apache/arrow/issues/33701#issuecomment-1396633315
BTW, is LTO support important in R?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] assignUser commented on issue #33701: Link-time optimization reports violations of one-definition rule in the R package
Posted by GitBox <gi...@apache.org>.
assignUser commented on issue #33701:
URL: https://github.com/apache/arrow/issues/33701#issuecomment-1384145137
You could modify the workflow to remove the sccache envvars which will disable it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] paleolimbot commented on issue #33701: Link-time optimization reports violations of one-definition rule in the R package
Posted by GitBox <gi...@apache.org>.
paleolimbot commented on issue #33701:
URL: https://github.com/apache/arrow/issues/33701#issuecomment-1384445708
I'll continue to investigate, but I'm removing any blocker status for this for the release because it is unlikely to show up unless there are two installations of Arrow involved. If I can replicate this somewhere else and we think it will be a problem for the CRAN check, we will pick the fix into our CRAN packaging branch.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] paleolimbot commented on issue #33701: [R] Link-time optimization reports violations of one-definition rule in the R package
Posted by GitBox <gi...@apache.org>.
paleolimbot commented on issue #33701:
URL: https://github.com/apache/arrow/issues/33701#issuecomment-1385698194
It's a slightly different error now?
https://dev.azure.com/ursacomputing/crossbow/_build/results?buildId=42785&view=logs&j=0da5d1d9-276d-5173-c4c4-9d4d4ed14fdb&t=6c939d89-0d1a-51f2-8b30-091a7a82e98c&l=1591
```
/arrow/cpp/src/arrow/type.h:323: warning: virtual table of type ‘struct NestedType’ violates one definition rule [-Wodr]
323 | class ARROW_EXPORT NestedType : public DataType, public ParametricType {
|
/arrow/r/check/arrow.Rcheck/00_pkg_src/arrow/libarrow/arrow-10.0.1.9000/include/arrow/type.h:323:20: note: the conflicting type defined in another translation unit
323 | class ARROW_EXPORT NestedType : public DataType, public ParametricType {
| ^
/arrow/r/check/arrow.Rcheck/00_pkg_src/arrow/libarrow/arrow-10.0.1.9000/include/arrow/type.h:177:22: note: virtual method ‘storage_id’
177 | virtual Type::type storage_id() const { return id_; }
| ^
<built-in>: note: ought to match virtual method ‘__cxa_pure_virtual’ but does not
/arrow/cpp/src/arrow/type.h:288: warning: virtual table of type ‘struct FixedWidthType’ violates one definition rule [-Wodr]
288 | class ARROW_EXPORT FixedWidthType : public DataType {
|
/arrow/r/check/arrow.Rcheck/00_pkg_src/arrow/libarrow/arrow-10.0.1.9000/include/arrow/type.h:288:20: note: the conflicting type defined in another translation unit
288 | class ARROW_EXPORT FixedWidthType : public DataType {
| ^
/arrow/r/check/arrow.Rcheck/00_pkg_src/arrow/libarrow/arrow-10.0.1.9000/include/arrow/type.h:177:22: note: virtual method ‘storage_id’
177 | virtual Type::type storage_id() const { return id_; }
| ^
<built-in>: note: ought to match virtual method ‘__cxa_pure_virtual’ but does not
lto-wrapper: warning: using serial compilation of 128 LTRANS jobs
lto-wrapper: note: see the ‘-flto’ option documentation for more information
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org