[GitHub] [airflow] kaxil commented on a change in pull request #14895: Add REST API query sort and order to some endpoints

[GitBox <gi...@apache.org>]

kaxil commented on a change in pull request #14895:
URL: https://github.com/apache/airflow/pull/14895#discussion_r598151585



##########
File path: airflow/api_connexion/endpoints/dag_endpoint.py
##########
@@ -59,10 +60,18 @@ def get_dag_details(dag_id):
 
 @security.requires_access([(permissions.ACTION_CAN_READ, permissions.RESOURCE_DAG)])
 @format_parameters({'limit': check_limit})
-def get_dags(limit, offset=0):
+def get_dags(limit, sort, offset=0, order_by=None):

Review comment:
       Probably worth doing the following, instead of the `if` statement and since that was the behaviour before this PR, it would be ok, WDYT?
   ```suggestion
   def get_dags(limit, sort="asc", offset=0, order_by=DagModel.dag_id):
   ```




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org