You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@rocketmq.apache.org by "cserwen (via GitHub)" <gi...@apache.org> on 2023/05/23 04:05:53 UTC
[GitHub] [rocketmq] cserwen opened a new pull request, #6796: [ISSUE #6795] feat: support to send transaction msg with lmqQueue property
cserwen opened a new pull request, #6796:
URL: https://github.com/apache/rocketmq/pull/6796
<!-- Please make sure the target branch is right. In most case, the target branch should be `develop`. -->
### Which Issue(s) This PR Fixes
<!-- Please ensure that the related issue has already been created, and [link this pull request to that issue using keywords](<https://docs.github.com/en/issues/tracking-your-work-with-issues/linking-a-pull-request-to-an-issue#linking-a-pull-request-to-an-issue-using-a-keyword>) to ensure automatic closure. -->
Fixes #6795
### Brief Description
<!-- Write a brief description for your pull request to help the maintainer understand the reasons behind your changes. -->
### How Did You Test This Change?
<!-- In order to ensure the code quality of Apache RocketMQ, we expect every pull request to have undergone thorough testing. -->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq] cserwen commented on pull request #6796: [ISSUE #6795] feat: support to send transaction msg with lmqQueue property
Posted by "cserwen (via GitHub)" <gi...@apache.org>.
cserwen commented on PR #6796:
URL: https://github.com/apache/rocketmq/pull/6796#issuecomment-1629999882
@HScarb Plz help me to review this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq] codecov-commenter commented on pull request #6796: [ISSUE #6795] feat: support to send transaction msg with lmqQueue property
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #6796:
URL: https://github.com/apache/rocketmq/pull/6796#issuecomment-1558503711
## [Codecov](https://app.codecov.io/gh/apache/rocketmq/pull/6796?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
> Merging [#6796](https://app.codecov.io/gh/apache/rocketmq/pull/6796?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (bdbbbe8) into [develop](https://app.codecov.io/gh/apache/rocketmq/commit/f33ac2a3ece691bc15cb875726b5ad054a60ae22?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (f33ac2a) will **increase** coverage by `0.00%`.
> The diff coverage is `14.28%`.
```diff
@@ Coverage Diff @@
## develop #6796 +/- ##
===========================================
Coverage 42.89% 42.90%
+ Complexity 9007 8990 -17
===========================================
Files 1113 1104 -9
Lines 78591 78384 -207
Branches 10221 10210 -11
===========================================
- Hits 33709 33627 -82
+ Misses 40659 40536 -123
+ Partials 4223 4221 -2
```
| [Impacted Files](https://app.codecov.io/gh/apache/rocketmq/pull/6796?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...a/org/apache/rocketmq/broker/BrokerController.java](https://app.codecov.io/gh/apache/rocketmq/pull/6796?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-YnJva2VyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9yb2NrZXRtcS9icm9rZXIvQnJva2VyQ29udHJvbGxlci5qYXZh) | `43.46% <0.00%> (-0.08%)` | :arrow_down: |
| [...apache/rocketmq/broker/slave/SlaveSynchronize.java](https://app.codecov.io/gh/apache/rocketmq/pull/6796?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-YnJva2VyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9yb2NrZXRtcS9icm9rZXIvc2xhdmUvU2xhdmVTeW5jaHJvbml6ZS5qYXZh) | `4.16% <0.00%> (-0.03%)` | :arrow_down: |
| [...n/java/org/apache/rocketmq/store/ConsumeQueue.java](https://app.codecov.io/gh/apache/rocketmq/pull/6796?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3RvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3JvY2tldG1xL3N0b3JlL0NvbnN1bWVRdWV1ZS5qYXZh) | `66.19% <50.00%> (-0.32%)` | :arrow_down: |
... and [59 files with indirect coverage changes](https://app.codecov.io/gh/apache/rocketmq/pull/6796/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq] cserwen commented on pull request #6796: [ISSUE #6795] feat: support to send transaction msg with lmqQueue property
Posted by "cserwen (via GitHub)" <gi...@apache.org>.
cserwen commented on PR #6796:
URL: https://github.com/apache/rocketmq/pull/6796#issuecomment-1563755852
> checkMultiDispatchQueue
I don't think this is necessary. We have checked the message and assigned the queueOffset when writing it. If the index is not built because the check fails in the `checkMultiDispatchQueue`, the index offset will be discontinuous. However, in `checkMultiDispatchQueue` format validation is necessary.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org