You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@kafka.apache.org by Jay Kreps <bo...@gmail.com> on 2014/04/18 22:03:02 UTC
Re: Review Request 20471: KAFKA-1398: Follow-up comments on dynamic config
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20471/
-----------------------------------------------------------
(Updated April 18, 2014, 8:03 p.m.)
Review request for kafka.
Summary (updated)
-----------------
KAFKA-1398: Follow-up comments on dynamic config
Bugs: KAFKA-1398
https://issues.apache.org/jira/browse/KAFKA-1398
Repository: kafka
Description (updated)
-------
KAFKA-1398 Dynamic config follow-on-comments.
Diffs (updated)
-----
core/src/main/scala/kafka/server/TopicConfigManager.scala 4a4274eef790ff1fd2dfbbd85d44722688bfadee
core/src/test/scala/unit/kafka/server/DynamicConfigChangeTest.scala 5a1d5cc36033d0427c6c680d198c02207e10326c
Diff: https://reviews.apache.org/r/20471/diff/
Testing
-------
Thanks,
Jay Kreps
Re: Review Request 20471: KAFKA-1398: Follow-up comments on dynamic config
Posted by Joel Koshy <jj...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20471/#review40809
-----------------------------------------------------------
Ship it!
Ship It!
- Joel Koshy
On April 18, 2014, 8:03 p.m., Jay Kreps wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/20471/
> -----------------------------------------------------------
>
> (Updated April 18, 2014, 8:03 p.m.)
>
>
> Review request for kafka.
>
>
> Bugs: KAFKA-1398
> https://issues.apache.org/jira/browse/KAFKA-1398
>
>
> Repository: kafka
>
>
> Description
> -------
>
> KAFKA-1398 Dynamic config follow-on-comments.
>
>
> Diffs
> -----
>
> core/src/main/scala/kafka/server/TopicConfigManager.scala 4a4274eef790ff1fd2dfbbd85d44722688bfadee
> core/src/test/scala/unit/kafka/server/DynamicConfigChangeTest.scala 5a1d5cc36033d0427c6c680d198c02207e10326c
>
> Diff: https://reviews.apache.org/r/20471/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Jay Kreps
>
>
Re: Review Request 20471: KAFKA-1398: Follow-up comments on dynamic config
Posted by Jun Rao <ju...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20471/#review40810
-----------------------------------------------------------
Ship it!
Ship It!
- Jun Rao
On April 18, 2014, 8:03 p.m., Jay Kreps wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/20471/
> -----------------------------------------------------------
>
> (Updated April 18, 2014, 8:03 p.m.)
>
>
> Review request for kafka.
>
>
> Bugs: KAFKA-1398
> https://issues.apache.org/jira/browse/KAFKA-1398
>
>
> Repository: kafka
>
>
> Description
> -------
>
> KAFKA-1398 Dynamic config follow-on-comments.
>
>
> Diffs
> -----
>
> core/src/main/scala/kafka/server/TopicConfigManager.scala 4a4274eef790ff1fd2dfbbd85d44722688bfadee
> core/src/test/scala/unit/kafka/server/DynamicConfigChangeTest.scala 5a1d5cc36033d0427c6c680d198c02207e10326c
>
> Diff: https://reviews.apache.org/r/20471/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Jay Kreps
>
>