You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@paimon.apache.org by "humengyu2012 (via GitHub)" <gi...@apache.org> on 2023/11/24 16:11:10 UTC
[PR] Fix timestamp format [incubator-paimon-presto]
humengyu2012 opened a new pull request, #20:
URL: https://github.com/apache/incubator-paimon-presto/pull/20
We found that `timestamp` format is not correct like this:
<img width="217" alt="image" src="https://github.com/apache/incubator-paimon-presto/assets/45056332/49602921-d34f-43ac-92a6-8bb768e50b56">
After this PR, we fixed it:
<img width="204" alt="image" src="https://github.com/apache/incubator-paimon-presto/assets/45056332/16cd0673-0284-462d-a025-f4522c3c914b">
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@paimon.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix timestamp format [incubator-paimon-presto]
Posted by "humengyu2012 (via GitHub)" <gi...@apache.org>.
humengyu2012 commented on PR #20:
URL: https://github.com/apache/incubator-paimon-presto/pull/20#issuecomment-1825997753
I added some test cases, but the behavior of the timestamps is very strange. No matter how I adjust them, the tests are not passing. Could you take a look and help me out? @JingsongLi
<img width="366" alt="image" src="https://github.com/apache/incubator-paimon-presto/assets/45056332/8b124b56-83bc-4f0b-97b8-7a7ba560dab9">
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@paimon.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix timestamp format [incubator-paimon-presto]
Posted by "JingsongLi (via GitHub)" <gi...@apache.org>.
JingsongLi commented on PR #20:
URL: https://github.com/apache/incubator-paimon-presto/pull/20#issuecomment-1827086000
<img width="795" alt="image" src="https://github.com/apache/incubator-paimon-presto/assets/9601882/d05a36db-7bed-431c-9f02-fb119b428684">
In CI, it is another situation...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@paimon.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix timestamp format [incubator-paimon-presto]
Posted by "feloxx (via GitHub)" <gi...@apache.org>.
feloxx commented on PR #20:
URL: https://github.com/apache/incubator-paimon-presto/pull/20#issuecomment-1825877032
lgtm
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@paimon.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix timestamp format [incubator-paimon-presto]
Posted by "JingsongLi (via GitHub)" <gi...@apache.org>.
JingsongLi merged PR #20:
URL: https://github.com/apache/incubator-paimon-presto/pull/20
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@paimon.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix timestamp format [incubator-paimon-presto]
Posted by "humengyu2012 (via GitHub)" <gi...@apache.org>.
humengyu2012 commented on PR #20:
URL: https://github.com/apache/incubator-paimon-presto/pull/20#issuecomment-1826017755
I found that `timestamp.getMillisecond()` and `timestamp.toSQLTimestamp().getTime()` will return different results. What is the difference between these two methods?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@paimon.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org