You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zeppelin.apache.org by zjffdu <gi...@git.apache.org> on 2018/02/02 03:56:35 UTC
[GitHub] zeppelin pull request #2760: [WIP] ZEPPELIN-3196. Plugin framework for Zeppe...
GitHub user zjffdu opened a pull request:
https://github.com/apache/zeppelin/pull/2760
[WIP] ZEPPELIN-3196. Plugin framework for Zeppelin Engine
### What is this PR for?
A few sentences describing the overall goals of the pull request's commits.
First time? Check out the contributing guide - https://zeppelin.apache.org/contribution/contributions.html
### What type of PR is it?
[Bug Fix | Improvement | Feature | Documentation | Hot Fix | Refactoring]
### Todos
* [ ] - Task
### What is the Jira issue?
* Open an issue on Jira https://issues.apache.org/jira/browse/ZEPPELIN/
* Put link here, and add [ZEPPELIN-*Jira number*] in PR title, eg. [ZEPPELIN-533]
### How should this be tested?
* First time? Setup Travis CI as described on https://zeppelin.apache.org/contribution/contributions.html#continuous-integration
* Strongly recommended: add automated unit tests for any new or changed behavior
* Outline any manual steps to test the PR here.
### Screenshots (if appropriate)
### Questions:
* Does the licenses files need update?
* Is there breaking changes for older versions?
* Does this needs documentation?
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/zjffdu/zeppelin ZEPPELIN-3196
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/zeppelin/pull/2760.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2760
----
commit ad3233ab4e6c670a9e1ddc275aed7b810caa22ac
Author: Jeff Zhang <zj...@...>
Date: 2018-01-31T11:46:44Z
ZEPPELIN-3196. Plugin framework for Zeppelin Engine
----
---
[GitHub] zeppelin issue #2760: ZEPPELIN-3196. Plugin framework for Zeppelin Engine
Posted by Tagar <gi...@git.apache.org>.
Github user Tagar commented on the issue:
https://github.com/apache/zeppelin/pull/2760
I wonder if https://github.com/apache/zeppelin/pull/2945 fixes issue I described in my earlier comment.
cc @cvaliente @myuwono
---
[GitHub] zeppelin issue #2760: ZEPPELIN-3196. Plugin framework for Zeppelin Engine
Posted by zjffdu <gi...@git.apache.org>.
Github user zjffdu commented on the issue:
https://github.com/apache/zeppelin/pull/2760
`IS_ZEPPELIN_TEST` is used for unit test for PluginManager. e.g. In NotebookRepoSyncInitializationTest, VFSNotebookRepoMock is just for testing, so could be constructed from classpath directly.
---
[GitHub] zeppelin issue #2760: ZEPPELIN-3196. Plugin framework for Zeppelin Engine
Posted by jongyoul <gi...@git.apache.org>.
Github user jongyoul commented on the issue:
https://github.com/apache/zeppelin/pull/2760
@zjffdu I have a simple question. You introduced `IS_ZEPPELIN_TEST` but how can we use it? do we need to all jars into classpath manually to use `IS_ZEPPELIN_TEST`?
---
[GitHub] zeppelin issue #2760: ZEPPELIN-3196. Plugin framework for Zeppelin Engine
Posted by myuwono <gi...@git.apache.org>.
Github user myuwono commented on the issue:
https://github.com/apache/zeppelin/pull/2760
@Tagar yep! I have it in my private fork for the ServiceLoader fix. Eagerly waiting for the PR to get merged to master.
---
[GitHub] zeppelin issue #2760: ZEPPELIN-3196. Plugin framework for Zeppelin Engine
Posted by zjffdu <gi...@git.apache.org>.
Github user zjffdu commented on the issue:
https://github.com/apache/zeppelin/pull/2760
@Leemoonsoo @jongyoul @prabhjyotsingh @felixcheung Could you help review it ? Thanks, it is for 0.9.
---
[GitHub] zeppelin issue #2760: ZEPPELIN-3196. Plugin framework for Zeppelin Engine
Posted by Leemoonsoo <gi...@git.apache.org>.
Github user Leemoonsoo commented on the issue:
https://github.com/apache/zeppelin/pull/2760
Took a look changes and it looks good to me
---
[GitHub] zeppelin issue #2760: ZEPPELIN-3196. Plugin framework for Zeppelin Engine
Posted by zjffdu <gi...@git.apache.org>.
Github user zjffdu commented on the issue:
https://github.com/apache/zeppelin/pull/2760
Thanks for review, will merge soon
---
[GitHub] zeppelin issue #2760: [WIP] ZEPPELIN-3196. Plugin framework for Zeppelin Eng...
Posted by zjffdu <gi...@git.apache.org>.
Github user zjffdu commented on the issue:
https://github.com/apache/zeppelin/pull/2760
I haven't updated the description, will do that after the PR is ready, It is still WIP
---
[GitHub] zeppelin issue #2760: [WIP] ZEPPELIN-3196. Plugin framework for Zeppelin Eng...
Posted by masyan <gi...@git.apache.org>.
Github user masyan commented on the issue:
https://github.com/apache/zeppelin/pull/2760
@zjffdu
a strange description of PR )
---
[GitHub] zeppelin issue #2760: ZEPPELIN-3196. Plugin framework for Zeppelin Engine
Posted by Tagar <gi...@git.apache.org>.
Github user Tagar commented on the issue:
https://github.com/apache/zeppelin/pull/2760
@zjffdu, just updated to master, and noticed versioning toolbar is missing...
I think it's because of this PR.
We have `zeppelin.notebook.storage`=`org.apache.zeppelin.notebook.repo.GitNotebookRepo` in `zeppelin-site.xml` .. is there is some additional setting required now,
or perhaps Zeppelin now has to be build differently?
Thanks!
---
[GitHub] zeppelin pull request #2760: ZEPPELIN-3196. Plugin framework for Zeppelin En...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/zeppelin/pull/2760
---