You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@thrift.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2017/07/26 19:14:00 UTC
[jira] [Commented] (THRIFT-4264) PHP - Support both shared & static
linking of sockets library
[ https://issues.apache.org/jira/browse/THRIFT-4264?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16102140#comment-16102140 ]
ASF GitHub Bot commented on THRIFT-4264:
----------------------------------------
GitHub user norrs opened a pull request:
https://github.com/apache/thrift/pull/1315
THRIFT-4264: Fix PHP tests requiring sockets.so
The PHP library requires sockets.so for the socket_import_stream() function.
Make it available for the tests by symlinking in the module.
Patch: Håkon Hitland <ha...@zedge.net>
This closes #4264
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/norrs/thrift THRIFT-4264
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/thrift/pull/1315.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1315
----
commit 65257ae869cdc218b49125e5a01ec1d8fa2fab13
Author: Håkon Hitland <ha...@zedge.net>
Date: 2017-07-25T14:38:26Z
THRIFT-4264: Fix PHP tests requiring sockets.so
The PHP library requires sockets.so for the socket_import_stream() function.
Make it available for the tests by symlinking in the module.
Patch: Håkon Hitland <ha...@zedge.net>
This closes #4264
----
> PHP - Support both shared & static linking of sockets library
> -------------------------------------------------------------
>
> Key: THRIFT-4264
> URL: https://issues.apache.org/jira/browse/THRIFT-4264
> Project: Thrift
> Issue Type: Test
> Components: PHP - Library
> Affects Versions: 0.11.0
> Reporter: Roy Sindre Norangshol
> Priority: Minor
>
> THRIFT-4218 introduced TCP_NODELAY for the PHP client socket by the usage of
> {code:java}
> socket_import_stream()
> {code}. This requires PHP to be buildt with --enable-sockets or --enable-sockets=shared.
> Test environment should support usage of both ways of compiling PHP.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)