You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by "sebastianliebscher (via GitHub)" <gi...@apache.org> on 2023/06/16 10:58:22 UTC
[GitHub] [superset] sebastianliebscher opened a new pull request, #24426: chore: bump prophet and holidays (predictive forecasting)
sebastianliebscher opened a new pull request, #24426:
URL: https://github.com/apache/superset/pull/24426
### SUMMARY
This PR bumps optional dependency `prophet` for the predictive forecasting feature. Prophet made huge performance gains in the last releases https://github.com/facebook/prophet/releases and dropped some dependencies.
> Sped up .predict() by up to 10x by removing intermediate DataFrame creations.
Also bumped `holidays` as needed for prophet. https://github.com/dr-prodigy/python-holidays/releases
Note: Although prophet worked before and after the bump, their related integration tests still fail https://github.com/apache/superset/issues/24406. So this PR may be blocked by this issue.
### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
### TESTING INSTRUCTIONS
- `pip install -e '.[prophet]'`
- Setup Line chart and enable predictive forecast
### ADDITIONAL INFORMATION
- [ ] Has associated issue:
- [ ] Required feature flags:
- [ ] Changes UI
- [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351))
- [ ] Migration is atomic, supports rollback & is backwards-compatible
- [ ] Confirm DB migration upgrade and downgrade tested
- [ ] Runtime estimates and downtime expectations provided
- [ ] Introduces new feature or API
- [ ] Removes existing feature or API
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] sebastianliebscher commented on pull request #24426: chore: bump prophet and holidays (predictive forecasting)
Posted by "sebastianliebscher (via GitHub)" <gi...@apache.org>.
sebastianliebscher commented on PR #24426:
URL: https://github.com/apache/superset/pull/24426#issuecomment-1594570798
@villebro maybe you can also have a look at this discussion https://github.com/apache/superset/issues/24357
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] villebro commented on pull request #24426: chore: bump prophet and holidays (predictive forecasting)
Posted by "villebro (via GitHub)" <gi...@apache.org>.
villebro commented on PR #24426:
URL: https://github.com/apache/superset/pull/24426#issuecomment-1594518577
Nice one @sebastianliebscher ! ❤️ FYI, @john-bodley has a related PR in the works, but maybe we can get this merged first and then fast follow John's PR to get those tests etc cleaned up.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] john-bodley commented on pull request #24426: chore: bump prophet and holidays (predictive forecasting)
Posted by "john-bodley (via GitHub)" <gi...@apache.org>.
john-bodley commented on PR #24426:
URL: https://github.com/apache/superset/pull/24426#issuecomment-1594913290
@sebastianliebscher thanks for the PR. Personally I would prefer https://github.com/apache/superset/pull/24129 as it reenables the tests which highlighted a few issues with the way `prophet` was used/configured.
There's a CI issue I still need to look into, i.e., for some reason the test fails on MySQL but works for SQLite and Postgres.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] sebastianliebscher commented on pull request #24426: chore: bump prophet and holidays (predictive forecasting)
Posted by "sebastianliebscher (via GitHub)" <gi...@apache.org>.
sebastianliebscher commented on PR #24426:
URL: https://github.com/apache/superset/pull/24426#issuecomment-1595142780
Oh, sorry I didn't see your PR which will handle the bump + fixing the tests.
Closed in favor of https://github.com/apache/superset/pull/24129
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] sebastianliebscher closed pull request #24426: chore: bump prophet and holidays (predictive forecasting)
Posted by "sebastianliebscher (via GitHub)" <gi...@apache.org>.
sebastianliebscher closed pull request #24426: chore: bump prophet and holidays (predictive forecasting)
URL: https://github.com/apache/superset/pull/24426
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] commented on pull request #24426: chore: bump prophet and holidays (predictive forecasting)
Posted by "codecov[bot] (via GitHub)" <gi...@apache.org>.
codecov[bot] commented on PR #24426:
URL: https://github.com/apache/superset/pull/24426#issuecomment-1594504827
## [Codecov](https://app.codecov.io/gh/apache/superset/pull/24426?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
> Merging [#24426](https://app.codecov.io/gh/apache/superset/pull/24426?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (4e74339) into [master](https://app.codecov.io/gh/apache/superset/commit/23bb1c48a13236b47cdbff65f3de6658204e7168?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (23bb1c4) will **decrease** coverage by `10.90%`.
> The diff coverage is `n/a`.
> :exclamation: Current head 4e74339 differs from pull request most recent head a81892d. Consider uploading reports for the commit a81892d to get more accurate results
```diff
@@ Coverage Diff @@
## master #24426 +/- ##
===========================================
- Coverage 68.91% 58.02% -10.90%
===========================================
Files 1904 1904
Lines 73920 73920
Branches 8119 8119
===========================================
- Hits 50944 42894 -8050
- Misses 20865 28915 +8050
Partials 2111 2111
```
| Flag | Coverage Δ | |
|---|---|---|
| hive | `?` | |
| mysql | `?` | |
| postgres | `?` | |
| presto | `53.85% <ø> (ø)` | |
| python | `60.59% <ø> (-22.69%)` | :arrow_down: |
| sqlite | `?` | |
| unit | `54.62% <ø> (ø)` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
[see 302 files with indirect coverage changes](https://app.codecov.io/gh/apache/superset/pull/24426/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org