You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@nifi.apache.org by pvillard31 <gi...@git.apache.org> on 2018/01/25 15:29:37 UTC
[GitHub] nifi pull request #2432: NIFI-4815 - Add EL support to ExecuteProcess
GitHub user pvillard31 opened a pull request:
https://github.com/apache/nifi/pull/2432
NIFI-4815 - Add EL support to ExecuteProcess
Thank you for submitting a contribution to Apache NiFi.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
### For all changes:
- [ ] Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?
- [ ] Does your PR title start with NIFI-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
- [ ] Has your PR been rebased against the latest commit within the target branch (typically master)?
- [ ] Is your initial contribution a single, squashed commit?
### For code changes:
- [ ] Have you ensured that the full suite of tests is executed via mvn -Pcontrib-check clean install at the root nifi folder?
- [ ] Have you written or updated unit tests to verify your changes?
- [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)?
- [ ] If applicable, have you updated the LICENSE file, including the main LICENSE file under nifi-assembly?
- [ ] If applicable, have you updated the NOTICE file, including the main NOTICE file found under nifi-assembly?
- [ ] If adding new Properties, have you added .displayName in addition to .name (programmatic access) for each of the new properties?
### For documentation related changes:
- [ ] Have you ensured that format looks appropriate for the output in which it is rendered?
### Note:
Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/pvillard31/nifi NIFI-4815
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/nifi/pull/2432.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2432
----
commit 6022373914ee05ca7b97709fcd51f9b233541958
Author: Pierre Villard <pi...@...>
Date: 2018-01-25T15:29:10Z
NIFI-4815 - Add EL support to ExecuteProcess
----
---
[GitHub] nifi issue #2432: NIFI-4815 - Add EL support to ExecuteProcess
Posted by MikeThomsen <gi...@git.apache.org>.
Github user MikeThomsen commented on the issue:
https://github.com/apache/nifi/pull/2432
+1 LGTM Ran it, and it worked fine.
---
[GitHub] nifi issue #2432: NIFI-4815 - Add EL support to ExecuteProcess
Posted by mattyb149 <gi...@git.apache.org>.
Github user mattyb149 commented on the issue:
https://github.com/apache/nifi/pull/2432
+1 from me as well, everything's working nicely. Thanks for the improvement! Merging to master
---
[GitHub] nifi issue #2432: NIFI-4815 - Add EL support to ExecuteProcess
Posted by mattyb149 <gi...@git.apache.org>.
Github user mattyb149 commented on the issue:
https://github.com/apache/nifi/pull/2432
Thanks for the review @MikeThomsen ! I'll give it a try too and merge after
---
[GitHub] nifi pull request #2432: NIFI-4815 - Add EL support to ExecuteProcess
Posted by MikeThomsen <gi...@git.apache.org>.
Github user MikeThomsen commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2432#discussion_r164268334
--- Diff: nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/test/java/org/apache/nifi/processors/standard/TestExecuteProcess.java ---
@@ -127,6 +128,10 @@ public void validateProcessInterruptOnStop() throws Exception {
fail();
}
+ final List<MockFlowFile> flowFiles = runner.getFlowFilesForRelationship(ExecuteProcess.REL_SUCCESS);
+ if(!flowFiles.isEmpty()) {
--- End diff --
Nit: there should be a space between the if and the (
---
[GitHub] nifi pull request #2432: NIFI-4815 - Add EL support to ExecuteProcess
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/nifi/pull/2432
---
[GitHub] nifi issue #2432: NIFI-4815 - Add EL support to ExecuteProcess
Posted by MikeThomsen <gi...@git.apache.org>.
Github user MikeThomsen commented on the issue:
https://github.com/apache/nifi/pull/2432
@markap14 @alopresto @joewitt When I ran this branch it worked fine for me. I think it's OK to sign off for merge.
---