You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@openjpa.apache.org by st...@apache.org on 2021/04/10 15:08:34 UTC
[openjpa] branch master updated: OPENJPA-2866 no need to test JDBC2
feature
This is an automated email from the ASF dual-hosted git repository.
struberg pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/openjpa.git
The following commit(s) were added to refs/heads/master by this push:
new 3b51096 OPENJPA-2866 no need to test JDBC2 feature
3b51096 is described below
commit 3b51096dae69634322c8d92cb1f3317f3a25024a
Author: Mark Struberg <st...@apache.org>
AuthorDate: Sat Apr 10 17:06:59 2021 +0200
OPENJPA-2866 no need to test JDBC2 feature
Oracle comes with JDBC4. We can safely assume that
Statement#getGeneratedKeys is always available.
Oracle relies on it and will fail without.
---
.../org/apache/openjpa/persistence/identity/TestGenerationType.java | 5 +++++
1 file changed, 5 insertions(+)
diff --git a/openjpa-persistence-jdbc/src/test/java/org/apache/openjpa/persistence/identity/TestGenerationType.java b/openjpa-persistence-jdbc/src/test/java/org/apache/openjpa/persistence/identity/TestGenerationType.java
index 5262cbd..9c70fc4 100644
--- a/openjpa-persistence-jdbc/src/test/java/org/apache/openjpa/persistence/identity/TestGenerationType.java
+++ b/openjpa-persistence-jdbc/src/test/java/org/apache/openjpa/persistence/identity/TestGenerationType.java
@@ -25,6 +25,7 @@ import javax.persistence.EntityTransaction;
import javax.persistence.Query;
import org.apache.openjpa.jdbc.conf.JDBCConfiguration;
+import org.apache.openjpa.jdbc.sql.OracleDictionary;
import org.apache.openjpa.persistence.OpenJPAEntityManager;
import org.apache.openjpa.persistence.test.SingleEMFTestCase;
@@ -117,6 +118,10 @@ public class TestGenerationType
}
public void testQueryWithoutGetGeneratedKeys() {
+ if (getDBDictionary() instanceof OracleDictionary) {
+ // Oracle now always has JDBC4 driver.
+ return;
+ }
testQuery();
}